jank/LF8
2
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 13 Wiki Activity

feat: Implement feature to list all employees from a project (SCRUM-46) #36

Merged
ptran merged 4 commits from feature/get-employees-from-project into main 2024-10-23 10:19:33 +00:00
Conversation 3 Commits 4 Files Changed 22 +263 -28
ptran commented 2024-10-23 10:11:46 +00:00
Collaborator
Copy Link
No description provided.
ptran added 3 commits 2024-10-23 10:11:47 +00:00
RenaimngÄ#
Some checks failed
Quality Check / Tests (pull_request) Successful in 1m7s
Details
Build PR / Build and analyze (pull_request) Successful in 1m44s
Details
gitea-sonarqube-bot ERROR
Details
Quality Check / Checkstyle Main (pull_request) Successful in 37s
Details
5ec316473b
ptran changed title from feat: Implement feature to list all employees from a project to feat: Implement feature to list all employees from a project (SCRUM-46) 2024-10-23 10:13:12 +00:00
SonarQube commented 2024-10-23 10:13:33 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Code Smells 1
Bugs 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Code Smells | 1 | | Bugs | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=36" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank requested changes 2024-10-23 10:14:21 +00:00
Dismissed
src/main/java/de/szut/lf8_starter/exceptionHandling/GlobalExceptionHandler.java Outdated
@ -31,3 +31,3 @@
public ResponseEntity<ErrorDetails> handleAllOtherExceptions(Exception ex, WebRequest request) {
ErrorDetails errorDetails = new ErrorDetails(new Date(), ex.getClass() + " " + ex.getMessage(), request.getDescription(false));
System.out.println(ex);
jank commented 2024-10-23 10:13:25 +00:00
Owner
Copy Link

remove this

remove this
ptran marked this conversation as resolved
ptran added 1 commit 2024-10-23 10:14:26 +00:00
Remove debugging statement
All checks were successful
Quality Check / Tests (pull_request) Successful in 1m8s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 38s
Details
Build PR / Build and analyze (pull_request) Successful in 1m50s
Details
gitea-sonarqube-bot OK
Details
a3c48852db
ptran force-pushed feature/get-employees-from-project from a3c48852db to c10c50190b 2024-10-23 10:15:07 +00:00 Compare
SonarQube commented 2024-10-23 10:16:19 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Bugs 0
Code Smells 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Bugs | 0 | | Code Smells | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=36" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
SonarQube commented 2024-10-23 10:18:03 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Code Smells 0
Bugs 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Code Smells | 0 | | Bugs | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=36" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
ptran scheduled this pull request to auto merge when all checks succeed 2024-10-23 10:18:57 +00:00
jank approved these changes 2024-10-23 10:19:31 +00:00
ptran merged commit 202805e3dd into main 2024-10-23 10:19:33 +00:00
jank deleted branch feature/get-employees-from-project 2024-10-23 10:22:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jank
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jank/LF8#36
No description provided.
Delete Branch "feature/get-employees-from-project"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?