jank/LF8
2
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 13 Wiki Activity

feat: Implement add employee to project route (SCRUM-2) #32

Merged
jank merged 8 commits from feature/add-employee-to-project into main 2024-10-23 08:39:26 +00:00
Conversation 6 Commits 8 Files Changed 24 +246 -34
ptran commented 2024-10-02 10:32:47 +00:00
Collaborator
Copy Link
No description provided.
ptran added 1 commit 2024-10-02 10:32:48 +00:00
WIP
Some checks failed
Quality Check / Tests (pull_request) Successful in 57s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 46s
Details
Build PR / Build and analyze (pull_request) Successful in 1m56s
Details
gitea-sonarqube-bot ERROR
Details
c5eeabbdff
SonarQube commented 2024-10-02 10:34:47 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Code Smells 1
Vulnerabilities 0
Bugs 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Code Smells | 1 | | Vulnerabilities | 0 | | Bugs | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=32" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
ptran force-pushed feature/add-employee-to-project from c5eeabbdff to 790c2f4bc4 2024-10-02 10:43:12 +00:00 Compare
SonarQube commented 2024-10-02 10:45:10 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Vulnerabilities 0
Bugs 0
Code Smells 1

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Vulnerabilities | 0 | | Bugs | 0 | | Code Smells | 1 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=32" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
ptran added 1 commit 2024-10-23 07:11:07 +00:00
Done
Some checks failed
Build PR / Build and analyze (pull_request) Failing after 1m6s
Details
Quality Check / Tests (pull_request) Failing after 1m52s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 1m28s
Details
9260e96df7
jank requested review from jank 2024-10-23 07:14:55 +00:00
jank reviewed 2024-10-23 07:15:57 +00:00
requests/employee/createEmployee.http Outdated
@ -0,0 +8,4 @@
"street": "yomom",
"postcode": "yomom",
"city": "yomom",
"phone": "yomom"
jank commented 2024-10-23 07:15:57 +00:00
Owner
Copy Link

@ptran Dont use yomom as test user

@ptran Dont use yomom as test user
jank marked this conversation as resolved
jank changed title from feat: Implement add employee to project route (SCRUM-2) to WIP: feat: Implement add employee to project route (SCRUM-2) 2024-10-23 07:33:41 +00:00
ptran was assigned by jank 2024-10-23 07:33:51 +00:00
ptran added 1 commit 2024-10-23 08:09:37 +00:00
Fix tests
Some checks failed
Build PR / Build and analyze (pull_request) Failing after 1m2s
Details
Quality Check / Tests (pull_request) Failing after 1m2s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 24s
Details
36b5d6581d
ptran added 1 commit 2024-10-23 08:13:08 +00:00
Fix tests
Some checks failed
Build PR / Build and analyze (pull_request) Failing after 1m4s
Details
Quality Check / Tests (pull_request) Failing after 1m4s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 23s
Details
09d2b9a3fb
jank requested changes 2024-10-23 08:16:03 +00:00
Dismissed
ptran added 1 commit 2024-10-23 08:16:25 +00:00
Fix tests
Some checks failed
Quality Check / Tests (pull_request) Successful in 1m14s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 39s
Details
Build PR / Build and analyze (pull_request) Failing after 1m10s
Details
gitea-sonarqube-bot OK
Details
d30940326c
SonarQube commented 2024-10-23 08:18:20 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Code Smells 0
Bugs 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Code Smells | 0 | | Bugs | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=32" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
SonarQube commented 2024-10-23 08:22:13 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Bugs 0
Vulnerabilities 0
Code Smells 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Bugs | 0 | | Vulnerabilities | 0 | | Code Smells | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=32" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
ptran added 1 commit 2024-10-23 08:23:01 +00:00
alter
All checks were successful
Quality Check / Tests (pull_request) Successful in 1m9s
Details
gitea-sonarqube-bot OK
Details
Build PR / Build and analyze (pull_request) Successful in 1m48s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 38s
Details
928920a359
jank changed title from WIP: feat: Implement add employee to project route (SCRUM-2) to feat: Implement add employee to project route (SCRUM-2) 2024-10-23 08:23:49 +00:00
SonarQube commented 2024-10-23 08:24:51 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Bugs 0
Code Smells 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Bugs | 0 | | Code Smells | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=32" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank requested changes 2024-10-23 08:28:56 +00:00
Dismissed
src/test/java/de/szut/lf8_starter/integration/project/AddEmployeeToProjectTest.java
@ -0,0 +37,4 @@
@Test
void addEmployeeToProjectTest() throws Exception {
var project = new ProjectEntity();
jank commented 2024-10-23 08:28:36 +00:00
Owner
Copy Link

dont use var

dont use var
ptran marked this conversation as resolved
src/test/java/de/szut/lf8_starter/integration/project/AddEmployeeToProjectTest.java Outdated
@ -0,0 +54,4 @@
.contentType(MediaType.APPLICATION_JSON))
.andExpect(status().isNoContent());
var updatedProject = projectRepository.findById(1L).get();
jank commented 2024-10-23 08:28:45 +00:00
Owner
Copy Link

also here

also here
ptran marked this conversation as resolved
src/test/java/de/szut/lf8_starter/integration/project/AddEmployeeToProjectTest.java Outdated
@ -0,0 +73,4 @@
HttpEntity<MultiValueMap<String, String>> request = new HttpEntity<>(map, headers);
var response = this.restTemplate.exchange(url, HttpMethod.POST, request, Map.class);
jank commented 2024-10-23 08:28:55 +00:00
Owner
Copy Link

and here

and here
ptran marked this conversation as resolved
ptran added 1 commit 2024-10-23 08:34:24 +00:00
Remove var
Some checks failed
Quality Check / Tests (pull_request) Failing after 34s
Details
Build PR / Build and analyze (pull_request) Failing after 39s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 24s
Details
cda04fa8a2
ptran added 1 commit 2024-10-23 08:37:05 +00:00
Fix
All checks were successful
Quality Check / Tests (pull_request) Successful in 1m8s
Details
Build PR / Build and analyze (pull_request) Successful in 1m47s
Details
gitea-sonarqube-bot OK
Details
Quality Check / Checkstyle Main (pull_request) Successful in 37s
Details
fa607435cf
SonarQube commented 2024-10-23 08:38:55 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Code Smells 0
Bugs 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Code Smells | 0 | | Bugs | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=32" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank approved these changes 2024-10-23 08:39:18 +00:00
jank merged commit 1008278fde into main 2024-10-23 08:39:26 +00:00
jank deleted branch feature/add-employee-to-project 2024-10-23 08:39:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jank
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
ptran
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jank/LF8#32
No description provided.
Delete Branch "feature/add-employee-to-project"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?