jank/LF8
2
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 13 Wiki Activity

refactor: Fix yellow code smells #27

Merged
jank merged 11 commits from refactor/fix-yellow-code-smells into main 2024-10-02 08:43:02 +00:00
Conversation 9 Commits 11 Files Changed 5 +41 -57
jank commented 2024-10-02 07:59:27 +00:00
Owner
Copy Link
No description provided.
jank added 3 commits 2024-10-02 07:59:27 +00:00
docs(OpenAPIConfiguration): update authentication description format
Some checks failed
Quality Check / Tests (pull_request) Failing after 36s
Details
Build PR / Build and analyze (pull_request) Failing after 42s
Details
Quality Check / Checkstyle Main (pull_request) Failing after 27s
Details
e237e5741e
jank added 1 commit 2024-10-02 08:01:49 +00:00
build: update dependencies versions in build.gradle.kts
Some checks failed
gitea-sonarqube-bot ERROR
Details
Build PR / Build and analyze (pull_request) Successful in 1m26s
Details
Quality Check / Tests (pull_request) Successful in 56s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 32s
Details
80438dc6c1
SonarQube commented 2024-10-02 08:03:16 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Vulnerabilities 0
Code Smells 1
Bugs 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Vulnerabilities | 0 | | Code Smells | 1 | | Bugs | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank added 1 commit 2024-10-02 08:07:14 +00:00
build: Update springDocVersion variable in build.gradle.kts
All checks were successful
Quality Check / Tests (pull_request) Successful in 1m20s
Details
gitea-sonarqube-bot OK
Details
Build PR / Build and analyze (pull_request) Successful in 1m52s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 41s
Details
db5c629080
SonarQube commented 2024-10-02 08:09:08 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Code Smells 0
Bugs 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Code Smells | 0 | | Bugs | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank added 1 commit 2024-10-02 08:11:30 +00:00
build: Update OAuth2 version in build.gradle.kts
All checks were successful
Quality Check / Tests (pull_request) Successful in 1m20s
Details
gitea-sonarqube-bot OK
Details
Build PR / Build and analyze (pull_request) Successful in 1m51s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 40s
Details
2268c37761
SonarQube commented 2024-10-02 08:13:22 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Code Smells 0
Vulnerabilities 0
Bugs 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Code Smells | 0 | | Vulnerabilities | 0 | | Bugs | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank added 1 commit 2024-10-02 08:14:49 +00:00
refactor(HelloController): simplify collection conversion to list
Some checks failed
Quality Check / Tests (pull_request) Successful in 58s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 43s
Details
Build PR / Build and analyze (pull_request) Successful in 1m53s
Details
gitea-sonarqube-bot ERROR
Details
b586d4e312
SonarQube commented 2024-10-02 08:16:45 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Code Smells 0
Vulnerabilities 0
Bugs 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Code Smells | 0 | | Vulnerabilities | 0 | | Bugs | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank added 1 commit 2024-10-02 08:20:02 +00:00
refactor(HelloController): simplify collection conversion
Some checks failed
Quality Check / Tests (pull_request) Successful in 58s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 43s
Details
Build PR / Build and analyze (pull_request) Successful in 1m52s
Details
gitea-sonarqube-bot ERROR
Details
5e7e8cd354
SonarQube commented 2024-10-02 08:21:58 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Code Smells 0
Vulnerabilities 0
Bugs 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Code Smells | 0 | | Vulnerabilities | 0 | | Bugs | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank added 1 commit 2024-10-02 08:23:50 +00:00
refactor(security): simplify logout method parameters
Some checks failed
Quality Check / Tests (pull_request) Successful in 1m3s
Details
Build PR / Build and analyze (pull_request) Successful in 1m59s
Details
gitea-sonarqube-bot ERROR
Details
Quality Check / Checkstyle Main (pull_request) Successful in 46s
Details
37ab14d33e
SonarQube commented 2024-10-02 08:26:43 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Vulnerabilities 0
Bugs 0
Code Smells 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Vulnerabilities | 0 | | Bugs | 0 | | Code Smells | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank added 1 commit 2024-10-02 08:29:23 +00:00
refactor(security): remove unused KeycloakLogoutHandler dependency
Some checks failed
Quality Check / Tests (pull_request) Successful in 58s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 47s
Details
gitea-sonarqube-bot ERROR
Details
Build PR / Build and analyze (pull_request) Successful in 1m57s
Details
21dd134dd6
SonarQube commented 2024-10-02 08:31:21 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Vulnerabilities 0
Code Smells 0
Bugs 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Vulnerabilities | 0 | | Code Smells | 0 | | Bugs | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank added 1 commit 2024-10-02 08:33:32 +00:00
refactor(HelloController): remove unused methods and comments
All checks were successful
Quality Check / Tests (pull_request) Successful in 58s
Details
Quality Check / Checkstyle Main (pull_request) Successful in 45s
Details
Build PR / Build and analyze (pull_request) Successful in 1m20s
Details
gitea-sonarqube-bot OK
Details
981f63b247
SonarQube commented 2024-10-02 08:35:30 +00:00
Owner
Copy Link

Quality Gate: ❌

Metric Current
Vulnerabilities 0
Bugs 0
Code Smells 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Vulnerabilities | 0 | | Bugs | 0 | | Code Smells | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
SonarQube commented 2024-10-02 08:40:08 +00:00
Owner
Copy Link

Quality Gate: ✅

Metric Current
Bugs 0
Code Smells 0
Vulnerabilities 0

See SonarQube for details.

  • If you want the bot to check again, post /sq-bot review
**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Bugs | 0 | | Code Smells | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=27" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`
jank changed title from WIP: refactor: Fix yellow code smells to refactor: Fix yellow code smells 2024-10-02 08:41:34 +00:00
ptran approved these changes 2024-10-02 08:42:53 +00:00
ptran left a comment
Collaborator
Copy Link

LBTM!

LBTM!
jank merged commit cbb77cc1ca into main 2024-10-02 08:43:02 +00:00
jank deleted branch refactor/fix-yellow-code-smells 2024-10-02 08:43:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ptran
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jank/LF8#27
No description provided.
Delete Branch "refactor/fix-yellow-code-smells"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?