refactor: Fix some code smells #26

Merged

jank merged 6 commits from refactor/fix-smells into main 2024-10-02 07:48:33 +00:00

Conversation 6 Commits 6 Files Changed 3 +8 -10

jank commented 2024-10-02 07:07:26 +00:00

Owner

Copy Link

No description provided.

SonarQube commented 2024-10-02 07:09:20 +00:00

Owner

Copy Link

Quality Gate: ✅

Metric	Current
Bugs	0
Code Smells	0
Vulnerabilities	0

See SonarQube for details.

---

• If you want the bot to check again, post /sq-bot review

**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Bugs | 0 | | Code Smells | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=26" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`

jank added 1 commit 2024-10-02 07:09:34 +00:00

refactor: change response entity type in exception handler 61d72684c9

SonarQube commented 2024-10-02 07:11:30 +00:00

Owner

Copy Link

Quality Gate: ✅

Metric	Current
Vulnerabilities	0
Bugs	0
Code Smells	0

See SonarQube for details.

---

• If you want the bot to check again, post /sq-bot review

**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Vulnerabilities | 0 | | Bugs | 0 | | Code Smells | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=26" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`

jank added 1 commit 2024-10-02 07:30:28 +00:00

refactor(security): replace string literal with constant key 8e7b0770de

jank changed title from WIP: refactor: Fix code smells to WIP: refactor: Fix some code smells 2024-10-02 07:30:47 +00:00

SonarQube commented 2024-10-02 07:32:26 +00:00

Owner

Copy Link

Quality Gate: ✅

Metric	Current
Bugs	0
Code Smells	0
Vulnerabilities	0

See SonarQube for details.

---

• If you want the bot to check again, post /sq-bot review

**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Bugs | 0 | | Code Smells | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=26" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`

jank added 2 commits 2024-10-02 07:35:19 +00:00

fix(security): update roles claim for granted authorities 993387fa0c

refactor(welcome): update getRoles method signature 9824fbbbfd

SonarQube commented 2024-10-02 07:37:17 +00:00

Owner

Copy Link

Quality Gate: ❌

Metric	Current
Code Smells	1
Bugs	0
Vulnerabilities	0

See SonarQube for details.

---

• If you want the bot to check again, post /sq-bot review

**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Code Smells | 1 | | Bugs | 0 | | Vulnerabilities | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=26" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`

jank added 1 commit 2024-10-02 07:39:52 +00:00

refactor(welcome): remove generic type from getRoles method e5d0bcb84e

SonarQube commented 2024-10-02 07:41:48 +00:00

Owner

Copy Link

Quality Gate: ❌

Metric	Current
Vulnerabilities	0
Code Smells	3
Bugs	0

See SonarQube for details.

---

• If you want the bot to check again, post /sq-bot review

**Quality Gate**: :x: | Metric | Current | | -------- | -------- | | Vulnerabilities | 0 | | Code Smells | 3 | | Bugs | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=26" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`

jank added 1 commit 2024-10-02 07:45:14 +00:00

style: Remove unnecessary blank lines and improve type safety 54a76de08c

SonarQube commented 2024-10-02 07:47:11 +00:00

Owner

Copy Link

Quality Gate: ✅

Metric	Current
Bugs	0
Vulnerabilities	0
Code Smells	0

See SonarQube for details.

---

• If you want the bot to check again, post /sq-bot review

**Quality Gate**: :white_check_mark: | Metric | Current | | -------- | -------- | | Bugs | 0 | | Vulnerabilities | 0 | | Code Smells | 0 | See <a href="https://sonarqube.kjan.de/dashboard?id=LF8&pullRequest=26" target="_blank" rel="nofollow">SonarQube</a> for details. --- - If you want the bot to check again, post `/sq-bot review`

jank changed title from WIP: refactor: Fix some code smells to refactor: Fix some code smells 2024-10-02 07:47:43 +00:00

ptran approved these changes 2024-10-02 07:48:21 +00:00

ptran left a comment

Collaborator

Copy Link

LGTM!

LGTM!

jank merged commit a04a180712 into main 2024-10-02 07:48:33 +00:00

jank referenced this issue from a commit 2024-10-02 07:48:33 +00:00

refactor: Fix some code smells (!26)

jank deleted branch refactor/fix-smells 2024-10-02 07:48:33 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

ptran

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jank/LF8#26

No description provided.