SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

chore: Remove old docs and fix pipeline #314

Merged
jank merged 1 commit from docs/ci into main 2025-06-12 07:25:27 +00:00
Conversation 5 Commits 1 Files changed 2 +5 -1355
jank commented 2025-06-12 06:30:39 +00:00
Owner
Copy link
No description provided.
jank added 1 commit 2025-06-12 06:30:40 +00:00
chore: Remove old docs and fix pipeline
Some checks failed
CI / Get Changed Files (pull_request) Successful in 17s
Details
Build docs / build-docs (pull_request) Failing after 17s
Details
Label PRs based on size / Check PR size (pull_request) Successful in 22s
Details
Pull Request Labeler / labeler (pull_request_target) Successful in 11s
Details
CI / eslint (pull_request) Successful in 1m16s
Details
CI / oxlint (pull_request) Successful in 1m15s
Details
CI / prettier (pull_request) Successful in 1m23s
Details
Claude PR Review / claude-code (pull_request) Successful in 2m1s
Details
CI / test-build (pull_request) Successful in 1m48s
Details
CI / Docker frontend validation (pull_request) Successful in 21s
Details
CI / Docker backend validation (pull_request) Successful in 1m6s
Details
CI / Backend Tests (pull_request) Successful in 3m27s
Details
CI / Checkstyle Main (pull_request) Successful in 4m36s
Details
CI / Playwright (pull_request) Failing after 5m50s
Details
088528e50c
forgejo-actions commented 2025-06-12 06:31:35 +00:00
Copy link

👮‍♀️⚠️ This is a friendly reminder that the diff size of this PR is bigger than 200 lines we aim for. Please consider splitting this PR into more digestible pieces!

👮‍♀️⚠️ This is a friendly reminder that the diff size of this PR is bigger than 200 lines we aim for. Please consider splitting this PR into more digestible pieces!
forgejo-actions added the
size
large
 label 2025-06-12 06:31:35 +00:00
jank force-pushed docs/ci from 088528e50c to d9309cb735 2025-06-12 06:31:47 +00:00 Compare
forgejo-actions added the
ci
docs
 labels 2025-06-12 06:31:48 +00:00
Claude commented 2025-06-12 06:32:37 +00:00
Collaborator
Copy link

✅ LGTM - Good cleanup and workflow fix

This PR correctly addresses the documentation structure inconsistency:

Changes Reviewed:

  • ✅ : Properly updated paths from to
  • ✅ : Good addition of trigger for PR validation
  • ✅ : Artifact path correctly updated to match new structure
  • ✅ Removal of old : Clean removal of duplicate/outdated file

Verification:

  • Confirmed exists in the correct location
  • All path references in the workflow are now consistent
  • No breaking changes to existing functionality

The changes are minimal, focused, and improve the project's organization by consolidating documentation in the proper directory.

✅ **LGTM - Good cleanup and workflow fix** This PR correctly addresses the documentation structure inconsistency: **Changes Reviewed:** - ✅ : Properly updated paths from to - ✅ : Good addition of trigger for PR validation - ✅ : Artifact path correctly updated to match new structure - ✅ Removal of old : Clean removal of duplicate/outdated file **Verification:** - Confirmed exists in the correct location - All path references in the workflow are now consistent - No breaking changes to existing functionality The changes are minimal, focused, and improve the project's organization by consolidating documentation in the proper directory.
jleibl approved these changes 2025-06-12 06:32:48 +00:00
Dismissed
jleibl scheduled this pull request to auto merge when all checks succeed 2025-06-12 06:32:50 +00:00
Claude commented 2025-06-12 06:37:27 +00:00
Collaborator
Copy link

Code Review for PR #314: 'chore: Remove old docs and fix pipeline'

Overall Assessment: The changes look good and accomplish the stated goal of cleaning up documentation structure and fixing the build pipeline.

✅ Positive Changes:

  1. Workflow improvements (): Adding trigger will enable documentation builds on PRs, which is excellent for catching build issues early.

  2. Consistent naming (): The directory and file name changes ( → , → ) appear to align with the actual file structure.

  3. Artifact path update (): The artifact path correctly reflects the new structure.

⚠️ Minor Concerns:

  1. LaTeX compiler change (): Removing the flag might cause issues if the document requires XeLaTeX-specific features (Unicode, advanced fonts, etc.). Please verify that the document compiles correctly with .

  2. Large file removal: While cleaning up is good, the removed 1351-line TeX file contained substantial documentation. Ensure this content has been properly migrated to the new location or is no longer needed.

📝 Recommendations:

  • Test the workflow with the new LaTeX compiler settings to ensure successful builds
  • Consider adding a comment in the workflow file explaining why XeLaTeX was removed if it was intentional

Verdict: The changes are well-structured and improve the project organization. The workflow enhancements are particularly valuable.

## Code Review for PR #314: 'chore: Remove old docs and fix pipeline' **Overall Assessment:** The changes look good and accomplish the stated goal of cleaning up documentation structure and fixing the build pipeline. ### ✅ **Positive Changes:** 1. **Workflow improvements** (): Adding trigger will enable documentation builds on PRs, which is excellent for catching build issues early. 2. **Consistent naming** (): The directory and file name changes ( → , → ) appear to align with the actual file structure. 3. **Artifact path update** (): The artifact path correctly reflects the new structure. ### ⚠️ **Minor Concerns:** 1. **LaTeX compiler change** (): Removing the flag might cause issues if the document requires XeLaTeX-specific features (Unicode, advanced fonts, etc.). Please verify that the document compiles correctly with . 2. **Large file removal**: While cleaning up is good, the removed 1351-line TeX file contained substantial documentation. Ensure this content has been properly migrated to the new location or is no longer needed. ### 📝 **Recommendations:** - Test the workflow with the new LaTeX compiler settings to ensure successful builds - Consider adding a comment in the workflow file explaining why XeLaTeX was removed if it was intentional **Verdict:** The changes are well-structured and improve the project organization. The workflow enhancements are particularly valuable.
jank scheduled this pull request to auto merge when all checks succeed 2025-06-12 06:37:54 +00:00
jleibl approved these changes 2025-06-12 06:38:34 +00:00
jleibl scheduled this pull request to auto merge when all checks succeed 2025-06-12 06:38:36 +00:00
jank merged commit ab6265b2cd into main 2025-06-12 07:25:27 +00:00
jank deleted branch docs/ci 2025-06-12 07:25:27 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
jleibl
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#314
No description provided.
Delete branch "docs/ci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?