SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

docs: replace logos with hitec logo #302

Merged
ptran merged 2 commits from logo into main 2025-06-11 10:55:17 +00:00
Conversation 2 Commits 2 Files changed 4 +2 -2
ptran commented 2025-06-11 10:45:58 +00:00
Member
Copy link
No description provided.
ptran added 2 commits 2025-06-11 10:45:58 +00:00
docs: add logo to deckblatt
All checks were successful
Pull Request Labeler / labeler (pull_request_target) Successful in 17s
Details
Label PRs based on size / Check PR size (pull_request) Successful in 30s
Details
CI / Get Changed Files (pull_request) Successful in 34s
Details
CI / eslint (pull_request) Has been skipped
Details
CI / oxlint (pull_request) Has been skipped
Details
CI / Playwright (pull_request) Has been skipped
Details
Claude PR Review / claude-code (pull_request) Successful in 1m47s
Details
CI / Backend Tests (pull_request) Has been skipped
Details
CI / Checkstyle Main (pull_request) Has been skipped
Details
CI / prettier (pull_request) Has been skipped
Details
CI / Docker frontend validation (pull_request) Has been skipped
Details
CI / test-build (pull_request) Has been skipped
Details
CI / Docker backend validation (pull_request) Has been skipped
Details
922c95c212
forgejo-actions added the
size
small
 label 2025-06-11 10:46:32 +00:00
Claude commented 2025-06-11 10:47:39 +00:00
Collaborator
Copy link

Code Review - APPROVE

The changes look good overall. This PR successfully replaces the old logos with the new hitec-logo.png file across the documentation.

Positive aspects:

  • Clean, focused change that updates logo references consistently
  • Proper file placement in the Bilder directory
  • Clear commit messages
  • Both Deckblatt.tex:5 and Meta.tex:10 are updated correctly

Minor considerations:

  • projektdokumentation/Deckblatt.tex:5 & Meta.tex:10: Switched from PDF to PNG format - while this works, PDF/vector formats typically provide better print quality for logos
  • The scale=0.25 parameter remains unchanged, which should be fine but may want to verify the logo displays at the intended size

Recommendation: APPROVE - This is a straightforward documentation update that achieves its goal. The technical implementation is correct.

**Code Review - APPROVE** The changes look good overall. This PR successfully replaces the old logos with the new hitec-logo.png file across the documentation. **Positive aspects:** - Clean, focused change that updates logo references consistently - Proper file placement in the Bilder directory - Clear commit messages - Both Deckblatt.tex:5 and Meta.tex:10 are updated correctly **Minor considerations:** - projektdokumentation/Deckblatt.tex:5 & Meta.tex:10: Switched from PDF to PNG format - while this works, PDF/vector formats typically provide better print quality for logos - The scale=0.25 parameter remains unchanged, which should be fine but may want to verify the logo displays at the intended size **Recommendation:** APPROVE - This is a straightforward documentation update that achieves its goal. The technical implementation is correct.
csimonis approved these changes 2025-06-11 10:55:10 +00:00
ptran scheduled this pull request to auto merge when all checks succeed 2025-06-11 10:55:12 +00:00
ptran merged commit e5155c072f into main 2025-06-11 10:55:17 +00:00
ptran deleted branch logo 2025-06-11 10:55:17 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
csimonis
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#302
No description provided.
Delete branch "logo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?