SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

fix: adjust inconsistencies in the frontend #282

Merged
ptran merged 3 commits from frontend-fixes into main 2025-06-04 09:04:18 +00:00
Conversation 7 Commits 3 Files changed 3 +16 -29
ptran commented 2025-06-04 08:29:38 +00:00
Member
Copy link
No description provided.
ptran added 1 commit 2025-06-04 08:29:39 +00:00
fix: adjust inconsistencies in the frontend
Some checks failed
CI / Get Changed Files (pull_request) Successful in 8s
Details
CI / Backend Tests (pull_request) Has been skipped
Details
CI / Checkstyle Main (pull_request) Has been skipped
Details
Pull Request Labeler / labeler (pull_request_target) Successful in 8s
Details
CI / Docker backend validation (pull_request) Has been skipped
Details
Label PRs based on size / Check PR size (pull_request) Successful in 14s
Details
CI / oxlint (pull_request) Failing after 26s
Details
CI / prettier (pull_request) Failing after 35s
Details
CI / eslint (pull_request) Failing after 39s
Details
CI / Docker frontend validation (pull_request) Successful in 49s
Details
CI / test-build (pull_request) Successful in 57s
Details
Claude PR Review / claude-code (pull_request) Successful in 1m13s
Details
bd031e8658
forgejo-actions added the
frontend
size
small
 labels 2025-06-04 08:29:54 +00:00
csimonis approved these changes 2025-06-04 08:30:34 +00:00
Dismissed
ptran added 1 commit 2025-06-04 08:30:40 +00:00
fix: remove apple icon import
Some checks failed
CI / Get Changed Files (pull_request) Successful in 10s
Details
Label PRs based on size / Check PR size (pull_request) Successful in 13s
Details
CI / Backend Tests (pull_request) Has been skipped
Details
Pull Request Labeler / labeler (pull_request_target) Successful in 7s
Details
CI / Checkstyle Main (pull_request) Has been skipped
Details
CI / Docker backend validation (pull_request) Has been skipped
Details
CI / oxlint (pull_request) Successful in 30s
Details
CI / eslint (pull_request) Successful in 39s
Details
CI / prettier (pull_request) Failing after 35s
Details
CI / Docker frontend validation (pull_request) Successful in 44s
Details
CI / test-build (pull_request) Successful in 49s
Details
Claude PR Review / claude-code (pull_request) Successful in 1m14s
Details
a4e12272e5
ptran dismissed csimonis's review 2025-06-04 08:30:40 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jank approved these changes 2025-06-04 08:30:41 +00:00
Dismissed
Claude commented 2025-06-04 08:30:49 +00:00
Collaborator
Copy link

Code Review Summary

The changes improve frontend consistency by updating navigation links and cleaning up UI elements. Most changes are good, but there's one issue to address:

Issues:

    • Missing leading slash in route. Change to for consistency with other routes.

Positive changes:

  • Updated footer links to use proper game routes (, , etc.)
  • Replaced non-existent "Poker" game with "Coinflip"
  • Added responsive design with class
  • Cleaned up UI by removing disclaimer text and unused Apple Pay references
  • Properly added RouterLink import in footer component

Please fix the routing inconsistency and this will be ready to merge.

**Code Review Summary** The changes improve frontend consistency by updating navigation links and cleaning up UI elements. Most changes are good, but there's one issue to address: **Issues:** - - Missing leading slash in route. Change to for consistency with other routes. **Positive changes:** - Updated footer links to use proper game routes (, , etc.) - Replaced non-existent "Poker" game with "Coinflip" - Added responsive design with class - Cleaned up UI by removing disclaimer text and unused Apple Pay references - Properly added RouterLink import in footer component Please fix the routing inconsistency and this will be ready to merge.
Claude commented 2025-06-04 08:31:53 +00:00
Collaborator
Copy link

Code Review - Approve with Minor Suggestions

The changes successfully address frontend inconsistencies and improve navigation. Good work on:

✅ Fixed routing: Updated footer links from generic to specific game routes
✅ Cleanup: Removed unused Apple Pay references and misleading disclaimers
✅ Improved accuracy: Removed non-existent features

Minor issues to consider:

  1. Inconsistent route format in : Uses (no leading slash) while footer uses - should be consistent

  2. Content mismatch in : Coinflip card links to blackjack route instead of coinflip route

  3. Import cleanup completed in : Good follow-up removing the unused faApplePay import

Overall the changes improve user experience by fixing broken links and removing confusing elements. The minor routing inconsistencies can be addressed in a follow-up if needed.

## Code Review - Approve with Minor Suggestions The changes successfully address frontend inconsistencies and improve navigation. Good work on: ✅ **Fixed routing**: Updated footer links from generic to specific game routes ✅ **Cleanup**: Removed unused Apple Pay references and misleading disclaimers ✅ **Improved accuracy**: Removed non-existent features **Minor issues to consider:** 1. **Inconsistent route format** in : Uses (no leading slash) while footer uses - should be consistent 2. **Content mismatch** in : Coinflip card links to blackjack route instead of coinflip route 3. **Import cleanup completed** in : Good follow-up removing the unused faApplePay import Overall the changes improve user experience by fixing broken links and removing confusing elements. The minor routing inconsistencies can be addressed in a follow-up if needed.
jank approved these changes 2025-06-04 08:33:18 +00:00
Dismissed
ptran scheduled this pull request to auto merge when all checks succeed 2025-06-04 08:33:27 +00:00
ptran scheduled this pull request to auto merge when all checks succeed 2025-06-04 08:50:56 +00:00
ptran added 1 commit 2025-06-04 08:52:19 +00:00
style: die of cancer prettier
All checks were successful
CI / Get Changed Files (pull_request) Successful in 8s
Details
CI / Backend Tests (pull_request) Has been skipped
Details
CI / Checkstyle Main (pull_request) Has been skipped
Details
Pull Request Labeler / labeler (pull_request_target) Successful in 7s
Details
CI / Docker backend validation (pull_request) Has been skipped
Details
Label PRs based on size / Check PR size (pull_request) Successful in 14s
Details
CI / oxlint (pull_request) Successful in 24s
Details
CI / prettier (pull_request) Successful in 29s
Details
CI / eslint (pull_request) Successful in 34s
Details
CI / Docker frontend validation (pull_request) Successful in 41s
Details
CI / test-build (pull_request) Successful in 46s
Details
Claude PR Review / claude-code (pull_request) Successful in 1m11s
Details
d388f2a786
ptran dismissed jank's review 2025-06-04 08:52:19 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Claude commented 2025-06-04 08:53:29 +00:00
Collaborator
Copy link

Code Review Findings

✅ Positive Changes:

  • Removes unimplemented Apple Pay references
  • Updates footer links to actual game routes
  • Removes confusing support disclaimer
  • Consolidates footer layout

❌ Issues Found:

  1. Critical: Wrong routing in landing.component.html:73 - The Coinflip card has but should be to match the game title and description.

  2. Inconsistency: landing.component.html:73 - Uses relative path while footer uses absolute paths . Should be consistent (prefer absolute paths).

  3. Unclear: landing.component.html:67 - Adding to Coinflip card hides it on mobile without clear justification.

Recommendation: Fix the routing issue in line 73 and consider making routing paths consistent across components.

**Code Review Findings** ✅ **Positive Changes:** - Removes unimplemented Apple Pay references - Updates footer links to actual game routes - Removes confusing support disclaimer - Consolidates footer layout ❌ **Issues Found:** 1. **Critical: Wrong routing in landing.component.html:73** - The Coinflip card has but should be to match the game title and description. 2. **Inconsistency: landing.component.html:73** - Uses relative path while footer uses absolute paths . Should be consistent (prefer absolute paths). 3. **Unclear: landing.component.html:67** - Adding to Coinflip card hides it on mobile without clear justification. **Recommendation:** Fix the routing issue in line 73 and consider making routing paths consistent across components.
jank approved these changes 2025-06-04 09:04:15 +00:00
ptran merged commit 551f5bcf2e into main 2025-06-04 09:04:18 +00:00
ptran deleted branch frontend-fixes 2025-06-04 09:04:18 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
jank
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#282
No description provided.
Delete branch "frontend-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?