SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

fix: lootbox routing #281

Merged
ptran merged 1 commit from fix-lootbox-routing into main 2025-06-04 08:14:23 +00:00
Conversation 2 Commits 1 Files changed 1 +6 -8
ptran commented 2025-06-04 08:12:22 +00:00
Member
Copy link
No description provided.
fix: lootbox routing
All checks were successful
CI / Get Changed Files (pull_request) Successful in 8s
Details
CI / Backend Tests (pull_request) Has been skipped
Details
CI / Checkstyle Main (pull_request) Has been skipped
Details
Pull Request Labeler / labeler (pull_request_target) Successful in 8s
Details
CI / Docker backend validation (pull_request) Has been skipped
Details
Label PRs based on size / Check PR size (pull_request) Successful in 12s
Details
CI / eslint (pull_request) Successful in 29s
Details
CI / oxlint (pull_request) Successful in 39s
Details
CI / prettier (pull_request) Successful in 37s
Details
CI / test-build (pull_request) Successful in 46s
Details
CI / Docker frontend validation (pull_request) Successful in 51s
Details
Claude PR Review / claude-code (pull_request) Successful in 1m9s
Details
75508d9ebb
Claude commented 2025-06-04 08:13:30 +00:00
Collaborator
Copy link

Code Review

✅ Frontend Changes Look Good

The routing fix in is correct and properly addresses the lootbox navigation issue by moving the opening route from a child route to a sibling route.

⚠️ Backend Changes Are Concerning

The dependency downgrades in raise security concerns:

Lines 50-52: Downgrading Spring Boot OAuth2 from 3.5.0 to 3.4.5 - why are we moving backwards on security dependencies?

Lines 54-56: Downgrading JJWT from 0.12.6 to 0.11.5 requires the API change in , but this is a significant downgrade that may reintroduce security vulnerabilities.

Line 42: Downgrading Stripe from 29.2.0 to 29.1.0 - this seems unnecessary.

Questions:

  1. What specific issue required these dependency downgrades?
  2. Have you verified that the older versions don't have known security vulnerabilities?
  3. Is there a specific compatibility issue that prevents using the newer versions?

The routing fix is good, but the backend changes need justification before approval.

## Code Review ### ✅ Frontend Changes Look Good The routing fix in is correct and properly addresses the lootbox navigation issue by moving the opening route from a child route to a sibling route. ### ⚠️ Backend Changes Are Concerning The dependency downgrades in raise security concerns: **Lines 50-52**: Downgrading Spring Boot OAuth2 from 3.5.0 to 3.4.5 - why are we moving backwards on security dependencies? **Lines 54-56**: Downgrading JJWT from 0.12.6 to 0.11.5 requires the API change in , but this is a significant downgrade that may reintroduce security vulnerabilities. **Line 42**: Downgrading Stripe from 29.2.0 to 29.1.0 - this seems unnecessary. ### Questions: 1. What specific issue required these dependency downgrades? 2. Have you verified that the older versions don't have known security vulnerabilities? 3. Is there a specific compatibility issue that prevents using the newer versions? The routing fix is good, but the backend changes need justification before approval.
jank approved these changes 2025-06-04 08:14:09 +00:00
ptran merged commit 9a7049d6ab into main 2025-06-04 08:14:23 +00:00
ptran deleted branch fix-lootbox-routing 2025-06-04 08:14:23 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
jank
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#281
No description provided.
Delete branch "fix-lootbox-routing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?