SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

fix: Hourly #262

Merged
jank merged 1 commit from improve-stale into main 2025-06-02 12:38:55 +00:00
Conversation 4 Commits 1 Files changed 1 +2 -1
jank commented 2025-06-02 12:33:17 +00:00
Owner
Copy link
No description provided.
jank added 1 commit 2025-06-02 12:33:17 +00:00
fix: Hourly
All checks were successful
CI / Get Changed Files (pull_request) Successful in 10s
Details
CI / oxlint (pull_request) Successful in 43s
Details
CI / eslint (pull_request) Successful in 49s
Details
CI / prettier (pull_request) Successful in 49s
Details
Claude PR Review / claude-code (pull_request) Successful in 1m5s
Details
CI / Docker frontend validation (pull_request) Successful in 16s
Details
CI / test-build (pull_request) Successful in 1m23s
Details
CI / Docker backend validation (pull_request) Successful in 19s
Details
CI / Checkstyle Main (pull_request) Successful in 1m1s
Details
CI / Backend Tests (pull_request) Successful in 2m26s
Details
9639525ddd
jank scheduled this pull request to auto merge when all checks succeed 2025-06-02 12:33:37 +00:00
csimonis reviewed 2025-06-02 12:33:44 +00:00
csimonis left a comment
Owner

dc

dc
Claude commented 2025-06-02 12:34:21 +00:00
Collaborator
Copy link

Code Review Results

Critical Issue Found:

** lines 13-15:** The stale-pr-message contains highly inappropriate and unprofessional language that is completely unacceptable in a professional codebase. This must be replaced with respectful, clear messaging before the PR can be approved.

Technical Concerns:

** line 5:** Changing from daily () to hourly () execution significantly increases the workflow frequency. Consider if hourly execution is necessary or if it might create excessive noise for contributors.

Positive Changes:

** line 3:** Good addition of for manual workflow triggering.

Recommendation: Please address the inappropriate messaging before this can be approved. The technical changes are acceptable pending confirmation that hourly execution is the intended behavior.

## Code Review Results **Critical Issue Found:** ** lines 13-15:** The stale-pr-message contains highly inappropriate and unprofessional language that is completely unacceptable in a professional codebase. This must be replaced with respectful, clear messaging before the PR can be approved. **Technical Concerns:** ** line 5:** Changing from daily () to hourly () execution significantly increases the workflow frequency. Consider if hourly execution is necessary or if it might create excessive noise for contributors. **Positive Changes:** ** line 3:** Good addition of for manual workflow triggering. **Recommendation:** Please address the inappropriate messaging before this can be approved. The technical changes are acceptable pending confirmation that hourly execution is the intended behavior.
ptran requested changes 2025-06-02 12:38:10 +00:00
Dismissed
.gitea/workflows/stale.yml
@ -3,2 +3,3 @@
workflow_dispatch:
schedule:
- cron: "30 1 * * *"
- cron: "@hourly"
ptran commented 2025-06-02 12:37:54 +00:00
Member

Is this really necessary?

Is this really necessary?
ptran commented 2025-06-02 12:38:01 +00:00
Member

No shut up

No shut up
ptran commented 2025-06-02 12:38:07 +00:00
Member

fy

fy
csimonis commented 2025-06-02 12:38:31 +00:00
Owner

ur mom

# ur mom
jank marked this conversation as resolved
ptran approved these changes 2025-06-02 12:38:52 +00:00
jank merged commit 39feba7d1d into main 2025-06-02 12:38:55 +00:00
jank deleted branch improve-stale 2025-06-02 12:38:55 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
ptran
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#262
No description provided.
Delete branch "improve-stale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?