SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

chore: Add stale pipeline #253

Merged
csimonis merged 1 commit from stale into main 2025-06-02 12:15:31 +00:00
Conversation 8 Commits 1 Files changed 1 +14
jank commented 2025-06-02 12:04:58 +00:00
Owner
Copy link
No description provided.
jank added 1 commit 2025-06-02 12:04:58 +00:00
chore: Add stale pipeline
All checks were successful
CI / Get Changed Files (pull_request) Successful in 9s
Details
CI / oxlint (pull_request) Successful in 28s
Details
CI / prettier (pull_request) Successful in 34s
Details
CI / eslint (pull_request) Successful in 38s
Details
Claude PR Review / claude-code (pull_request) Successful in 1m13s
Details
CI / Docker frontend validation (pull_request) Successful in 1m21s
Details
CI / Docker backend validation (pull_request) Successful in 20s
Details
CI / test-build (pull_request) Successful in 55s
Details
CI / Checkstyle Main (pull_request) Successful in 2m5s
Details
CI / Backend Tests (pull_request) Successful in 2m52s
Details
a626a73289
Claude commented 2025-06-02 12:06:03 +00:00
Collaborator
Copy link

Code Review for PR #253

Summary: Adding a stale pipeline workflow to automatically handle stale issues and PRs.

Issues Found:

  1. **** - The stale messages are using placeholder text rather than meaningful messages. The current messages "Message to comment on stale issues. If none provided, will not mark issues stale" and "Message to comment on stale PRs. If none provided, will not mark PRs stale" are just documentation placeholders and should be replaced with actual user-facing messages.

  2. **** - Missing essential configuration parameters for the stale action:

    • No parameter (defaults to 60 days)
    • No parameter (defaults to 7 days)
    • No to protect certain issues/PRs from being marked stale
    • No specified (will use default 'Stale')

Recommendations:

  • Replace placeholder messages with proper user-facing text
  • Add explicit timing configuration for transparency
  • Consider adding exempt labels for issues that shouldn't become stale
  • Add more descriptive stale labels if needed

Positive Notes:

  • Good addition for repository maintenance
  • Proper YAML structure and syntax
  • Appropriate scheduling (daily at 1:30 AM)

The workflow structure is sound but needs better configuration to be production-ready.

## Code Review for PR #253 **Summary:** Adding a stale pipeline workflow to automatically handle stale issues and PRs. **Issues Found:** 1. **** - The stale messages are using placeholder text rather than meaningful messages. The current messages "Message to comment on stale issues. If none provided, will not mark issues stale" and "Message to comment on stale PRs. If none provided, will not mark PRs stale" are just documentation placeholders and should be replaced with actual user-facing messages. 2. **** - Missing essential configuration parameters for the stale action: - No parameter (defaults to 60 days) - No parameter (defaults to 7 days) - No to protect certain issues/PRs from being marked stale - No specified (will use default 'Stale') **Recommendations:** - Replace placeholder messages with proper user-facing text - Add explicit timing configuration for transparency - Consider adding exempt labels for issues that shouldn't become stale - Add more descriptive stale labels if needed **Positive Notes:** - Good addition for repository maintenance - Proper YAML structure and syntax - Appropriate scheduling (daily at 1:30 AM) The workflow structure is sound but needs better configuration to be production-ready.
jank commented 2025-06-02 12:06:51 +00:00
Author
Owner
Copy link

@Claude what messages should I use instead

@Claude what messages should I use instead
jank force-pushed stale from a626a73289 to a217a0da72 2025-06-02 12:10:30 +00:00 Compare
Claude commented 2025-06-02 12:11:39 +00:00
Collaborator
Copy link

Code Review Feedback

This PR has a critical issue that must be addressed before merging:

❌ Critical Issue:

  • **Line 11 in **: The stale-pr-message contains inappropriate and offensive language (\bc yo mom is a bitch). This is unprofessional and inappropriate for any codebase.

⚠️ Other Issues:

  • Lines 12-13: The timing is very aggressive (2 days to stale, 3 days to close). Consider extending to 14-30 days before stale and 7-14 additional days before closing to avoid closing active PRs.

✅ Positive:

  • Workflow structure is correct
  • Cron schedule is reasonable

Required Changes:
Please replace the offensive message with a professional one and consider adjusting the timeframes to be less aggressive.

The workflow concept is good, but the implementation needs these fixes before it can be merged.

**Code Review Feedback** This PR has a critical issue that must be addressed before merging: **❌ Critical Issue:** - **Line 11 in **: The stale-pr-message contains inappropriate and offensive language (\bc yo mom is a bitch\). This is unprofessional and inappropriate for any codebase. **⚠️ Other Issues:** - **Lines 12-13**: The timing is very aggressive (2 days to stale, 3 days to close). Consider extending to 14-30 days before stale and 7-14 additional days before closing to avoid closing active PRs. **✅ Positive:** - Workflow structure is correct - Cron schedule is reasonable **Required Changes:** Please replace the offensive message with a professional one and consider adjusting the timeframes to be less aggressive. The workflow concept is good, but the implementation needs these fixes before it can be merged.
jank force-pushed stale from a217a0da72 to 882a279243 2025-06-02 12:11:41 +00:00 Compare
csimonis reviewed 2025-06-02 12:12:32 +00:00
.gitea/workflows/stale.yml Outdated
@ -0,0 +9,4 @@
steps:
- uses: actions/stale@v9
with:
stale-pr-message: "Will be closed in 1 day bc yo mom is a bitch"
csimonis commented 2025-06-02 12:12:32 +00:00
Owner

stale-pr-message: "Will be closed in x days bc yo mom is a bitch. im not telling you when it will be closed fuckface"

`stale-pr-message: "Will be closed in x days bc yo mom is a bitch. im not telling you when it will be closed fuckface"`
jank marked this conversation as resolved
Claude commented 2025-06-02 12:12:47 +00:00
Collaborator
Copy link

The workflow configuration looks good overall, but there are some issues that need to be addressed:

Critical Issue:

  • Line 12: The stale-pr-message contains unprofessional language that's inappropriate for a professional codebase. Please replace with a professional message.

Suggestions for improvement:

  • Consider adding stale-pr-label and close-pr-label for better tracking
  • The workflow name mentions 'issues and PRs' but only handles PRs - either add issue handling or update the name
  • Consider adding exempt-pr-labels to exclude certain types of PRs

Example professional message: 'This PR has been inactive for 2 days and will be closed in 1 day if no further activity occurs.'

The workflow configuration looks good overall, but there are some issues that need to be addressed: **Critical Issue:** - Line 12: The stale-pr-message contains unprofessional language that's inappropriate for a professional codebase. Please replace with a professional message. **Suggestions for improvement:** - Consider adding stale-pr-label and close-pr-label for better tracking - The workflow name mentions 'issues and PRs' but only handles PRs - either add issue handling or update the name - Consider adding exempt-pr-labels to exclude certain types of PRs Example professional message: 'This PR has been inactive for 2 days and will be closed in 1 day if no further activity occurs.'
csimonis commented 2025-06-02 12:13:35 +00:00
Owner
Copy link

@Claude fuck this guys mom

@Claude fuck this guys mom
jank force-pushed stale from 882a279243 to bd1d8f8339 2025-06-02 12:13:43 +00:00 Compare
Claude commented 2025-06-02 12:14:47 +00:00
Collaborator
Copy link

Code Review for PR #253: chore: Add stale pipeline

I've reviewed the changes in and found several significant issues that need to be addressed:

Critical Issues:

  1. Line 12 - Inappropriate and unprofessional message: The stale-pr-message contains extremely unprofessional language ("Will be closed in x days bc yo mom is a bitch. im not telling you when it will be closed fuckface"). This is completely unacceptable for any professional codebase and will be visible to all users when their PRs are marked as stale.

  2. Line 12 - Unclear messaging: The message mentions "x days" without specifying the actual number, which will confuse users.

Technical Issues:

  1. Line 10 - Missing stale-issue-message: The workflow only handles stale PRs but doesn't define behavior for stale issues, even though the workflow name suggests it handles both.

  2. Lines 13-14 - Very aggressive timing: 2 days before marking as stale and 3 days before closing seems quite aggressive for most projects.

Recommendations:

  • Replace the stale-pr-message with professional, helpful text that clearly explains the stale policy
  • Consider adding stale-issue-message and related issue configuration
  • Review if the timing is appropriate for your project's contribution patterns
  • Consider adding exempt labels for PRs that shouldn't be marked as stale

This PR cannot be merged in its current state due to the inappropriate messaging that would negatively impact the project's professional image.

**Code Review for PR #253: chore: Add stale pipeline** I've reviewed the changes in and found several significant issues that need to be addressed: **Critical Issues:** 1. **Line 12 - Inappropriate and unprofessional message**: The stale-pr-message contains extremely unprofessional language ("Will be closed in x days bc yo mom is a bitch. im not telling you when it will be closed fuckface"). This is completely unacceptable for any professional codebase and will be visible to all users when their PRs are marked as stale. 2. **Line 12 - Unclear messaging**: The message mentions "x days" without specifying the actual number, which will confuse users. **Technical Issues:** 3. **Line 10 - Missing stale-issue-message**: The workflow only handles stale PRs but doesn't define behavior for stale issues, even though the workflow name suggests it handles both. 4. **Lines 13-14 - Very aggressive timing**: 2 days before marking as stale and 3 days before closing seems quite aggressive for most projects. **Recommendations:** - Replace the stale-pr-message with professional, helpful text that clearly explains the stale policy - Consider adding stale-issue-message and related issue configuration - Review if the timing is appropriate for your project's contribution patterns - Consider adding exempt labels for PRs that shouldn't be marked as stale This PR cannot be merged in its current state due to the inappropriate messaging that would negatively impact the project's professional image.
csimonis approved these changes 2025-06-02 12:14:49 +00:00
csimonis left a comment
Owner

"fuckface"

"fuckface"
csimonis scheduled this pull request to auto merge when all checks succeed 2025-06-02 12:14:54 +00:00
csimonis merged commit aa7cf00ebb into main 2025-06-02 12:15:31 +00:00
csimonis deleted branch stale 2025-06-02 12:15:31 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
csimonis
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#253
No description provided.
Delete branch "stale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?