SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

chore: Use claude action #251

Merged
jank merged 1 commit from claude-action into main 2025-06-03 06:06:53 +00:00
Conversation 2 Commits 1 Files changed 1 +4 -65
jank commented 2025-06-02 06:57:52 +00:00
Owner
Copy link
No description provided.
jank added 1 commit 2025-06-02 06:57:53 +00:00
chore: Use action
Some checks failed
Claude PR Review / claude-code (pull_request) Failing after 5s
Details
CI / Get Changed Files (pull_request) Successful in 11s
Details
CI / oxlint (pull_request) Successful in 59s
Details
CI / eslint (pull_request) Successful in 1m1s
Details
CI / prettier (pull_request) Successful in 58s
Details
CI / test-build (pull_request) Successful in 1m7s
Details
CI / Docker frontend validation (pull_request) Successful in 3m59s
Details
CI / Checkstyle Main (pull_request) Successful in 5m48s
Details
CI / Backend Tests (pull_request) Successful in 5m50s
Details
CI / Docker backend validation (pull_request) Successful in 7m11s
Details
c732b0e841
jank force-pushed claude-action from c732b0e841 to 0d076f79ec 2025-06-02 06:58:43 +00:00 Compare
jank changed title from chore: Use action to chore: Use claude action 2025-06-02 06:59:18 +00:00
jank force-pushed claude-action from 0d076f79ec to 65975fe4f8 2025-06-02 07:05:05 +00:00 Compare
Claude commented 2025-06-02 07:06:47 +00:00
Collaborator
Copy link

Code Review Approved ✅

This PR successfully simplifies the Claude workflow by replacing ~70 lines of complex setup with a reusable action.

Positive aspects:

  • Significant improvement in maintainability and readability (.gitea/workflows/claude.yml:11-16)
  • Proper use of external action with version pinning ()
  • Eliminates code duplication across repositories
  • Preserves core functionality while reducing complexity

Minor considerations:

  • External dependency on - ensure this action is reliable and maintained
  • Secret remapping ( → ) - verify the action expects this naming convention
  • Renovate Bot check removal means all PRs will now be reviewed (likely intentional)

Overall, this is a well-executed refactoring that follows CI/CD best practices. The change from a complex manual setup to a clean, maintainable action-based approach is excellent.

**Code Review Approved** ✅ This PR successfully simplifies the Claude workflow by replacing ~70 lines of complex setup with a reusable action. **Positive aspects:** - Significant improvement in maintainability and readability (.gitea/workflows/claude.yml:11-16) - Proper use of external action with version pinning () - Eliminates code duplication across repositories - Preserves core functionality while reducing complexity **Minor considerations:** - External dependency on - ensure this action is reliable and maintained - Secret remapping ( → ) - verify the action expects this naming convention - Renovate Bot check removal means all PRs will now be reviewed (likely intentional) Overall, this is a well-executed refactoring that follows CI/CD best practices. The change from a complex manual setup to a clean, maintainable action-based approach is excellent.
jank scheduled this pull request to auto merge when all checks succeed 2025-06-03 06:02:14 +00:00
jleibl approved these changes 2025-06-03 06:06:50 +00:00
jank merged commit 5d75109dcf into main 2025-06-03 06:06:53 +00:00
jank deleted branch claude-action 2025-06-03 06:06:53 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
jleibl
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#251
No description provided.
Delete branch "claude-action"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?