SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

fix: Fix claude pipeline #247

Merged
jank merged 1 commit from claude/fix into main 2025-06-01 10:20:54 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -2
jank commented 2025-06-01 10:17:20 +00:00
Owner
Copy link
No description provided.
jank added 1 commit 2025-06-01 10:17:21 +00:00
fix: Fix claude pipeline
All checks were successful
CI / Get Changed Files (pull_request) Successful in 8s
Details
CI / eslint (pull_request) Successful in 31s
Details
CI / Docker frontend validation (pull_request) Successful in 29s
Details
CI / oxlint (pull_request) Successful in 36s
Details
CI / prettier (pull_request) Successful in 40s
Details
CI / Docker backend validation (pull_request) Successful in 19s
Details
CI / test-build (pull_request) Successful in 1m9s
Details
Setup Gitea Tea CLI / setup-and-login (pull_request) Successful in 1m27s
Details
CI / Checkstyle Main (pull_request) Successful in 1m19s
Details
CI / Backend Tests (pull_request) Successful in 1m56s
Details
84a4ede026
Claude requested changes 2025-06-01 10:18:44 +00:00
Dismissed
Claude left a comment
Collaborator

Security/Safety Concern: This change removes an important bot loop prevention mechanism from .gitea/workflows/claude-comment.yml (line 12-13). Issues: 1. Infinite loop risk: Removing github.event.sender.type != 'Bot' could cause the workflow to trigger indefinitely if Claude or other bots comment with '@Claude' 2. Resource waste: Bot-generated comments will now unnecessarily consume CI/CD resources 3. Missing context: The commit message doesn't explain why this safety check needed removal Recommendation: Please either provide justification for why bot loop prevention is no longer needed, or implement an alternative safety mechanism to prevent infinite workflows. The original safety check served an important purpose and shouldn't be removed without careful consideration.

**Security/Safety Concern**: This change removes an important bot loop prevention mechanism from .gitea/workflows/claude-comment.yml (line 12-13). **Issues:** 1. **Infinite loop risk**: Removing github.event.sender.type \!= 'Bot' could cause the workflow to trigger indefinitely if Claude or other bots comment with '@Claude' 2. **Resource waste**: Bot-generated comments will now unnecessarily consume CI/CD resources 3. **Missing context**: The commit message doesn't explain why this safety check needed removal **Recommendation**: Please either provide justification for why bot loop prevention is no longer needed, or implement an alternative safety mechanism to prevent infinite workflows. The original safety check served an important purpose and shouldn't be removed without careful consideration.
jank dismissed Claude's review 2025-06-01 10:19:53 +00:00
Reason:

dc

jank merged commit 2b096695a3 into main 2025-06-01 10:20:54 +00:00
jank deleted branch claude/fix 2025-06-01 10:20:54 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#247
No description provided.
Delete branch "claude/fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?