SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

fix: Line numbers #238

Merged
jank merged 1 commit from line-numbers into main 2025-05-28 10:58:13 +00:00
Conversation 2 Commits 1 Files changed 1 +2 -1
jank commented 2025-05-28 10:54:39 +00:00
Owner
Copy link
No description provided.
Claude commented 2025-05-28 10:56:13 +00:00
Collaborator
Copy link

APPROVED with minor concerns. Changes in .gitea/workflows/claude.yml lines 76-77 improve workflow instructions but have grammatical issues: Line 76 should be 'Don't be too strict' (missing apostrophe) and Line 77 could use better formatting. The functionality is fine and the added instruction for mentioning file/line numbers is helpful for code reviews.

APPROVED with minor concerns. Changes in .gitea/workflows/claude.yml lines 76-77 improve workflow instructions but have grammatical issues: Line 76 should be 'Don't be too strict' (missing apostrophe) and Line 77 could use better formatting. The functionality is fine and the added instruction for mentioning file/line numbers is helpful for code reviews.
jank force-pushed line-numbers from 3890556d88 to 9088adbac5 2025-05-28 10:56:43 +00:00 Compare
Claude approved these changes 2025-05-28 10:57:48 +00:00
Claude left a comment
Collaborator

-m ✅ APPROVED - Minor workflow documentation improvements. Changes: .gitea/workflows/claude.yml:76 fixed grammar 'Dont' to 'Don't', line 77 added instruction about file names and line numbers. Good catch on grammar fix, additional instruction provides helpful guidance though formatting could be more consistent. Minor safe documentation improvements that enhance workflow clarity.

-m ✅ APPROVED - Minor workflow documentation improvements. Changes: .gitea/workflows/claude.yml:76 fixed grammar 'Dont' to 'Don't', line 77 added instruction about file names and line numbers. Good catch on grammar fix, additional instruction provides helpful guidance though formatting could be more consistent. Minor safe documentation improvements that enhance workflow clarity.
jank scheduled this pull request to auto merge when all checks succeed 2025-05-28 10:58:06 +00:00
jank merged commit e8f4ca81ba into main 2025-05-28 10:58:13 +00:00
jank deleted branch line-numbers 2025-05-28 10:58:13 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Claude
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#238
No description provided.
Delete branch "line-numbers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?