fix: Dont run on renovate #230

Merged

jank merged 1 commit from no-renovate into main

2025-05-28 09:07:30 +00:00

jank commented

2025-05-28 09:01:00 +00:00

Owner

No description provided.

Claude requested changes 2025-05-28 09:02:39 +00:00

Dismissed

Claude left a comment

Collaborator

The logic for skipping Renovate Bot commits has a critical flaw. The conditional check 'if: steps.check-renovate.outputs.author != Renovate Bot' references an undefined output since the check-renovate step doesn't set any outputs, only echoes and exits. Additionally, using 'exit 0' in line 25 will terminate the entire job, making the conditional check redundant.

Recommendation: Choose one approach - either remove the early exit and properly set outputs for the conditional, or remove the conditional and rely solely on the early exit. The current implementation mixes both approaches inconsistently.

The logic for skipping Renovate Bot commits has a critical flaw. The conditional check 'if: steps.check-renovate.outputs.author \!= Renovate Bot' references an undefined output since the check-renovate step doesn't set any outputs, only echoes and exits. Additionally, using 'exit 0' in line 25 will terminate the entire job, making the conditional check redundant. Recommendation: Choose one approach - either remove the early exit and properly set outputs for the conditional, or remove the conditional and rely solely on the early exit. The current implementation mixes both approaches inconsistently.

jank force-pushed no-renovate from b6ec777565 to cd43f111c4

2025-05-28 09:05:23 +00:00

Compare

Claude approved these changes 2025-05-28 09:07:13 +00:00

Claude left a comment

Collaborator

-m LGTM! The changes successfully prevent Claude from running on Renovate Bot commits. The logic is sound and implementation is clean. Minor suggestion: consider using case-insensitive matching for 'renovate' in the author name to handle different bot naming conventions (e.g., 'renovate[bot]', 'Renovate Bot', etc.). The current exact string match works but could be more robust. Good work on the conditional execution approach!

-m LGTM\! The changes successfully prevent Claude from running on Renovate Bot commits. The logic is sound and implementation is clean. Minor suggestion: consider using case-insensitive matching for 'renovate' in the author name to handle different bot naming conventions (e.g., 'renovate[bot]', 'Renovate Bot', etc.). The current exact string match works but could be more robust. Good work on the conditional execution approach\!