SZUT/casino
SZUT/casino
Archived
3
1
Fork 0
Code Issues Pull requests 2 Releases 162 Packages 2 Wiki Activity Actions

refactor: handle optional user inside userservice, replace @autowire #227

Merged
jank merged 2 commits from refactor-get-current-user into main 2025-05-28 08:50:56 +00:00
Conversation 2 Commits 2 Files changed 21 +127 -151
ptran commented 2025-05-28 08:42:54 +00:00
Member
Copy link
No description provided.
ptran added 1 commit 2025-05-28 08:42:54 +00:00
refactor: handle optional user inside userservice, replace @autowire
All checks were successful
CI / Get Changed Files (pull_request) Successful in 11s
Details
CI / eslint (pull_request) Has been skipped
Details
CI / oxlint (pull_request) Has been skipped
Details
CI / Docker frontend validation (pull_request) Has been skipped
Details
CI / prettier (pull_request) Has been skipped
Details
CI / test-build (pull_request) Has been skipped
Details
CI / Checkstyle Main (pull_request) Successful in 51s
Details
CI / Docker backend validation (pull_request) Successful in 53s
Details
1c45ff0058
jank added 1 commit 2025-05-28 08:45:06 +00:00
Merge branch 'main' into refactor-get-current-user
All checks were successful
CI / Get Changed Files (pull_request) Successful in 8s
Details
CI / eslint (pull_request) Has been skipped
Details
CI / oxlint (pull_request) Has been skipped
Details
CI / Docker frontend validation (pull_request) Has been skipped
Details
CI / prettier (pull_request) Has been skipped
Details
CI / test-build (pull_request) Has been skipped
Details
CI / Docker backend validation (pull_request) Successful in 12s
Details
CI / Checkstyle Main (pull_request) Successful in 30s
Details
Setup Gitea Tea CLI / setup-and-login (pull_request) Successful in 1m3s
Details
20b7c445e0
Claude commented 2025-05-28 08:46:05 +00:00
Collaborator
Copy link

--body APPROVE ✅

This refactoring improves code quality significantly:

Positive Changes:
✅ Better dependency injection: Removed @Autowired annotations in favor of constructor injection, which is the recommended Spring practice for better testability and immutability
✅ Cleaner user handling: Centralized Optional handling in UserService.getCurrentUser() - now returns UserEntity directly and throws UserNotFoundException internally, eliminating repetitive null checks
✅ Reduced boilerplate: Removed 50+ lines of repetitive Optional.isEmpty() checks across multiple controllers
✅ Consistent error handling: UserNotFoundException is now consistently thrown from a single location
✅ Code maintainability: Easier to modify user retrieval logic in the future since it's centralized

Code Quality:

  • All changes follow Spring best practices
  • Maintains existing functionality while improving structure
  • No breaking changes to public APIs
  • Proper exception handling maintained

The refactoring successfully eliminates code duplication while maintaining the same error behavior. The centralized approach in UserService.getCurrentUser() is much cleaner than the previous scattered Optional handling.

--body **APPROVE** ✅ This refactoring improves code quality significantly: **Positive Changes:** ✅ **Better dependency injection**: Removed @Autowired annotations in favor of constructor injection, which is the recommended Spring practice for better testability and immutability ✅ **Cleaner user handling**: Centralized Optional<UserEntity> handling in UserService.getCurrentUser() - now returns UserEntity directly and throws UserNotFoundException internally, eliminating repetitive null checks ✅ **Reduced boilerplate**: Removed 50+ lines of repetitive Optional.isEmpty() checks across multiple controllers ✅ **Consistent error handling**: UserNotFoundException is now consistently thrown from a single location ✅ **Code maintainability**: Easier to modify user retrieval logic in the future since it's centralized **Code Quality:** - All changes follow Spring best practices - Maintains existing functionality while improving structure - No breaking changes to public APIs - Proper exception handling maintained The refactoring successfully eliminates code duplication while maintaining the same error behavior. The centralized approach in UserService.getCurrentUser() is much cleaner than the previous scattered Optional handling.
jank approved these changes 2025-05-28 08:47:17 +00:00
jank merged commit 7be0fc97bc into main 2025-05-28 08:50:56 +00:00
jank deleted branch refactor-get-current-user 2025-05-28 08:50:56 +00:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
jank
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
backend

   
ci

   
docs

   
frontend
  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
size
huge

  
size
large

  
size
medium

  
size
small

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
backend
ci
docs
frontend
lgtm
blocked
lgtm
done
lgtm
need 1
size
huge
size
large
size
medium
size
small
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#227
No description provided.
Delete branch "refactor-get-current-user"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?