SZUT/casino
5
1
Fork 0
Code Issues Pull requests 4 Releases 54 Wiki Activity Actions

feat: add stand and get game features to blackjack game with animations #105

Open
jleibl wants to merge 5 commits from task/CAS-50/add_rest_blackjack_logic_with_frontend_animations into main
pull from: task/CAS-50/add_rest_blackjack_logic_with_frontend_animations
merge into: SZUT:main
Conversation 0 Commits 5 Files changed 17 +806 -70
jleibl commented 2025-03-27 14:45:34 +00:00
Member
Copy link
No description provided.
jleibl added 3 commits 2025-03-27 14:45:35 +00:00
feat(blackjack): add action indicators and loading states
Some checks failed
CI / Get Changed Files (pull_request) Successful in 7s
Details
CI / prettier (pull_request) Failing after 1m0s
Details
CI / eslint (pull_request) Failing after 1m3s
Details
CI / test-build (pull_request) Successful in 1m18s
Details
CI / Checkstyle Main (pull_request) Successful in 1m31s
Details
adc5bbd345
jleibl added 1 commit 2025-03-27 14:47:25 +00:00
style(blackjack): format code for better readability
Some checks failed
CI / Get Changed Files (pull_request) Successful in 6s
Details
CI / eslint (pull_request) Failing after 8s
Details
CI / prettier (pull_request) Successful in 20s
Details
CI / Checkstyle Main (pull_request) Successful in 31s
Details
CI / test-build (pull_request) Successful in 46s
Details
23888ceb27
jleibl added 1 commit 2025-03-27 14:50:38 +00:00
refactor(blackjack): remove unnecessary comments and clean code
All checks were successful
CI / Get Changed Files (pull_request) Successful in 6s
Details
CI / prettier (pull_request) Successful in 19s
Details
CI / Checkstyle Main (pull_request) Successful in 27s
Details
CI / eslint (pull_request) Successful in 45s
Details
CI / test-build (pull_request) Successful in 56s
Details
05322e3d83
jleibl changed title from task/CAS-50/add_rest_blackjack_logic_with_frontend_animations to feat: add stand and get game features to blackjack game with animations 2025-03-27 14:50:56 +00:00
jank requested changes 2025-03-27 17:24:16 +00:00
backend/src/main/java/de/szut/casino/blackjack/BlackJackGameEntity.java
@ -26,1 +26,4 @@
@Version
@JsonIgnore
private Long version;
jank commented 2025-03-27 17:14:41 +00:00
Owner
Copy link

what is this version even used for?

what is this version even used for?
backend/src/main/java/de/szut/casino/blackjack/CardEntity.java
@ -21,1 +21,4 @@
@Version
@JsonIgnore
private Long version;
jank commented 2025-03-27 17:15:20 +00:00
Owner
Copy link

why version here as well

why version here as well
frontend/src/app/feature/game/blackjack/blackjack.component.ts
@ -49,11 +61,14 @@ export default class BlackjackComponent {
this.currentGameId.set(game.id);
this.currentBet.set(game.bet);
this.gameInProgress.set(game.state === 'IN_PROGRESS');
jank commented 2025-03-27 17:20:18 +00:00
Owner
Copy link

create enum for game states

create enum for game states
frontend/src/app/feature/game/blackjack/components/game-controls/game-controls.component.ts
@ -35,1 +87,4 @@
@Output() doubleDown = new EventEmitter<void>();
@Output() leave = new EventEmitter<void>();
calculateHandValue(cards: Card[]): number {
jank commented 2025-03-27 17:21:13 +00:00
Owner
Copy link

extract this into a service and all the other methods

extract this into a service and all the other methods
frontend/src/app/feature/game/blackjack/components/game-result/game-result.component.css
@ -0,0 +1 @@
/* No custom styles needed */
jank commented 2025-03-27 17:22:00 +00:00
Owner
Copy link

just remove this file

just remove this file
frontend/src/app/feature/game/blackjack/components/game-result/game-result.component.spec.ts
@ -0,0 +1,22 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
jank commented 2025-03-27 17:22:55 +00:00
Owner
Copy link

remove this file its unnecisary

remove this file its unnecisary
All checks were successful
CI / Get Changed Files (pull_request) Successful in 6s
Details
CI / prettier (pull_request) Successful in 19s
Required
Details
CI / Checkstyle Main (pull_request) Successful in 27s
Required
Details
CI / eslint (pull_request) Successful in 45s
Required
Details
CI / test-build (pull_request) Successful in 56s
Required
Details
This pull request has changes conflicting with the target branch.
  • backend/src/main/java/de/szut/casino/blackjack/BlackJackGameController.java
  • backend/src/main/java/de/szut/casino/blackjack/BlackJackService.java
  • backend/src/main/java/de/szut/casino/blackjack/BlackJackState.java
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin task/CAS-50/add_rest_blackjack_logic_with_frontend_animations:task/CAS-50/add_rest_blackjack_logic_with_frontend_animations
git checkout task/CAS-50/add_rest_blackjack_logic_with_frontend_animations
Sign in to join this conversation.
Reviewers
No reviewers
jank
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
lgtm
blocked

  
lgtm
done

  
lgtm
need 1

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
lgtm
blocked
lgtm
done
lgtm
need 1
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#105
No description provided.
Delete branch "task/CAS-50/add_rest_blackjack_logic_with_frontend_animations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?