feat: add stand and get game features to blackjack game with animations #105

Merged
jleibl merged 22 commits from task/CAS-50/add_rest_blackjack_logic_with_frontend_animations into main 2025-04-02 08:28:43 +00:00
Member
No description provided.
jleibl added 3 commits 2025-03-27 14:45:35 +00:00
feat(blackjack): add action indicators and loading states
Some checks failed
CI / Get Changed Files (pull_request) Successful in 7s
CI / prettier (pull_request) Failing after 1m0s
CI / eslint (pull_request) Failing after 1m3s
CI / test-build (pull_request) Successful in 1m18s
CI / Checkstyle Main (pull_request) Successful in 1m31s
adc5bbd345
jleibl added 1 commit 2025-03-27 14:47:25 +00:00
style(blackjack): format code for better readability
Some checks failed
CI / Get Changed Files (pull_request) Successful in 6s
CI / eslint (pull_request) Failing after 8s
CI / prettier (pull_request) Successful in 20s
CI / Checkstyle Main (pull_request) Successful in 31s
CI / test-build (pull_request) Successful in 46s
23888ceb27
jleibl added 1 commit 2025-03-27 14:50:38 +00:00
refactor(blackjack): remove unnecessary comments and clean code
All checks were successful
CI / Get Changed Files (pull_request) Successful in 6s
CI / prettier (pull_request) Successful in 19s
CI / Checkstyle Main (pull_request) Successful in 27s
CI / eslint (pull_request) Successful in 45s
CI / test-build (pull_request) Successful in 56s
05322e3d83
jleibl changed title from task/CAS-50/add_rest_blackjack_logic_with_frontend_animations to feat: add stand and get game features to blackjack game with animations 2025-03-27 14:50:56 +00:00
jank requested changes 2025-03-27 17:24:16 +00:00
Dismissed
@ -26,1 +26,4 @@
@Version
@JsonIgnore
private Long version;
Owner

what is this version even used for?

what is this version even used for?
jleibl marked this conversation as resolved
@ -21,1 +21,4 @@
@Version
@JsonIgnore
private Long version;
Owner

why version here as well

why version here as well
jleibl marked this conversation as resolved
@ -49,11 +61,14 @@ export default class BlackjackComponent {
this.currentGameId.set(game.id);
this.currentBet.set(game.bet);
this.gameInProgress.set(game.state === 'IN_PROGRESS');
Owner

create enum for game states

create enum for game states
jleibl marked this conversation as resolved
@ -35,1 +87,4 @@
@Output() doubleDown = new EventEmitter<void>();
@Output() leave = new EventEmitter<void>();
calculateHandValue(cards: Card[]): number {
Owner

extract this into a service and all the other methods

extract this into a service and all the other methods
jleibl marked this conversation as resolved
@ -0,0 +1 @@
/* No custom styles needed */
Owner

just remove this file

just remove this file
jleibl marked this conversation as resolved
@ -0,0 +1,22 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
Owner

remove this file its unnecisary

remove this file its unnecisary
jleibl marked this conversation as resolved
jleibl added 1 commit 2025-04-02 07:06:49 +00:00
feat: add game state enum and refactor game components
Some checks failed
CI / Get Changed Files (pull_request) Successful in 6s
CI / prettier (pull_request) Failing after 26s
CI / eslint (pull_request) Failing after 28s
CI / test-build (pull_request) Successful in 37s
CI / Checkstyle Main (pull_request) Successful in 2m25s
732d475a84
jleibl added 1 commit 2025-04-02 07:08:13 +00:00
style: format code and add missing newlines
All checks were successful
CI / Get Changed Files (pull_request) Successful in 7s
CI / prettier (pull_request) Successful in 22s
CI / eslint (pull_request) Successful in 24s
CI / test-build (pull_request) Successful in 56s
CI / Checkstyle Main (pull_request) Successful in 1m40s
f1c70f5f2c
jleibl added 1 commit 2025-04-02 07:18:48 +00:00
refactor(blackjack): move GameState to feature folder
All checks were successful
CI / Get Changed Files (pull_request) Successful in 6s
CI / eslint (pull_request) Successful in 19s
CI / test-build (pull_request) Successful in 27s
CI / prettier (pull_request) Successful in 41s
CI / Checkstyle Main (pull_request) Successful in 1m25s
f881f82ef1
jank added 11 commits 2025-04-02 07:27:14 +00:00
refactor(game-controls): update import paths for consistency
Some checks failed
CI / Get Changed Files (pull_request) Successful in 6s
CI / Checkstyle Main (pull_request) Has been skipped
CI / eslint (pull_request) Successful in 20s
CI / test-build (pull_request) Failing after 26s
CI / prettier (pull_request) Failing after 32s
1ea2f7c086
style(game-controls): fix formatting in constructor method
Some checks failed
CI / Get Changed Files (pull_request) Successful in 7s
CI / Checkstyle Main (pull_request) Has been skipped
CI / eslint (pull_request) Successful in 18s
CI / test-build (pull_request) Failing after 26s
CI / prettier (pull_request) Successful in 31s
3c0505b75e
feat(landing): add NavbarComponent to landing page component
All checks were successful
CI / Get Changed Files (pull_request) Successful in 5s
CI / Checkstyle Main (pull_request) Has been skipped
CI / eslint (pull_request) Successful in 19s
CI / test-build (pull_request) Successful in 27s
CI / prettier (pull_request) Successful in 32s
0654a98860
Merge pull request 'refactor: update import paths for better readability' (!109) from refactor-some-dots into task/CAS-50/add_rest_blackjack_logic_with_frontend_animations
All checks were successful
CI / Get Changed Files (pull_request) Successful in 6s
CI / eslint (pull_request) Successful in 19s
CI / test-build (pull_request) Successful in 26s
CI / prettier (pull_request) Successful in 40s
CI / Checkstyle Main (pull_request) Successful in 58s
f6b3613a1d
Reviewed-on: #109
jleibl added 1 commit 2025-04-02 07:52:03 +00:00
refactor(blackjack): update import paths for modules
All checks were successful
CI / Get Changed Files (pull_request) Successful in 26s
CI / eslint (pull_request) Successful in 50s
CI / prettier (pull_request) Successful in 52s
CI / Checkstyle Main (pull_request) Successful in 57s
CI / test-build (pull_request) Successful in 1m3s
f17bffe860
jleibl force-pushed task/CAS-50/add_rest_blackjack_logic_with_frontend_animations from f17bffe860 to d397079561 2025-04-02 07:54:27 +00:00 Compare
jank approved these changes 2025-04-02 07:58:48 +00:00
Dismissed
jleibl force-pushed task/CAS-50/add_rest_blackjack_logic_with_frontend_animations from d397079561 to 08b12d238e 2025-04-02 08:14:50 +00:00 Compare
jleibl dismissed jank's review 2025-04-02 08:14:50 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jleibl scheduled this pull request to auto merge when all checks succeed 2025-04-02 08:17:12 +00:00
jleibl added 2 commits 2025-04-02 08:26:16 +00:00
style: format code for consistency and readability
All checks were successful
CI / Get Changed Files (pull_request) Successful in 6s
CI / eslint (pull_request) Successful in 19s
CI / test-build (pull_request) Successful in 27s
CI / prettier (pull_request) Successful in 40s
CI / Checkstyle Main (pull_request) Successful in 1m28s
4a7c54eab8
jank approved these changes 2025-04-02 08:28:41 +00:00
jleibl merged commit 626e28ab65 into main 2025-04-02 08:28:43 +00:00
jleibl deleted branch task/CAS-50/add_rest_blackjack_logic_with_frontend_animations 2025-04-02 08:28:44 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: SZUT/casino#105
No description provided.