mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-28 04:51:07 +00:00 
			
		
		
		
	Uses `gopls check <files>` as a linter. Tested locally and brings up 149 errors currently for me. I don't think I want to fix them in this PR, but I would like at least to get this analysis running on CI. List of errors: ``` modules/indexer/code/indexer.go:181:11: impossible condition: nil != nil routers/private/hook_post_receive.go:120:15: tautological condition: nil == nil services/auth/source/oauth2/providers.go:185:9: tautological condition: nil == nil services/convert/issue.go:216:11: tautological condition: non-nil != nil tests/integration/git_test.go:332:9: impossible condition: nil != nil services/migrations/migrate.go:179:24-43: unused parameter: ctx services/repository/transfer.go:288:48-69: unused parameter: doer tests/integration/api_repo_tags_test.go:75:41-61: unused parameter: session tests/integration/git_test.go:696:64-74: unused parameter: baseBranch tests/integration/gpg_git_test.go:265:27-39: unused parameter: t tests/integration/gpg_git_test.go:284:23-29: unused parameter: tmpDir tests/integration/gpg_git_test.go:284:31-35: unused parameter: name tests/integration/gpg_git_test.go:284:37-42: unused parameter: email ``` (cherry picked from commit 816222243af523316041692622be6f48ef068693) Conflicts: Makefile trivial context conflict and also ask renovate to watch over it do not include it in lint-backend because the errors are not fixed
		
			
				
	
	
		
			434 lines
		
	
	
	
		
			14 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			434 lines
		
	
	
	
		
			14 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package repository
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"os"
 | |
| 	"strings"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models"
 | |
| 	"code.gitea.io/gitea/models/db"
 | |
| 	issues_model "code.gitea.io/gitea/models/issues"
 | |
| 	"code.gitea.io/gitea/models/organization"
 | |
| 	"code.gitea.io/gitea/models/perm"
 | |
| 	access_model "code.gitea.io/gitea/models/perm/access"
 | |
| 	repo_model "code.gitea.io/gitea/models/repo"
 | |
| 	user_model "code.gitea.io/gitea/models/user"
 | |
| 	"code.gitea.io/gitea/modules/log"
 | |
| 	repo_module "code.gitea.io/gitea/modules/repository"
 | |
| 	"code.gitea.io/gitea/modules/sync"
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| 	notify_service "code.gitea.io/gitea/services/notify"
 | |
| )
 | |
| 
 | |
| // repoWorkingPool represents a working pool to order the parallel changes to the same repository
 | |
| // TODO: use clustered lock (unique queue? or *abuse* cache)
 | |
| var repoWorkingPool = sync.NewExclusivePool()
 | |
| 
 | |
| // TransferOwnership transfers all corresponding setting from old user to new one.
 | |
| func TransferOwnership(ctx context.Context, doer, newOwner *user_model.User, repo *repo_model.Repository, teams []*organization.Team) error {
 | |
| 	if err := repo.LoadOwner(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	for _, team := range teams {
 | |
| 		if newOwner.ID != team.OrgID {
 | |
| 			return fmt.Errorf("team %d does not belong to organization", team.ID)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	oldOwner := repo.Owner
 | |
| 
 | |
| 	repoWorkingPool.CheckIn(fmt.Sprint(repo.ID))
 | |
| 	if err := transferOwnership(ctx, doer, newOwner.Name, repo); err != nil {
 | |
| 		repoWorkingPool.CheckOut(fmt.Sprint(repo.ID))
 | |
| 		return err
 | |
| 	}
 | |
| 	repoWorkingPool.CheckOut(fmt.Sprint(repo.ID))
 | |
| 
 | |
| 	newRepo, err := repo_model.GetRepositoryByID(ctx, repo.ID)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	for _, team := range teams {
 | |
| 		if err := models.AddRepository(ctx, team, newRepo); err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	notify_service.TransferRepository(ctx, doer, repo, oldOwner.Name)
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // transferOwnership transfers all corresponding repository items from old user to new one.
 | |
| func transferOwnership(ctx context.Context, doer *user_model.User, newOwnerName string, repo *repo_model.Repository) (err error) {
 | |
| 	repoRenamed := false
 | |
| 	wikiRenamed := false
 | |
| 	oldOwnerName := doer.Name
 | |
| 
 | |
| 	defer func() {
 | |
| 		if !repoRenamed && !wikiRenamed {
 | |
| 			return
 | |
| 		}
 | |
| 
 | |
| 		recoverErr := recover()
 | |
| 		if err == nil && recoverErr == nil {
 | |
| 			return
 | |
| 		}
 | |
| 
 | |
| 		if repoRenamed {
 | |
| 			if err := util.Rename(repo_model.RepoPath(newOwnerName, repo.Name), repo_model.RepoPath(oldOwnerName, repo.Name)); err != nil {
 | |
| 				log.Critical("Unable to move repository %s/%s directory from %s back to correct place %s: %v", oldOwnerName, repo.Name,
 | |
| 					repo_model.RepoPath(newOwnerName, repo.Name), repo_model.RepoPath(oldOwnerName, repo.Name), err)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if wikiRenamed {
 | |
| 			if err := util.Rename(repo_model.WikiPath(newOwnerName, repo.Name), repo_model.WikiPath(oldOwnerName, repo.Name)); err != nil {
 | |
| 				log.Critical("Unable to move wiki for repository %s/%s directory from %s back to correct place %s: %v", oldOwnerName, repo.Name,
 | |
| 					repo_model.WikiPath(newOwnerName, repo.Name), repo_model.WikiPath(oldOwnerName, repo.Name), err)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if recoverErr != nil {
 | |
| 			log.Error("Panic within TransferOwnership: %v\n%s", recoverErr, log.Stack(2))
 | |
| 			panic(recoverErr)
 | |
| 		}
 | |
| 	}()
 | |
| 
 | |
| 	ctx, committer, err := db.TxContext(ctx)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	defer committer.Close()
 | |
| 
 | |
| 	sess := db.GetEngine(ctx)
 | |
| 
 | |
| 	newOwner, err := user_model.GetUserByName(ctx, newOwnerName)
 | |
| 	if err != nil {
 | |
| 		return fmt.Errorf("get new owner '%s': %w", newOwnerName, err)
 | |
| 	}
 | |
| 	newOwnerName = newOwner.Name // ensure capitalisation matches
 | |
| 
 | |
| 	// Check if new owner has repository with same name.
 | |
| 	if has, err := repo_model.IsRepositoryModelOrDirExist(ctx, newOwner, repo.Name); err != nil {
 | |
| 		return fmt.Errorf("IsRepositoryExist: %w", err)
 | |
| 	} else if has {
 | |
| 		return repo_model.ErrRepoAlreadyExist{
 | |
| 			Uname: newOwnerName,
 | |
| 			Name:  repo.Name,
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	oldOwner := repo.Owner
 | |
| 	oldOwnerName = oldOwner.Name
 | |
| 
 | |
| 	// Note: we have to set value here to make sure recalculate accesses is based on
 | |
| 	// new owner.
 | |
| 	repo.OwnerID = newOwner.ID
 | |
| 	repo.Owner = newOwner
 | |
| 	repo.OwnerName = newOwner.Name
 | |
| 
 | |
| 	// Update repository.
 | |
| 	if _, err := sess.ID(repo.ID).Update(repo); err != nil {
 | |
| 		return fmt.Errorf("update owner: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	// Remove redundant collaborators.
 | |
| 	collaborators, err := repo_model.GetCollaborators(ctx, repo.ID, db.ListOptions{})
 | |
| 	if err != nil {
 | |
| 		return fmt.Errorf("getCollaborators: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	// Dummy object.
 | |
| 	collaboration := &repo_model.Collaboration{RepoID: repo.ID}
 | |
| 	for _, c := range collaborators {
 | |
| 		if c.IsGhost() {
 | |
| 			collaboration.ID = c.Collaboration.ID
 | |
| 			if _, err := sess.Delete(collaboration); err != nil {
 | |
| 				return fmt.Errorf("remove collaborator '%d': %w", c.ID, err)
 | |
| 			}
 | |
| 			collaboration.ID = 0
 | |
| 		}
 | |
| 
 | |
| 		if c.ID != newOwner.ID {
 | |
| 			isMember, err := organization.IsOrganizationMember(ctx, newOwner.ID, c.ID)
 | |
| 			if err != nil {
 | |
| 				return fmt.Errorf("IsOrgMember: %w", err)
 | |
| 			} else if !isMember {
 | |
| 				continue
 | |
| 			}
 | |
| 		}
 | |
| 		collaboration.UserID = c.ID
 | |
| 		if _, err := sess.Delete(collaboration); err != nil {
 | |
| 			return fmt.Errorf("remove collaborator '%d': %w", c.ID, err)
 | |
| 		}
 | |
| 		collaboration.UserID = 0
 | |
| 	}
 | |
| 
 | |
| 	// Remove old team-repository relations.
 | |
| 	if oldOwner.IsOrganization() {
 | |
| 		if err := organization.RemoveOrgRepo(ctx, oldOwner.ID, repo.ID); err != nil {
 | |
| 			return fmt.Errorf("removeOrgRepo: %w", err)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if newOwner.IsOrganization() {
 | |
| 		teams, err := organization.FindOrgTeams(ctx, newOwner.ID)
 | |
| 		if err != nil {
 | |
| 			return fmt.Errorf("LoadTeams: %w", err)
 | |
| 		}
 | |
| 		for _, t := range teams {
 | |
| 			if t.IncludesAllRepositories {
 | |
| 				if err := models.AddRepository(ctx, t, repo); err != nil {
 | |
| 					return fmt.Errorf("AddRepository: %w", err)
 | |
| 				}
 | |
| 			}
 | |
| 		}
 | |
| 	} else if err := access_model.RecalculateAccesses(ctx, repo); err != nil {
 | |
| 		// Organization called this in addRepository method.
 | |
| 		return fmt.Errorf("recalculateAccesses: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	// Update repository count.
 | |
| 	if _, err := sess.Exec("UPDATE `user` SET num_repos=num_repos+1 WHERE id=?", newOwner.ID); err != nil {
 | |
| 		return fmt.Errorf("increase new owner repository count: %w", err)
 | |
| 	} else if _, err := sess.Exec("UPDATE `user` SET num_repos=num_repos-1 WHERE id=?", oldOwner.ID); err != nil {
 | |
| 		return fmt.Errorf("decrease old owner repository count: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	if err := repo_model.WatchRepo(ctx, doer.ID, repo.ID, true); err != nil {
 | |
| 		return fmt.Errorf("watchRepo: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	// Remove watch for organization.
 | |
| 	if oldOwner.IsOrganization() {
 | |
| 		if err := repo_model.WatchRepo(ctx, oldOwner.ID, repo.ID, false); err != nil {
 | |
| 			return fmt.Errorf("watchRepo [false]: %w", err)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Delete labels that belong to the old organization and comments that added these labels
 | |
| 	if oldOwner.IsOrganization() {
 | |
| 		if _, err := sess.Exec(`DELETE FROM issue_label WHERE issue_label.id IN (
 | |
| 			SELECT il_too.id FROM (
 | |
| 				SELECT il_too_too.id
 | |
| 					FROM issue_label AS il_too_too
 | |
| 						INNER JOIN label ON il_too_too.label_id = label.id
 | |
| 						INNER JOIN issue on issue.id = il_too_too.issue_id
 | |
| 					WHERE
 | |
| 						issue.repo_id = ? AND ((label.org_id = 0 AND issue.repo_id != label.repo_id) OR (label.repo_id = 0 AND label.org_id != ?))
 | |
| 		) AS il_too )`, repo.ID, newOwner.ID); err != nil {
 | |
| 			return fmt.Errorf("Unable to remove old org labels: %w", err)
 | |
| 		}
 | |
| 
 | |
| 		if _, err := sess.Exec(`DELETE FROM comment WHERE comment.id IN (
 | |
| 			SELECT il_too.id FROM (
 | |
| 				SELECT com.id
 | |
| 					FROM comment AS com
 | |
| 						INNER JOIN label ON com.label_id = label.id
 | |
| 						INNER JOIN issue ON issue.id = com.issue_id
 | |
| 					WHERE
 | |
| 						com.type = ? AND issue.repo_id = ? AND ((label.org_id = 0 AND issue.repo_id != label.repo_id) OR (label.repo_id = 0 AND label.org_id != ?))
 | |
| 		) AS il_too)`, issues_model.CommentTypeLabel, repo.ID, newOwner.ID); err != nil {
 | |
| 			return fmt.Errorf("Unable to remove old org label comments: %w", err)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Rename remote repository to new path and delete local copy.
 | |
| 	dir := user_model.UserPath(newOwner.Name)
 | |
| 
 | |
| 	if err := os.MkdirAll(dir, os.ModePerm); err != nil {
 | |
| 		return fmt.Errorf("Failed to create dir %s: %w", dir, err)
 | |
| 	}
 | |
| 
 | |
| 	if err := util.Rename(repo_model.RepoPath(oldOwner.Name, repo.Name), repo_model.RepoPath(newOwner.Name, repo.Name)); err != nil {
 | |
| 		return fmt.Errorf("rename repository directory: %w", err)
 | |
| 	}
 | |
| 	repoRenamed = true
 | |
| 
 | |
| 	// Rename remote wiki repository to new path and delete local copy.
 | |
| 	wikiPath := repo_model.WikiPath(oldOwner.Name, repo.Name)
 | |
| 
 | |
| 	if isExist, err := util.IsExist(wikiPath); err != nil {
 | |
| 		log.Error("Unable to check if %s exists. Error: %v", wikiPath, err)
 | |
| 		return err
 | |
| 	} else if isExist {
 | |
| 		if err := util.Rename(wikiPath, repo_model.WikiPath(newOwner.Name, repo.Name)); err != nil {
 | |
| 			return fmt.Errorf("rename repository wiki: %w", err)
 | |
| 		}
 | |
| 		wikiRenamed = true
 | |
| 	}
 | |
| 
 | |
| 	if err := models.DeleteRepositoryTransfer(ctx, repo.ID); err != nil {
 | |
| 		return fmt.Errorf("deleteRepositoryTransfer: %w", err)
 | |
| 	}
 | |
| 	repo.Status = repo_model.RepositoryReady
 | |
| 	if err := repo_model.UpdateRepositoryCols(ctx, repo, "status"); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// If there was previously a redirect at this location, remove it.
 | |
| 	if err := repo_model.DeleteRedirect(ctx, newOwner.ID, repo.Name); err != nil {
 | |
| 		return fmt.Errorf("delete repo redirect: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	if err := repo_model.NewRedirect(ctx, oldOwner.ID, repo.ID, repo.Name, repo.Name); err != nil {
 | |
| 		return fmt.Errorf("repo_model.NewRedirect: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	return committer.Commit()
 | |
| }
 | |
| 
 | |
| // changeRepositoryName changes all corresponding setting from old repository name to new one.
 | |
| func changeRepositoryName(ctx context.Context, repo *repo_model.Repository, newRepoName string) (err error) {
 | |
| 	oldRepoName := repo.Name
 | |
| 	newRepoName = strings.ToLower(newRepoName)
 | |
| 	if err = repo_model.IsUsableRepoName(newRepoName); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	if err := repo.LoadOwner(ctx); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	has, err := repo_model.IsRepositoryModelOrDirExist(ctx, repo.Owner, newRepoName)
 | |
| 	if err != nil {
 | |
| 		return fmt.Errorf("IsRepositoryExist: %w", err)
 | |
| 	} else if has {
 | |
| 		return repo_model.ErrRepoAlreadyExist{
 | |
| 			Uname: repo.Owner.Name,
 | |
| 			Name:  newRepoName,
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	newRepoPath := repo_model.RepoPath(repo.Owner.Name, newRepoName)
 | |
| 	if err = util.Rename(repo.RepoPath(), newRepoPath); err != nil {
 | |
| 		return fmt.Errorf("rename repository directory: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	wikiPath := repo.WikiPath()
 | |
| 	isExist, err := util.IsExist(wikiPath)
 | |
| 	if err != nil {
 | |
| 		log.Error("Unable to check if %s exists. Error: %v", wikiPath, err)
 | |
| 		return err
 | |
| 	}
 | |
| 	if isExist {
 | |
| 		if err = util.Rename(wikiPath, repo_model.WikiPath(repo.Owner.Name, newRepoName)); err != nil {
 | |
| 			return fmt.Errorf("rename repository wiki: %w", err)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	ctx, committer, err := db.TxContext(ctx)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	defer committer.Close()
 | |
| 
 | |
| 	if err := repo_model.NewRedirect(ctx, repo.Owner.ID, repo.ID, oldRepoName, newRepoName); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	return committer.Commit()
 | |
| }
 | |
| 
 | |
| // ChangeRepositoryName changes all corresponding setting from old repository name to new one.
 | |
| func ChangeRepositoryName(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, newRepoName string) error {
 | |
| 	log.Trace("ChangeRepositoryName: %s/%s -> %s", doer.Name, repo.Name, newRepoName)
 | |
| 
 | |
| 	oldRepoName := repo.Name
 | |
| 
 | |
| 	// Change repository directory name. We must lock the local copy of the
 | |
| 	// repo so that we can atomically rename the repo path and updates the
 | |
| 	// local copy's origin accordingly.
 | |
| 
 | |
| 	repoWorkingPool.CheckIn(fmt.Sprint(repo.ID))
 | |
| 	if err := changeRepositoryName(ctx, repo, newRepoName); err != nil {
 | |
| 		repoWorkingPool.CheckOut(fmt.Sprint(repo.ID))
 | |
| 		return err
 | |
| 	}
 | |
| 	repoWorkingPool.CheckOut(fmt.Sprint(repo.ID))
 | |
| 
 | |
| 	repo.Name = newRepoName
 | |
| 	notify_service.RenameRepository(ctx, doer, repo, oldRepoName)
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // StartRepositoryTransfer transfer a repo from one owner to a new one.
 | |
| // it make repository into pending transfer state, if doer can not create repo for new owner.
 | |
| func StartRepositoryTransfer(ctx context.Context, doer, newOwner *user_model.User, repo *repo_model.Repository, teams []*organization.Team) error {
 | |
| 	if user_model.IsBlocked(ctx, newOwner.ID, doer.ID) {
 | |
| 		return user_model.ErrBlockedByUser
 | |
| 	}
 | |
| 
 | |
| 	if err := models.TestRepositoryReadyForTransfer(repo.Status); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// Admin is always allowed to transfer || user transfer repo back to his account
 | |
| 	if doer.IsAdmin || doer.ID == newOwner.ID {
 | |
| 		return TransferOwnership(ctx, doer, newOwner, repo, teams)
 | |
| 	}
 | |
| 
 | |
| 	// If new owner is an org and user can create repos he can transfer directly too
 | |
| 	if newOwner.IsOrganization() {
 | |
| 		allowed, err := organization.CanCreateOrgRepo(ctx, newOwner.ID, doer.ID)
 | |
| 		if err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 		if allowed {
 | |
| 			return TransferOwnership(ctx, doer, newOwner, repo, teams)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// In case the new owner would not have sufficient access to the repo, give access rights for read
 | |
| 	hasAccess, err := access_model.HasAccess(ctx, newOwner.ID, repo)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	if !hasAccess {
 | |
| 		if err := repo_module.AddCollaborator(ctx, repo, newOwner); err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 		if err := repo_model.ChangeCollaborationAccessMode(ctx, repo, newOwner.ID, perm.AccessModeRead); err != nil {
 | |
| 			return err
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Make repo as pending for transfer
 | |
| 	repo.Status = repo_model.RepositoryPendingTransfer
 | |
| 	if err := models.CreatePendingRepositoryTransfer(ctx, doer, newOwner, repo.ID, teams); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// notify users who are able to accept / reject transfer
 | |
| 	notify_service.RepoPendingTransfer(ctx, doer, newOwner, repo)
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // CancelRepositoryTransfer marks the repository as ready and remove pending transfer entry,
 | |
| // thus cancel the transfer process.
 | |
| func CancelRepositoryTransfer(ctx context.Context, repo *repo_model.Repository) error {
 | |
| 	ctx, committer, err := db.TxContext(ctx)
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	defer committer.Close()
 | |
| 
 | |
| 	repo.Status = repo_model.RepositoryReady
 | |
| 	if err := repo_model.UpdateRepositoryCols(ctx, repo, "status"); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	if err := models.DeleteRepositoryTransfer(ctx, repo.ID); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	return committer.Commit()
 | |
| }
 |