oliverpool dd3f24deef fix: storage(minio): prevent io.Reader close (#8541) ... Fixes #8529, reverts #8527. I was able to reproduce the problem in a test: - it triggered only when the reader was an io.Reader - and the size was provided (-1 takes another code path in minio) 287b1f21e1 should fail when running: ``` docker run --rm -e MINIO_DOMAIN=minio -e MINIO_ROOT_USER=123456 -e MINIO_ROOT_PASSWORD=12345678 -p 9000:9000 data.forgejo.org/oci/bitnami/minio:2024.8.17 ``` and ``` TEST_MINIO_ENDPOINT=localhost:9000 go test -v -run ^TestMinioStorageIterator$ ./modules/storage ``` ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8541 Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: oliverpool <git@olivier.pfad.fr> Co-committed-by: oliverpool <git@olivier.pfad.fr>		2025-07-17 12:31:38 +02:00
..
testdata	feat: add support for a credentials chain for minio access (#31051)	2024-06-02 10:14:09 +02:00
helper.go	Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365)	2024-11-05 09:33:15 +01:00
helper_test.go	Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365)	2024-11-05 09:33:15 +01:00
local.go	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
local_test.go	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)	2025-03-28 22:22:21 +00:00
minio.go	fix: storage(minio): prevent io.Reader close (#8541)	2025-07-17 12:31:38 +02:00
minio_test.go	chore(ci): skip tests if TEST_{MINIO_ENDPOINT,ELASTICSEARCH_URL} is not set (#8166)	2025-06-12 21:13:52 +02:00
storage.go	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
storage_test.go	fix: storage(minio): prevent io.Reader close (#8541)	2025-07-17 12:31:38 +02:00