mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 06:21:11 +00:00 
			
		
		
		
	Containers have been refactored to use the same serve method as other packages, ensuring consistent response handling. fixes #7888 ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/8037): <!--number 8037 --><!--line 0 --><!--description b21pdCBDb250ZW50LUxlbmd0aCBvbiAzMDcgcmVkaXJlY3RzIHdoZW4gc2VydmluZyBkaXJlY3QgbWFuaWZlc3QgZm9yIGNvbnRhaW5lcnM=-->omit Content-Length on 307 redirects when serving direct manifest for containers<!--description--> <!--end release-notes-assistant--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8037 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Julian Schlarb <julian.schlarb@denktmit.de> Co-committed-by: Julian Schlarb <julian.schlarb@denktmit.de>
		
			
				
	
	
		
			71 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			71 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2024 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package context
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"net/http/httptest"
 | |
| 	"testing"
 | |
| 
 | |
| 	"forgejo.org/modules/setting"
 | |
| 	"forgejo.org/modules/test"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestRedirect(t *testing.T) {
 | |
| 	defer test.MockVariableValue(&setting.AppURL, "http://localhost:3000/")()
 | |
| 	req, _ := http.NewRequest("GET", "/", nil)
 | |
| 
 | |
| 	cases := []struct {
 | |
| 		url  string
 | |
| 		keep bool
 | |
| 	}{
 | |
| 		{"http://test", false},
 | |
| 		{"https://test", false},
 | |
| 		{"//test", false},
 | |
| 		{"/://test", true},
 | |
| 		{"/test", true},
 | |
| 	}
 | |
| 	for _, c := range cases {
 | |
| 		resp := httptest.NewRecorder()
 | |
| 		b, cleanup := NewBaseContext(resp, req)
 | |
| 		resp.Header().Add("Set-Cookie", (&http.Cookie{Name: setting.SessionConfig.CookieName, Value: "dummy"}).String())
 | |
| 		b.Redirect(c.url)
 | |
| 		cleanup()
 | |
| 		has := resp.Header().Get("Set-Cookie") == "i_like_gitea=dummy"
 | |
| 		assert.Equal(t, c.keep, has, "url = %q", c.url)
 | |
| 		assert.Equal(t, http.StatusSeeOther, resp.Code)
 | |
| 	}
 | |
| 
 | |
| 	req, _ = http.NewRequest("GET", "/", nil)
 | |
| 	resp := httptest.NewRecorder()
 | |
| 	req.Header.Add("HX-Request", "true")
 | |
| 	b, cleanup := NewBaseContext(resp, req)
 | |
| 	b.Redirect("/other")
 | |
| 	cleanup()
 | |
| 	assert.Equal(t, "/other", resp.Header().Get("HX-Redirect"))
 | |
| 	assert.Equal(t, http.StatusNoContent, resp.Code)
 | |
| }
 | |
| 
 | |
| func TestRedirectOptionalStatus(t *testing.T) {
 | |
| 	defer test.MockVariableValue(&setting.AppURL, "http://localhost:3000/")()
 | |
| 	req, _ := http.NewRequest("GET", "/", nil)
 | |
| 
 | |
| 	cases := []struct {
 | |
| 		expected int
 | |
| 		actual   int
 | |
| 	}{
 | |
| 		{expected: 303},
 | |
| 		{http.StatusTemporaryRedirect, 307},
 | |
| 		{http.StatusPermanentRedirect, 308},
 | |
| 	}
 | |
| 	for _, c := range cases {
 | |
| 		resp := httptest.NewRecorder()
 | |
| 		b, cleanup := NewBaseContext(resp, req)
 | |
| 		b.Redirect("/", c.actual)
 | |
| 		cleanup()
 | |
| 		assert.Equal(t, c.expected, resp.Code)
 | |
| 	}
 | |
| }
 |