forgejo/web_src/js/features
delvh e95b42e187
Improve accessibility when (re-)viewing files (#24817)
Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
2023-05-21 20:47:41 +00:00
..
admin
comp
captcha.js
citation.js
clipboard.js
codeeditor.js
colorpicker.js
common-global.js
common-issue-list.js
common-issue-list.test.js
common-organization.js
contextpopup.js
copycontent.js
dropzone.js
emoji.js
eventsource.sharedworker.js
file-fold.js
heatmap.js
imagediff.js
install.js
notification.js
org-team.js
pull-view-file.js
repo-branch.js
repo-code.js
repo-code.test.js
repo-commit.js
repo-common.js
repo-diff-filetree.js
repo-diff.js
repo-editor.js
repo-findfile.js
repo-findfile.test.js
repo-graph.js
repo-home.js
repo-issue-content.js
repo-issue-list.js
repo-issue-pr-form.js
repo-issue.js
repo-legacy.js
repo-migrate.js
repo-migration.js
repo-projects.js
repo-release.js
repo-settings.js
repo-template.js
repo-unicode-escape.js
repo-wiki.js
serviceworker.js
sshkey-helper.js
stopwatch.js
tablesort.js
tribute.js
user-auth-webauthn.js
user-auth.js
user-settings.js