mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 06:21:11 +00:00 
			
		
		
		
	- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
		
			
				
	
	
		
			128 lines
		
	
	
	
		
			3.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			128 lines
		
	
	
	
		
			3.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2021 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package v1_14 //nolint
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 
 | |
| 	migration_tests "code.gitea.io/gitea/models/migrations/test"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func Test_RemoveInvalidLabels(t *testing.T) {
 | |
| 	// Models used by the migration
 | |
| 	type Comment struct {
 | |
| 		ID           int64 `xorm:"pk autoincr"`
 | |
| 		Type         int   `xorm:"INDEX"`
 | |
| 		IssueID      int64 `xorm:"INDEX"`
 | |
| 		LabelID      int64
 | |
| 		ShouldRemain bool // <- Flag for testing the migration
 | |
| 	}
 | |
| 
 | |
| 	type Issue struct {
 | |
| 		ID     int64 `xorm:"pk autoincr"`
 | |
| 		RepoID int64 `xorm:"INDEX UNIQUE(repo_index)"`
 | |
| 		Index  int64 `xorm:"UNIQUE(repo_index)"` // Index in one repository.
 | |
| 	}
 | |
| 
 | |
| 	type Repository struct {
 | |
| 		ID        int64  `xorm:"pk autoincr"`
 | |
| 		OwnerID   int64  `xorm:"UNIQUE(s) index"`
 | |
| 		LowerName string `xorm:"UNIQUE(s) INDEX NOT NULL"`
 | |
| 	}
 | |
| 
 | |
| 	type Label struct {
 | |
| 		ID     int64 `xorm:"pk autoincr"`
 | |
| 		RepoID int64 `xorm:"INDEX"`
 | |
| 		OrgID  int64 `xorm:"INDEX"`
 | |
| 	}
 | |
| 
 | |
| 	type IssueLabel struct {
 | |
| 		ID           int64 `xorm:"pk autoincr"`
 | |
| 		IssueID      int64 `xorm:"UNIQUE(s)"`
 | |
| 		LabelID      int64 `xorm:"UNIQUE(s)"`
 | |
| 		ShouldRemain bool  // <- Flag for testing the migration
 | |
| 	}
 | |
| 
 | |
| 	// load and prepare the test database
 | |
| 	x, deferable := migration_tests.PrepareTestEnv(t, 0, new(Comment), new(Issue), new(Repository), new(IssueLabel), new(Label))
 | |
| 	if x == nil || t.Failed() {
 | |
| 		defer deferable()
 | |
| 		return
 | |
| 	}
 | |
| 	defer deferable()
 | |
| 
 | |
| 	var issueLabels []*IssueLabel
 | |
| 	ilPreMigration := map[int64]*IssueLabel{}
 | |
| 	ilPostMigration := map[int64]*IssueLabel{}
 | |
| 
 | |
| 	var comments []*Comment
 | |
| 	comPreMigration := map[int64]*Comment{}
 | |
| 	comPostMigration := map[int64]*Comment{}
 | |
| 
 | |
| 	// Get pre migration values
 | |
| 	if err := x.Find(&issueLabels); err != nil {
 | |
| 		t.Errorf("Unable to find issueLabels: %v", err)
 | |
| 		return
 | |
| 	}
 | |
| 	for _, issueLabel := range issueLabels {
 | |
| 		ilPreMigration[issueLabel.ID] = issueLabel
 | |
| 	}
 | |
| 	if err := x.Find(&comments); err != nil {
 | |
| 		t.Errorf("Unable to find comments: %v", err)
 | |
| 		return
 | |
| 	}
 | |
| 	for _, comment := range comments {
 | |
| 		comPreMigration[comment.ID] = comment
 | |
| 	}
 | |
| 
 | |
| 	// Run the migration
 | |
| 	if err := RemoveInvalidLabels(x); err != nil {
 | |
| 		t.Errorf("unable to RemoveInvalidLabels: %v", err)
 | |
| 	}
 | |
| 
 | |
| 	// Get the post migration values
 | |
| 	issueLabels = issueLabels[:0]
 | |
| 	if err := x.Find(&issueLabels); err != nil {
 | |
| 		t.Errorf("Unable to find issueLabels: %v", err)
 | |
| 		return
 | |
| 	}
 | |
| 	for _, issueLabel := range issueLabels {
 | |
| 		ilPostMigration[issueLabel.ID] = issueLabel
 | |
| 	}
 | |
| 	comments = comments[:0]
 | |
| 	if err := x.Find(&comments); err != nil {
 | |
| 		t.Errorf("Unable to find comments: %v", err)
 | |
| 		return
 | |
| 	}
 | |
| 	for _, comment := range comments {
 | |
| 		comPostMigration[comment.ID] = comment
 | |
| 	}
 | |
| 
 | |
| 	// Finally test results of the migration
 | |
| 	for id, comment := range comPreMigration {
 | |
| 		post, ok := comPostMigration[id]
 | |
| 		if ok {
 | |
| 			if !comment.ShouldRemain {
 | |
| 				t.Errorf("Comment[%d] remained but should have been deleted", id)
 | |
| 			}
 | |
| 			assert.Equal(t, comment, post)
 | |
| 		} else if comment.ShouldRemain {
 | |
| 			t.Errorf("Comment[%d] was deleted but should have remained", id)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	for id, il := range ilPreMigration {
 | |
| 		post, ok := ilPostMigration[id]
 | |
| 		if ok {
 | |
| 			if !il.ShouldRemain {
 | |
| 				t.Errorf("IssueLabel[%d] remained but should have been deleted", id)
 | |
| 			}
 | |
| 			assert.Equal(t, il, post)
 | |
| 		} else if il.ShouldRemain {
 | |
| 			t.Errorf("IssueLabel[%d] was deleted but should have remained", id)
 | |
| 		}
 | |
| 	}
 | |
| }
 |