mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-08-19 08:51:10 +00:00
resolves #8549 This PR add a config to enforce 2FA for the whole Forgejo instance. It can be configured to `none`, `admin` or `all`. A user who is required to enable 2FA is like a disabled user. He can only see the `/user/settings/security`-Page to enable 2FA, this should be similar to a user which needs to change his password. Also api and git-commands are not allowed. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [ ] I did not document these changes and I do not expect someone else to do it. I will do it, if the general idea of this PR is a good feature. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Security features - [PR](https://codeberg.org/forgejo/forgejo/pulls/8753): <!--number 8753 --><!--line 0 --><!--description R2xvYmFsIDJGQSBlbmZvcmNlbWVudA==-->Global 2FA enforcement<!--description--> <!--end release-notes-assistant--> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8753 Reviewed-by: 0ko <0ko@noreply.codeberg.org> Reviewed-by: Ellen Εμιλία Άννα Zscheile <fogti@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: zokki <zokki.softwareschmiede@gmail.com> Co-committed-by: zokki <zokki.softwareschmiede@gmail.com>
305 lines
8.9 KiB
Go
305 lines
8.9 KiB
Go
// Copyright 2014 The Gogs Authors. All rights reserved.
|
|
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package security
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/base64"
|
|
"html/template"
|
|
"image/png"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"forgejo.org/models/auth"
|
|
"forgejo.org/modules/log"
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/modules/web"
|
|
"forgejo.org/services/context"
|
|
"forgejo.org/services/forms"
|
|
"forgejo.org/services/mailer"
|
|
|
|
"github.com/pquerna/otp"
|
|
"github.com/pquerna/otp/totp"
|
|
)
|
|
|
|
// RegenerateScratchTwoFactor regenerates the user's 2FA scratch code.
|
|
func RegenerateScratchTwoFactor(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("settings")
|
|
ctx.Data["PageIsSettingsSecurity"] = true
|
|
|
|
t, err := auth.GetTwoFactorByUID(ctx, ctx.Doer.ID)
|
|
if err != nil {
|
|
if auth.IsErrTwoFactorNotEnrolled(err) {
|
|
ctx.Flash.Error(ctx.Tr("settings.twofa_not_enrolled"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
} else {
|
|
ctx.ServerError("SettingsTwoFactor: Failed to GetTwoFactorByUID", err)
|
|
}
|
|
return
|
|
}
|
|
|
|
token := t.GenerateScratchToken()
|
|
|
|
if err = auth.UpdateTwoFactor(ctx, t); err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: Failed to UpdateTwoFactor", err)
|
|
return
|
|
}
|
|
|
|
ctx.Flash.Success(ctx.Tr("settings.twofa_scratch_token_regenerated", token))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
}
|
|
|
|
// DisableTwoFactor deletes the user's 2FA settings.
|
|
func DisableTwoFactor(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("settings")
|
|
ctx.Data["PageIsSettingsSecurity"] = true
|
|
|
|
if ctx.Doer.MustHaveTwoFactor() {
|
|
ctx.NotFound("DisableTwoFactor", nil)
|
|
return
|
|
}
|
|
|
|
disableTwoFactor(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
ctx.Flash.Success(ctx.Tr("settings.twofa_disabled"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
}
|
|
|
|
func disableTwoFactor(ctx *context.Context) {
|
|
t, err := auth.GetTwoFactorByUID(ctx, ctx.Doer.ID)
|
|
if err != nil {
|
|
if auth.IsErrTwoFactorNotEnrolled(err) {
|
|
ctx.Flash.Error(ctx.Tr("settings.twofa_not_enrolled"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
} else {
|
|
ctx.ServerError("SettingsTwoFactor: Failed to GetTwoFactorByUID", err)
|
|
}
|
|
return
|
|
}
|
|
|
|
if err = auth.DeleteTwoFactorByID(ctx, t.ID, ctx.Doer.ID); err != nil {
|
|
if auth.IsErrTwoFactorNotEnrolled(err) {
|
|
// There is a potential DB race here - we must have been disabled by another request in the intervening period
|
|
ctx.Flash.Success(ctx.Tr("settings.twofa_disabled"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
} else {
|
|
ctx.ServerError("SettingsTwoFactor: Failed to DeleteTwoFactorByID", err)
|
|
}
|
|
return
|
|
}
|
|
|
|
if err := mailer.SendDisabledTOTP(ctx, ctx.Doer); err != nil {
|
|
ctx.ServerError("SendDisabledTOTP", err)
|
|
return
|
|
}
|
|
}
|
|
|
|
func twofaGenerateSecretAndQr(ctx *context.Context) bool {
|
|
var otpKey *otp.Key
|
|
var err error
|
|
uri := ctx.Session.Get("twofaUri")
|
|
if uri != nil {
|
|
otpKey, err = otp.NewKeyFromURL(uri.(string))
|
|
if err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: Failed NewKeyFromURL: ", err)
|
|
return false
|
|
}
|
|
}
|
|
// Filter unsafe character ':' in issuer
|
|
issuer := strings.ReplaceAll(setting.AppName+" ("+setting.Domain+")", ":", "")
|
|
if otpKey == nil {
|
|
otpKey, err = totp.Generate(totp.GenerateOpts{
|
|
SecretSize: 40,
|
|
Issuer: issuer,
|
|
AccountName: ctx.Doer.Name,
|
|
})
|
|
if err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: totpGenerate Failed", err)
|
|
return false
|
|
}
|
|
}
|
|
|
|
ctx.Data["TwofaSecret"] = otpKey.Secret()
|
|
img, err := otpKey.Image(320, 240)
|
|
if err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: otpKey image generation failed", err)
|
|
return false
|
|
}
|
|
|
|
var imgBytes bytes.Buffer
|
|
if err = png.Encode(&imgBytes, img); err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: otpKey png encoding failed", err)
|
|
return false
|
|
}
|
|
|
|
ctx.Data["QrUri"] = template.URL("data:image/png;base64," + base64.StdEncoding.EncodeToString(imgBytes.Bytes()))
|
|
|
|
if err := ctx.Session.Set("twofaSecret", otpKey.Secret()); err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: Failed to set session for twofaSecret", err)
|
|
return false
|
|
}
|
|
|
|
if err := ctx.Session.Set("twofaUri", otpKey.String()); err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: Failed to set session for twofaUri", err)
|
|
return false
|
|
}
|
|
|
|
// Here we're just going to try to release the session early
|
|
if err := ctx.Session.Release(); err != nil {
|
|
// we'll tolerate errors here as they *should* get saved elsewhere
|
|
log.Error("Unable to save changes to the session: %v", err)
|
|
}
|
|
return true
|
|
}
|
|
|
|
// EnrollTwoFactor shows the page where the user can enroll into 2FA.
|
|
func EnrollTwoFactor(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("settings")
|
|
ctx.Data["PageIsSettingsSecurity"] = true
|
|
|
|
t, err := auth.GetTwoFactorByUID(ctx, ctx.Doer.ID)
|
|
if t != nil {
|
|
// already enrolled - we should redirect back!
|
|
log.Warn("Trying to re-enroll %-v in twofa when already enrolled", ctx.Doer)
|
|
ctx.Flash.Error(ctx.Tr("settings.twofa_is_enrolled"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
return
|
|
}
|
|
if err != nil && !auth.IsErrTwoFactorNotEnrolled(err) {
|
|
ctx.ServerError("SettingsTwoFactor: GetTwoFactorByUID", err)
|
|
return
|
|
}
|
|
|
|
if !twofaGenerateSecretAndQr(ctx) {
|
|
return
|
|
}
|
|
|
|
ctx.HTML(http.StatusOK, tplSettingsTwofaEnroll)
|
|
}
|
|
|
|
// EnrollTwoFactorPost handles enrolling the user into 2FA.
|
|
func EnrollTwoFactorPost(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("settings")
|
|
ctx.Data["PageIsSettingsSecurity"] = true
|
|
|
|
t, err := auth.GetTwoFactorByUID(ctx, ctx.Doer.ID)
|
|
if t != nil {
|
|
// already enrolled
|
|
ctx.Flash.Error(ctx.Tr("settings.twofa_is_enrolled"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
return
|
|
}
|
|
if err != nil && !auth.IsErrTwoFactorNotEnrolled(err) {
|
|
ctx.ServerError("SettingsTwoFactor: Failed to check if already enrolled with GetTwoFactorByUID", err)
|
|
return
|
|
}
|
|
|
|
enrollTwoFactor(ctx)
|
|
}
|
|
|
|
func enrollTwoFactor(ctx *context.Context) {
|
|
form := web.GetForm(ctx).(*forms.TwoFactorAuthForm)
|
|
|
|
if ctx.HasError() {
|
|
if !twofaGenerateSecretAndQr(ctx) {
|
|
return
|
|
}
|
|
ctx.HTML(http.StatusOK, tplSettingsTwofaEnroll)
|
|
return
|
|
}
|
|
|
|
secretRaw := ctx.Session.Get("twofaSecret")
|
|
if secretRaw == nil {
|
|
ctx.Flash.Error(ctx.Tr("settings.twofa_failed_get_secret"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security/two_factor/enroll")
|
|
return
|
|
}
|
|
|
|
secret := secretRaw.(string)
|
|
if !totp.Validate(form.Passcode, secret) {
|
|
if !twofaGenerateSecretAndQr(ctx) {
|
|
return
|
|
}
|
|
ctx.Flash.Error(ctx.Tr("settings.passcode_invalid"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security/two_factor/enroll")
|
|
return
|
|
}
|
|
|
|
twoFactor := &auth.TwoFactor{
|
|
UID: ctx.Doer.ID,
|
|
}
|
|
token := twoFactor.GenerateScratchToken()
|
|
|
|
// Now we have to delete the secrets - because if we fail to insert then it's highly likely that they have already been used
|
|
// If we can detect the unique constraint failure below we can move this to after the NewTwoFactor
|
|
if err := ctx.Session.Delete("twofaSecret"); err != nil {
|
|
// tolerate this failure - it's more important to continue
|
|
log.Error("Unable to delete twofaSecret from the session: Error: %v", err)
|
|
}
|
|
if err := ctx.Session.Delete("twofaUri"); err != nil {
|
|
// tolerate this failure - it's more important to continue
|
|
log.Error("Unable to delete twofaUri from the session: Error: %v", err)
|
|
}
|
|
if err := ctx.Session.Release(); err != nil {
|
|
// tolerate this failure - it's more important to continue
|
|
log.Error("Unable to save changes to the session: %v", err)
|
|
}
|
|
|
|
if err := mailer.SendTOTPEnrolled(ctx, ctx.Doer); err != nil {
|
|
ctx.ServerError("SendTOTPEnrolled", err)
|
|
return
|
|
}
|
|
|
|
if err := auth.NewTwoFactor(ctx, twoFactor, secret); err != nil {
|
|
// FIXME: We need to handle a unique constraint fail here it's entirely possible that another request has beaten us.
|
|
// If there is a unique constraint fail we should just tolerate the error
|
|
ctx.ServerError("SettingsTwoFactor: Failed to save two factor", err)
|
|
return
|
|
}
|
|
|
|
ctx.Flash.Success(ctx.Tr("settings.twofa_enrolled", token))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
}
|
|
|
|
// ReenrollTwoFactor shows the page where the user can reenroll 2FA.
|
|
func ReenrollTwoFactor(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("settings")
|
|
ctx.Data["PageIsSettingsSecurity"] = true
|
|
ctx.Data["ReenrollTwofa"] = true
|
|
|
|
_, err := auth.GetTwoFactorByUID(ctx, ctx.Doer.ID)
|
|
if auth.IsErrTwoFactorNotEnrolled(err) {
|
|
ctx.Flash.Error(ctx.Tr("settings.twofa_not_enrolled"))
|
|
ctx.Redirect(setting.AppSubURL + "/user/settings/security")
|
|
return
|
|
}
|
|
if err != nil {
|
|
ctx.ServerError("SettingsTwoFactor: GetTwoFactorByUID", err)
|
|
return
|
|
}
|
|
|
|
if !twofaGenerateSecretAndQr(ctx) {
|
|
return
|
|
}
|
|
|
|
ctx.HTML(http.StatusOK, tplSettingsTwofaEnroll)
|
|
}
|
|
|
|
// ReenrollTwoFactorPost handles reenrolling the user 2FA.
|
|
func ReenrollTwoFactorPost(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("settings")
|
|
ctx.Data["PageIsSettingsSecurity"] = true
|
|
ctx.Data["ReenrollTwofa"] = true
|
|
|
|
disableTwoFactor(ctx)
|
|
if ctx.Written() {
|
|
return
|
|
}
|
|
|
|
enrollTwoFactor(ctx)
|
|
}
|