mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-25 03:22:36 +00:00 
			
		
		
		
	The tests on migration tests failed but CI reports successfully https://github.com/go-gitea/gitea/actions/runs/7364373807/job/20044685969#step:8:141 This PR will fix the bug on migration v283 and also the CI hidden behaviour. The reason is on the Makefile `GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test $(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(MIGRATE_TEST_PACKAGES)` will return the error exit code. But `for pkg in $(shell $(GO) list code.gitea.io/gitea/models/migrations/...); do \ GITEA_ROOT="$(CURDIR)" GITEA_CONF=tests/mysql.ini $(GO) test $(GOTESTFLAGS) -tags '$(TEST_TAGS)' $$pkg; \ done` will not work. This also fix #29602 (cherry picked from commit 45277486c2c6213b7766b1da708a991cdb1f3565) Conflicts: .github/workflows/pull-db-tests.yml Makefile models/migrations/v1_22/v283.go models/migrations/v1_22/v286_test.go models/migrations/v1_22/v287_test.go already in Forgejo for the Makefile & CI logic but Gitea changes otherwise rule
		
			
				
	
	
		
			118 lines
		
	
	
	
		
			2.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			118 lines
		
	
	
	
		
			2.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2023 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package v1_22 //nolint
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models/migrations/base"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| 	"xorm.io/xorm"
 | |
| )
 | |
| 
 | |
| func PrepareOldRepository(t *testing.T) (*xorm.Engine, func()) {
 | |
| 	type Repository struct { // old struct
 | |
| 		ID int64 `xorm:"pk autoincr"`
 | |
| 	}
 | |
| 
 | |
| 	type CommitStatus struct {
 | |
| 		ID          int64
 | |
| 		ContextHash string
 | |
| 	}
 | |
| 
 | |
| 	type RepoArchiver struct {
 | |
| 		ID       int64
 | |
| 		RepoID   int64
 | |
| 		Type     int
 | |
| 		CommitID string
 | |
| 	}
 | |
| 
 | |
| 	type ReviewState struct {
 | |
| 		ID        int64
 | |
| 		CommitSHA string
 | |
| 		UserID    int64
 | |
| 		PullID    int64
 | |
| 	}
 | |
| 
 | |
| 	type Comment struct {
 | |
| 		ID        int64
 | |
| 		CommitSHA string
 | |
| 	}
 | |
| 
 | |
| 	type PullRequest struct {
 | |
| 		ID             int64
 | |
| 		CommitSHA      string
 | |
| 		MergeBase      string
 | |
| 		MergedCommitID string
 | |
| 	}
 | |
| 
 | |
| 	type Release struct {
 | |
| 		ID   int64
 | |
| 		Sha1 string
 | |
| 	}
 | |
| 
 | |
| 	type RepoIndexerStatus struct {
 | |
| 		ID        int64
 | |
| 		CommitSHA string
 | |
| 	}
 | |
| 
 | |
| 	type Review struct {
 | |
| 		ID       int64
 | |
| 		CommitID string
 | |
| 	}
 | |
| 
 | |
| 	// Prepare and load the testing database
 | |
| 	return base.PrepareTestEnv(t, 0,
 | |
| 		new(Repository),
 | |
| 		new(CommitStatus),
 | |
| 		new(RepoArchiver),
 | |
| 		new(ReviewState),
 | |
| 		new(Review),
 | |
| 		new(Comment),
 | |
| 		new(PullRequest),
 | |
| 		new(Release),
 | |
| 		new(RepoIndexerStatus),
 | |
| 	)
 | |
| }
 | |
| 
 | |
| func Test_RepositoryFormat(t *testing.T) {
 | |
| 	x, deferable := PrepareOldRepository(t)
 | |
| 	defer deferable()
 | |
| 
 | |
| 	assert.NoError(t, AdjustDBForSha256(x))
 | |
| 
 | |
| 	type Repository struct {
 | |
| 		ID               int64  `xorm:"pk autoincr"`
 | |
| 		ObjectFormatName string `xorg:"not null default('sha1')"`
 | |
| 	}
 | |
| 
 | |
| 	repo := new(Repository)
 | |
| 
 | |
| 	// check we have some records to migrate
 | |
| 	count, err := x.Count(new(Repository))
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.EqualValues(t, 4, count)
 | |
| 
 | |
| 	repo.ObjectFormatName = "sha256"
 | |
| 	_, err = x.Insert(repo)
 | |
| 	assert.NoError(t, err)
 | |
| 	id := repo.ID
 | |
| 
 | |
| 	count, err = x.Count(new(Repository))
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.EqualValues(t, 5, count)
 | |
| 
 | |
| 	repo = new(Repository)
 | |
| 	ok, err := x.ID(2).Get(repo)
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.EqualValues(t, true, ok)
 | |
| 	assert.EqualValues(t, "sha1", repo.ObjectFormatName)
 | |
| 
 | |
| 	repo = new(Repository)
 | |
| 	ok, err = x.ID(id).Get(repo)
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.EqualValues(t, true, ok)
 | |
| 	assert.EqualValues(t, "sha256", repo.ObjectFormatName)
 | |
| }
 |