mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-08-21 09:51:10 +00:00
da9bedc967
When running relative-time tests on my local system, the tests fail. I've verified this failure does occur when the local system time is configured to use these timezones: - America/Edmonton - America/Boise - America/Goose Bay But the tests pass if the local system time is in these timezones: - America/Phoenix (has no DST) - Europe/Berlin (different DST rules) "7 months ago" (the existing test case output) is accurate considering the offsets used in the test, but internally dayjs calculates it to be 7.99 months when the system TZ is in the "success" TZs, and 8.0001 months in the "failure" TZs. I believe the source of the difference is that... - dayjs takes timestamps with offsets, applies the offset, and then treats them as local times... - Summer Time ended on Oct 27 (the "now" date under test) in Europe, but did not end until November 3rd in the US/Canada... - In Europe there would have been one hour less between those local timestamps than there would be in US/Canada. My proposed fix is to perform the diff calculations after converting the timestamps to UTC values. This provides consistent successful output regardless of the local system TZ. As the tests are sensitive to system timezone, I've modified the CI build to run the frontend tests twice with two different TZ environment variables. This is a pretty coarse way to exercise the problem and I'm open to improvements. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8858 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net> |
||
|---|---|---|
| .. | ||
| absolute-date.js | ||
| absolute-date.test.js | ||
| index.js | ||
| lazy-webc.js | ||
| origin-url.js | ||
| origin-url.test.js | ||
| overflow-menu.js | ||
| pdf-object.js | ||
| README.md | ||
| relative-time.js | ||
| relative-time.test.js | ||
Web Components
This webcomponents directory contains the source code for the web components used in the Gitea Web UI.
https://developer.mozilla.org/en-US/docs/Web/Web_Components
Guidelines
- These components are loaded in
<head>(before DOM body) in a separate entry point, they need to be lightweight to not affect the page loading time too much. - Do not import
svg.jsinto a web component because that file is currently not tree-shakeable, import svg files individually insteat. - All our components must be added to
webpack.config.jsso they work correctly in Vue.