mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-11-04 00:11:04 +00:00 
			
		
		
		
	`models` does far too much. In particular it handles all `UserSignin`. It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in. Therefore we should move this code out of `models`. This code has to depend on `models` - therefore it belongs in `services`. There is a package in `services` called `auth` and clearly this functionality belongs in there. Plan: - [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication. - [x] Move `models.UserSignIn` into `auth` - [x] Move `models.ExternalUserLogin` - [x] Move most of the `LoginVia*` methods to `auth` or subpackages - [x] Move Resynchronize functionality to `auth` - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files. - [x] Move the rest of the LDAP functionality in to the ldap subpackage - [x] Re-factor the login sources to express an interfaces `auth.Source`? - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future - [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable - [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2 - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models. - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 - [x] More simplifications of login_source.go may need to be done - Allow wiring in of notify registration - *this can now easily be done - but I think we should do it in another PR* - see #16178 - More refactors...? - OpenID should probably become an auth Method but I think that can be left for another PR - Methods should also probably be cleaned up - again another PR I think. - SSPI still needs more refactors.* Rename auth.Auth auth.Method * Restructure ssh_key.go - move functions from models/user.go that relate to ssh_key to ssh_key - split ssh_key.go to try create clearer function domains for allow for future refactors here. Signed-off-by: Andrew Thornton <art27@cantab.net>
		
			
				
	
	
		
			140 lines
		
	
	
	
		
			3.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			140 lines
		
	
	
	
		
			3.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2020 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package cron
 | 
						|
 | 
						|
import (
 | 
						|
	"context"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models"
 | 
						|
	"code.gitea.io/gitea/modules/migrations"
 | 
						|
	repository_service "code.gitea.io/gitea/modules/repository"
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
	"code.gitea.io/gitea/services/auth"
 | 
						|
	mirror_service "code.gitea.io/gitea/services/mirror"
 | 
						|
)
 | 
						|
 | 
						|
func registerUpdateMirrorTask() {
 | 
						|
	RegisterTaskFatal("update_mirrors", &BaseConfig{
 | 
						|
		Enabled:         true,
 | 
						|
		RunAtStart:      false,
 | 
						|
		Schedule:        "@every 10m",
 | 
						|
		NoSuccessNotice: true,
 | 
						|
	}, func(ctx context.Context, _ *models.User, _ Config) error {
 | 
						|
		return mirror_service.Update(ctx)
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func registerRepoHealthCheck() {
 | 
						|
	type RepoHealthCheckConfig struct {
 | 
						|
		BaseConfig
 | 
						|
		Timeout time.Duration
 | 
						|
		Args    []string `delim:" "`
 | 
						|
	}
 | 
						|
	RegisterTaskFatal("repo_health_check", &RepoHealthCheckConfig{
 | 
						|
		BaseConfig: BaseConfig{
 | 
						|
			Enabled:    true,
 | 
						|
			RunAtStart: false,
 | 
						|
			Schedule:   "@midnight",
 | 
						|
		},
 | 
						|
		Timeout: 60 * time.Second,
 | 
						|
		Args:    []string{},
 | 
						|
	}, func(ctx context.Context, _ *models.User, config Config) error {
 | 
						|
		rhcConfig := config.(*RepoHealthCheckConfig)
 | 
						|
		return repository_service.GitFsck(ctx, rhcConfig.Timeout, rhcConfig.Args)
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func registerCheckRepoStats() {
 | 
						|
	RegisterTaskFatal("check_repo_stats", &BaseConfig{
 | 
						|
		Enabled:    true,
 | 
						|
		RunAtStart: true,
 | 
						|
		Schedule:   "@midnight",
 | 
						|
	}, func(ctx context.Context, _ *models.User, _ Config) error {
 | 
						|
		return models.CheckRepoStats(ctx)
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func registerArchiveCleanup() {
 | 
						|
	RegisterTaskFatal("archive_cleanup", &OlderThanConfig{
 | 
						|
		BaseConfig: BaseConfig{
 | 
						|
			Enabled:    true,
 | 
						|
			RunAtStart: true,
 | 
						|
			Schedule:   "@midnight",
 | 
						|
		},
 | 
						|
		OlderThan: 24 * time.Hour,
 | 
						|
	}, func(ctx context.Context, _ *models.User, config Config) error {
 | 
						|
		acConfig := config.(*OlderThanConfig)
 | 
						|
		return models.DeleteOldRepositoryArchives(ctx, acConfig.OlderThan)
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func registerSyncExternalUsers() {
 | 
						|
	RegisterTaskFatal("sync_external_users", &UpdateExistingConfig{
 | 
						|
		BaseConfig: BaseConfig{
 | 
						|
			Enabled:    true,
 | 
						|
			RunAtStart: false,
 | 
						|
			Schedule:   "@midnight",
 | 
						|
		},
 | 
						|
		UpdateExisting: true,
 | 
						|
	}, func(ctx context.Context, _ *models.User, config Config) error {
 | 
						|
		realConfig := config.(*UpdateExistingConfig)
 | 
						|
		return auth.SyncExternalUsers(ctx, realConfig.UpdateExisting)
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func registerDeletedBranchesCleanup() {
 | 
						|
	RegisterTaskFatal("deleted_branches_cleanup", &OlderThanConfig{
 | 
						|
		BaseConfig: BaseConfig{
 | 
						|
			Enabled:    true,
 | 
						|
			RunAtStart: true,
 | 
						|
			Schedule:   "@midnight",
 | 
						|
		},
 | 
						|
		OlderThan: 24 * time.Hour,
 | 
						|
	}, func(ctx context.Context, _ *models.User, config Config) error {
 | 
						|
		realConfig := config.(*OlderThanConfig)
 | 
						|
		models.RemoveOldDeletedBranches(ctx, realConfig.OlderThan)
 | 
						|
		return nil
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func registerUpdateMigrationPosterID() {
 | 
						|
	RegisterTaskFatal("update_migration_poster_id", &BaseConfig{
 | 
						|
		Enabled:    true,
 | 
						|
		RunAtStart: true,
 | 
						|
		Schedule:   "@midnight",
 | 
						|
	}, func(ctx context.Context, _ *models.User, _ Config) error {
 | 
						|
		return migrations.UpdateMigrationPosterID(ctx)
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func registerCleanupHookTaskTable() {
 | 
						|
	RegisterTaskFatal("cleanup_hook_task_table", &CleanupHookTaskConfig{
 | 
						|
		BaseConfig: BaseConfig{
 | 
						|
			Enabled:    true,
 | 
						|
			RunAtStart: false,
 | 
						|
			Schedule:   "@midnight",
 | 
						|
		},
 | 
						|
		CleanupType:  "OlderThan",
 | 
						|
		OlderThan:    168 * time.Hour,
 | 
						|
		NumberToKeep: 10,
 | 
						|
	}, func(ctx context.Context, _ *models.User, config Config) error {
 | 
						|
		realConfig := config.(*CleanupHookTaskConfig)
 | 
						|
		return models.CleanupHookTaskTable(ctx, models.ToHookTaskCleanupType(realConfig.CleanupType), realConfig.OlderThan, realConfig.NumberToKeep)
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func initBasicTasks() {
 | 
						|
	registerUpdateMirrorTask()
 | 
						|
	registerRepoHealthCheck()
 | 
						|
	registerCheckRepoStats()
 | 
						|
	registerArchiveCleanup()
 | 
						|
	registerSyncExternalUsers()
 | 
						|
	registerDeletedBranchesCleanup()
 | 
						|
	if !setting.Repository.DisableMigrations {
 | 
						|
		registerUpdateMigrationPosterID()
 | 
						|
	}
 | 
						|
	registerCleanupHookTaskTable()
 | 
						|
}
 |