mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-25 03:22:36 +00:00 
			
		
		
		
	Fixes: https://github.com/go-gitea/gitea/issues/30384 On repo settings page, there id `repo_name` was used 5 times on the same page, some in modal and such. I think we are better off just auto-generating these IDs in the future so that labels link up with their form element. Ideally this id generation would be done in backend in a subtemplate, but seeing that we already have similar JS patches for checkboxes, I took the easy path for now. I also checked that these `#repo_name` were not in use in JS and the only case where this id appears in JS is on the migration page where it's still there. --------- Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b) Conflicts: - templates/repo/settings/options.tmpl Conflict resolved by manually removing all `id` and `for` attributes from elements that had `repo_name` as their id.
		
			
				
	
	
		
			13 lines
		
	
	
	
		
			526 B
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			13 lines
		
	
	
	
		
			526 B
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| import {linkLabelAndInput} from './base.js';
 | |
| 
 | |
| export function initAriaFormFieldPatch() {
 | |
|   // link the label and the input element so it's clickable and accessible
 | |
|   for (const el of document.querySelectorAll('.ui.form .field')) {
 | |
|     if (el.hasAttribute('data-field-patched')) continue;
 | |
|     const label = el.querySelector(':scope > label');
 | |
|     const input = el.querySelector(':scope > input');
 | |
|     if (!label || !input) continue;
 | |
|     linkLabelAndInput(label, input);
 | |
|     el.setAttribute('data-field-patched', 'true');
 | |
|   }
 | |
| }
 |