mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-30 22:11:07 +00:00 
			
		
		
		
	If a repository has git config --add push.pushOption submit=".sourcehut/*.yml" it failed when pushed because of the unknown submit push option. It will be ignored instead. Filtering out the push options is done in an earlier stage, when the hook command runs, before it submits the options map to the private endpoint. * move all the push options logic to modules/git/pushoptions * add 100% test coverage for modules/git/pushoptions Test coverage for the code paths from which code was moved to the modules/git/pushoptions package: * cmd/hook.go:runHookPreReceive * routers/private/hook_pre_receive.go:validatePushOptions tests/integration/git_push_test.go:TestOptionsGitPush runs through both. The test verifying the option is rejected was removed and, if added again, will fail because the option is now ignored instead of being rejected. * cmd/hook.go:runHookProcReceive * services/agit/agit.go:ProcReceive tests/integration/git_test.go: doCreateAgitFlowPull runs through both. It uses variations of AGit related push options. * cmd/hook.go:runHookPostReceive * routers/private/hook_post_receive.go:HookPostReceive tests/integration/git_test.go:doPushCreate called by TestGit/HTTP/sha1/PushCreate runs through both. Note that although it provides coverage for this code path it does not use push options. Fixes: https://codeberg.org/forgejo/forgejo/issues/3651
		
			
				
	
	
		
			129 lines
		
	
	
	
		
			4.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			129 lines
		
	
	
	
		
			4.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package private
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"net/url"
 | |
| 	"time"
 | |
| 
 | |
| 	"code.gitea.io/gitea/modules/git"
 | |
| 	"code.gitea.io/gitea/modules/git/pushoptions"
 | |
| 	"code.gitea.io/gitea/modules/repository"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| )
 | |
| 
 | |
| // Git environment variables
 | |
| const (
 | |
| 	GitAlternativeObjectDirectories = "GIT_ALTERNATE_OBJECT_DIRECTORIES"
 | |
| 	GitObjectDirectory              = "GIT_OBJECT_DIRECTORY"
 | |
| 	GitQuarantinePath               = "GIT_QUARANTINE_PATH"
 | |
| )
 | |
| 
 | |
| // HookOptions represents the options for the Hook calls
 | |
| type HookOptions struct {
 | |
| 	OldCommitIDs                    []string
 | |
| 	NewCommitIDs                    []string
 | |
| 	RefFullNames                    []git.RefName
 | |
| 	UserID                          int64
 | |
| 	UserName                        string
 | |
| 	GitObjectDirectory              string
 | |
| 	GitAlternativeObjectDirectories string
 | |
| 	GitQuarantinePath               string
 | |
| 	GitPushOptions                  map[string]string
 | |
| 	PullRequestID                   int64
 | |
| 	PushTrigger                     repository.PushTrigger
 | |
| 	DeployKeyID                     int64 // if the pusher is a DeployKey, then UserID is the repo's org user.
 | |
| 	IsWiki                          bool
 | |
| 	ActionPerm                      int
 | |
| }
 | |
| 
 | |
| func (o *HookOptions) GetGitPushOptions() pushoptions.Interface {
 | |
| 	return pushoptions.NewFromMap(&o.GitPushOptions)
 | |
| }
 | |
| 
 | |
| // SSHLogOption ssh log options
 | |
| type SSHLogOption struct {
 | |
| 	IsError bool
 | |
| 	Message string
 | |
| }
 | |
| 
 | |
| // HookPostReceiveResult represents an individual result from PostReceive
 | |
| type HookPostReceiveResult struct {
 | |
| 	Results      []HookPostReceiveBranchResult
 | |
| 	RepoWasEmpty bool
 | |
| 	Err          string
 | |
| }
 | |
| 
 | |
| // HookPostReceiveBranchResult represents an individual branch result from PostReceive
 | |
| type HookPostReceiveBranchResult struct {
 | |
| 	Message bool
 | |
| 	Create  bool
 | |
| 	Branch  string
 | |
| 	URL     string
 | |
| }
 | |
| 
 | |
| // HookProcReceiveResult represents an individual result from ProcReceive
 | |
| type HookProcReceiveResult struct {
 | |
| 	Results []HookProcReceiveRefResult
 | |
| 	Err     string
 | |
| }
 | |
| 
 | |
| // HookProcReceiveRefResult represents an individual result from ProcReceive
 | |
| type HookProcReceiveRefResult struct {
 | |
| 	OldOID       string
 | |
| 	NewOID       string
 | |
| 	Ref          string
 | |
| 	OriginalRef  git.RefName
 | |
| 	IsForcePush  bool
 | |
| 	IsNotMatched bool
 | |
| 	Err          string
 | |
| }
 | |
| 
 | |
| // HookPreReceive check whether the provided commits are allowed
 | |
| func HookPreReceive(ctx context.Context, ownerName, repoName string, opts HookOptions) ResponseExtra {
 | |
| 	reqURL := setting.LocalURL + fmt.Sprintf("api/internal/hook/pre-receive/%s/%s", url.PathEscape(ownerName), url.PathEscape(repoName))
 | |
| 	req := newInternalRequest(ctx, reqURL, "POST", opts)
 | |
| 	req.SetReadWriteTimeout(time.Duration(60+len(opts.OldCommitIDs)) * time.Second)
 | |
| 	_, extra := requestJSONResp(req, &ResponseText{})
 | |
| 	return extra
 | |
| }
 | |
| 
 | |
| // HookPostReceive updates services and users
 | |
| func HookPostReceive(ctx context.Context, ownerName, repoName string, opts HookOptions) (*HookPostReceiveResult, ResponseExtra) {
 | |
| 	reqURL := setting.LocalURL + fmt.Sprintf("api/internal/hook/post-receive/%s/%s", url.PathEscape(ownerName), url.PathEscape(repoName))
 | |
| 	req := newInternalRequest(ctx, reqURL, "POST", opts)
 | |
| 	req.SetReadWriteTimeout(time.Duration(60+len(opts.OldCommitIDs)) * time.Second)
 | |
| 	return requestJSONResp(req, &HookPostReceiveResult{})
 | |
| }
 | |
| 
 | |
| // HookProcReceive proc-receive hook
 | |
| func HookProcReceive(ctx context.Context, ownerName, repoName string, opts HookOptions) (*HookProcReceiveResult, ResponseExtra) {
 | |
| 	reqURL := setting.LocalURL + fmt.Sprintf("api/internal/hook/proc-receive/%s/%s", url.PathEscape(ownerName), url.PathEscape(repoName))
 | |
| 
 | |
| 	req := newInternalRequest(ctx, reqURL, "POST", opts)
 | |
| 	req.SetReadWriteTimeout(time.Duration(60+len(opts.OldCommitIDs)) * time.Second)
 | |
| 	return requestJSONResp(req, &HookProcReceiveResult{})
 | |
| }
 | |
| 
 | |
| // SetDefaultBranch will set the default branch to the provided branch for the provided repository
 | |
| func SetDefaultBranch(ctx context.Context, ownerName, repoName, branch string) ResponseExtra {
 | |
| 	reqURL := setting.LocalURL + fmt.Sprintf("api/internal/hook/set-default-branch/%s/%s/%s",
 | |
| 		url.PathEscape(ownerName),
 | |
| 		url.PathEscape(repoName),
 | |
| 		url.PathEscape(branch),
 | |
| 	)
 | |
| 	req := newInternalRequest(ctx, reqURL, "POST")
 | |
| 	_, extra := requestJSONResp(req, &ResponseText{})
 | |
| 	return extra
 | |
| }
 | |
| 
 | |
| // SSHLog sends ssh error log response
 | |
| func SSHLog(ctx context.Context, isErr bool, msg string) error {
 | |
| 	reqURL := setting.LocalURL + "api/internal/ssh/log"
 | |
| 	req := newInternalRequest(ctx, reqURL, "POST", &SSHLogOption{IsError: isErr, Message: msg})
 | |
| 	_, extra := requestJSONResp(req, &ResponseText{})
 | |
| 	return extra.Error
 | |
| }
 |