mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 14:31:02 +00:00 
			
		
		
		
	This PR depends on https://codeberg.org/forgejo/forgejo/pulls/7510 This PR renames UpdateRunJob to UpdateRunJobWithoutNotification and UpdateRun to UpdateRunWithoutNotification and implements wrapper functions that also call the new ActionRunNowDone notification when needed. This PR can be reviewed commit-by-commit. # Things to Test - [x] GetRunBefore - [ ] integration test for sendActionRunNowDoneNotificationIfNeeded, UpdateRun and UpdateRunJob ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Co-authored-by: nobody <nobody@example.com> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7491 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: christopher-besch <mail@chris-besch.com> Co-committed-by: christopher-besch <mail@chris-besch.com>
		
			
				
	
	
		
			218 lines
		
	
	
	
		
			9.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			218 lines
		
	
	
	
		
			9.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package notify
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 
 | |
| 	actions_model "forgejo.org/models/actions"
 | |
| 	issues_model "forgejo.org/models/issues"
 | |
| 	packages_model "forgejo.org/models/packages"
 | |
| 	repo_model "forgejo.org/models/repo"
 | |
| 	user_model "forgejo.org/models/user"
 | |
| 	"forgejo.org/modules/git"
 | |
| 	"forgejo.org/modules/repository"
 | |
| )
 | |
| 
 | |
| // NullNotifier implements a blank notifier
 | |
| type NullNotifier struct{}
 | |
| 
 | |
| var _ Notifier = &NullNotifier{}
 | |
| 
 | |
| // Run places a place holder function
 | |
| func (*NullNotifier) Run() {
 | |
| }
 | |
| 
 | |
| // CreateIssueComment places a place holder function
 | |
| func (*NullNotifier) CreateIssueComment(ctx context.Context, doer *user_model.User, repo *repo_model.Repository,
 | |
| 	issue *issues_model.Issue, comment *issues_model.Comment, mentions []*user_model.User) {
 | |
| }
 | |
| 
 | |
| // NewIssue places a place holder function
 | |
| func (*NullNotifier) NewIssue(ctx context.Context, issue *issues_model.Issue, mentions []*user_model.User) {
 | |
| }
 | |
| 
 | |
| // IssueChangeStatus places a place holder function
 | |
| func (*NullNotifier) IssueChangeStatus(ctx context.Context, doer *user_model.User, commitID string, issue *issues_model.Issue, actionComment *issues_model.Comment, isClosed bool) {
 | |
| }
 | |
| 
 | |
| // DeleteIssue notify when some issue deleted
 | |
| func (*NullNotifier) DeleteIssue(ctx context.Context, doer *user_model.User, issue *issues_model.Issue) {
 | |
| }
 | |
| 
 | |
| // NewPullRequest places a place holder function
 | |
| func (*NullNotifier) NewPullRequest(ctx context.Context, pr *issues_model.PullRequest, mentions []*user_model.User) {
 | |
| }
 | |
| 
 | |
| // PullRequestReview places a place holder function
 | |
| func (*NullNotifier) PullRequestReview(ctx context.Context, pr *issues_model.PullRequest, r *issues_model.Review, comment *issues_model.Comment, mentions []*user_model.User) {
 | |
| }
 | |
| 
 | |
| // PullRequestCodeComment places a place holder function
 | |
| func (*NullNotifier) PullRequestCodeComment(ctx context.Context, pr *issues_model.PullRequest, comment *issues_model.Comment, mentions []*user_model.User) {
 | |
| }
 | |
| 
 | |
| // MergePullRequest places a place holder function
 | |
| func (*NullNotifier) MergePullRequest(ctx context.Context, doer *user_model.User, pr *issues_model.PullRequest) {
 | |
| }
 | |
| 
 | |
| // AutoMergePullRequest places a place holder function
 | |
| func (*NullNotifier) AutoMergePullRequest(ctx context.Context, doer *user_model.User, pr *issues_model.PullRequest) {
 | |
| }
 | |
| 
 | |
| // PullRequestSynchronized places a place holder function
 | |
| func (*NullNotifier) PullRequestSynchronized(ctx context.Context, doer *user_model.User, pr *issues_model.PullRequest) {
 | |
| }
 | |
| 
 | |
| // PullRequestChangeTargetBranch places a place holder function
 | |
| func (*NullNotifier) PullRequestChangeTargetBranch(ctx context.Context, doer *user_model.User, pr *issues_model.PullRequest, oldBranch string) {
 | |
| }
 | |
| 
 | |
| // PullRequestPushCommits notifies when push commits to pull request's head branch
 | |
| func (*NullNotifier) PullRequestPushCommits(ctx context.Context, doer *user_model.User, pr *issues_model.PullRequest, comment *issues_model.Comment) {
 | |
| }
 | |
| 
 | |
| // PullReviewDismiss notifies when a review was dismissed by repo admin
 | |
| func (*NullNotifier) PullReviewDismiss(ctx context.Context, doer *user_model.User, review *issues_model.Review, comment *issues_model.Comment) {
 | |
| }
 | |
| 
 | |
| // UpdateComment places a place holder function
 | |
| func (*NullNotifier) UpdateComment(ctx context.Context, doer *user_model.User, c *issues_model.Comment, oldContent string) {
 | |
| }
 | |
| 
 | |
| // DeleteComment places a place holder function
 | |
| func (*NullNotifier) DeleteComment(ctx context.Context, doer *user_model.User, c *issues_model.Comment) {
 | |
| }
 | |
| 
 | |
| // NewWikiPage places a place holder function
 | |
| func (*NullNotifier) NewWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, page, comment string) {
 | |
| }
 | |
| 
 | |
| // EditWikiPage places a place holder function
 | |
| func (*NullNotifier) EditWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, page, comment string) {
 | |
| }
 | |
| 
 | |
| // DeleteWikiPage places a place holder function
 | |
| func (*NullNotifier) DeleteWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, page string) {
 | |
| }
 | |
| 
 | |
| // NewRelease places a place holder function
 | |
| func (*NullNotifier) NewRelease(ctx context.Context, rel *repo_model.Release) {
 | |
| }
 | |
| 
 | |
| // UpdateRelease places a place holder function
 | |
| func (*NullNotifier) UpdateRelease(ctx context.Context, doer *user_model.User, rel *repo_model.Release) {
 | |
| }
 | |
| 
 | |
| // DeleteRelease places a place holder function
 | |
| func (*NullNotifier) DeleteRelease(ctx context.Context, doer *user_model.User, rel *repo_model.Release) {
 | |
| }
 | |
| 
 | |
| // IssueChangeMilestone places a place holder function
 | |
| func (*NullNotifier) IssueChangeMilestone(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, oldMilestoneID int64) {
 | |
| }
 | |
| 
 | |
| // IssueChangeContent places a place holder function
 | |
| func (*NullNotifier) IssueChangeContent(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, oldContent string) {
 | |
| }
 | |
| 
 | |
| // IssueChangeAssignee places a place holder function
 | |
| func (*NullNotifier) IssueChangeAssignee(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, assignee *user_model.User, removed bool, comment *issues_model.Comment) {
 | |
| }
 | |
| 
 | |
| // PullRequestReviewRequest places a place holder function
 | |
| func (*NullNotifier) PullRequestReviewRequest(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, reviewer *user_model.User, isRequest bool, comment *issues_model.Comment) {
 | |
| }
 | |
| 
 | |
| // IssueClearLabels places a place holder function
 | |
| func (*NullNotifier) IssueClearLabels(ctx context.Context, doer *user_model.User, issue *issues_model.Issue) {
 | |
| }
 | |
| 
 | |
| // IssueChangeTitle places a place holder function
 | |
| func (*NullNotifier) IssueChangeTitle(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, oldTitle string) {
 | |
| }
 | |
| 
 | |
| // IssueChangeRef places a place holder function
 | |
| func (*NullNotifier) IssueChangeRef(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, oldTitle string) {
 | |
| }
 | |
| 
 | |
| // IssueChangeLabels places a place holder function
 | |
| func (*NullNotifier) IssueChangeLabels(ctx context.Context, doer *user_model.User, issue *issues_model.Issue,
 | |
| 	addedLabels, removedLabels []*issues_model.Label) {
 | |
| }
 | |
| 
 | |
| // CreateRepository places a place holder function
 | |
| func (*NullNotifier) CreateRepository(ctx context.Context, doer, u *user_model.User, repo *repo_model.Repository) {
 | |
| }
 | |
| 
 | |
| // AdoptRepository places a place holder function
 | |
| func (*NullNotifier) AdoptRepository(ctx context.Context, doer, u *user_model.User, repo *repo_model.Repository) {
 | |
| }
 | |
| 
 | |
| // DeleteRepository places a place holder function
 | |
| func (*NullNotifier) DeleteRepository(ctx context.Context, doer *user_model.User, repo *repo_model.Repository) {
 | |
| }
 | |
| 
 | |
| // ForkRepository places a place holder function
 | |
| func (*NullNotifier) ForkRepository(ctx context.Context, doer *user_model.User, oldRepo, repo *repo_model.Repository) {
 | |
| }
 | |
| 
 | |
| // MigrateRepository places a place holder function
 | |
| func (*NullNotifier) MigrateRepository(ctx context.Context, doer, u *user_model.User, repo *repo_model.Repository) {
 | |
| }
 | |
| 
 | |
| // PushCommits notifies commits pushed to notifiers
 | |
| func (*NullNotifier) PushCommits(ctx context.Context, pusher *user_model.User, repo *repo_model.Repository, opts *repository.PushUpdateOptions, commits *repository.PushCommits) {
 | |
| }
 | |
| 
 | |
| // CreateRef notifies branch or tag creation to notifiers
 | |
| func (*NullNotifier) CreateRef(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, refFullName git.RefName, refID string) {
 | |
| }
 | |
| 
 | |
| // DeleteRef notifies branch or tag deletion to notifiers
 | |
| func (*NullNotifier) DeleteRef(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, refFullName git.RefName) {
 | |
| }
 | |
| 
 | |
| // RenameRepository places a place holder function
 | |
| func (*NullNotifier) RenameRepository(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, oldRepoName string) {
 | |
| }
 | |
| 
 | |
| // TransferRepository places a place holder function
 | |
| func (*NullNotifier) TransferRepository(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, oldOwnerName string) {
 | |
| }
 | |
| 
 | |
| // SyncPushCommits places a place holder function
 | |
| func (*NullNotifier) SyncPushCommits(ctx context.Context, pusher *user_model.User, repo *repo_model.Repository, opts *repository.PushUpdateOptions, commits *repository.PushCommits) {
 | |
| }
 | |
| 
 | |
| // SyncCreateRef places a place holder function
 | |
| func (*NullNotifier) SyncCreateRef(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, refFullName git.RefName, refID string) {
 | |
| }
 | |
| 
 | |
| // SyncDeleteRef places a place holder function
 | |
| func (*NullNotifier) SyncDeleteRef(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, refFullName git.RefName) {
 | |
| }
 | |
| 
 | |
| // RepoPendingTransfer places a place holder function
 | |
| func (*NullNotifier) RepoPendingTransfer(ctx context.Context, doer, newOwner *user_model.User, repo *repo_model.Repository) {
 | |
| }
 | |
| 
 | |
| func (*NullNotifier) NewUserSignUp(ctx context.Context, newUser *user_model.User) {
 | |
| }
 | |
| 
 | |
| // PackageCreate places a place holder function
 | |
| func (*NullNotifier) PackageCreate(ctx context.Context, doer *user_model.User, pd *packages_model.PackageDescriptor) {
 | |
| }
 | |
| 
 | |
| // PackageDelete places a place holder function
 | |
| func (*NullNotifier) PackageDelete(ctx context.Context, doer *user_model.User, pd *packages_model.PackageDescriptor) {
 | |
| }
 | |
| 
 | |
| // ChangeDefaultBranch places a place holder function
 | |
| func (*NullNotifier) ChangeDefaultBranch(ctx context.Context, repo *repo_model.Repository) {
 | |
| }
 | |
| 
 | |
| // ActionRunNowDone places a place holder function
 | |
| func (*NullNotifier) ActionRunNowDone(ctx context.Context, run *actions_model.ActionRun, priorStatus actions_model.Status, lastRun *actions_model.ActionRun) {
 | |
| }
 |