mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-10-29 21:41:02 +00:00
- The current implementation for modals is provided by fomantic UI. - This patch introduces a new implementation that relies on the `<dialog>` element to provide modal, whereby the heavy lifting is done by the browser. - This implementation is considerably simpler, accessible (although untested) and lightweight. It is capable of replacing fomantic UI's modal implementation + our dimmer implementation (~2k lines of code and CSS).[^1] As a first step the empty content modal is migrated. - This brings in the CSS needed to display `<dialog>` and a helper function that hides some boilerplate code that's needed to show `<dialog>` as a modal. - Add a E2E test that shows the modal's cancel and approve button works. [^1]: The heavy work has already been done by me in a local branch, but reviewing that gigantic patch in one PR is not doable. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8859 Reviewed-by: 0ko <0ko@noreply.codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz> |
||
|---|---|---|
| .. | ||
| animations.css | ||
| breadcrumb.css | ||
| button.css | ||
| card.css | ||
| checkbox.css | ||
| comment.css | ||
| container.css | ||
| dialog.css | ||
| dimmer.css | ||
| divider.css | ||
| dropdown.css | ||
| flexcontainer.css | ||
| grid.css | ||
| hashbox.css | ||
| header.css | ||
| input.css | ||
| label.css | ||
| list.css | ||
| message.css | ||
| modal.css | ||
| navbar.css | ||
| normalize.css | ||
| segment.css | ||
| select.css | ||
| svg.css | ||
| switch.css | ||
| tab.css | ||
| table.css | ||
| tippy.css | ||
| toast.css | ||
| user-cards.css | ||