mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-11-04 00:11:04 +00:00 
			
		
		
		
	Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			141 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			141 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2017 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package validation
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"regexp"
 | 
						|
	"strings"
 | 
						|
 | 
						|
	"gitea.com/go-chi/binding"
 | 
						|
	"github.com/gobwas/glob"
 | 
						|
)
 | 
						|
 | 
						|
const (
 | 
						|
	// ErrGitRefName is git reference name error
 | 
						|
	ErrGitRefName = "GitRefNameError"
 | 
						|
 | 
						|
	// ErrGlobPattern is returned when glob pattern is invalid
 | 
						|
	ErrGlobPattern = "GlobPattern"
 | 
						|
)
 | 
						|
 | 
						|
var (
 | 
						|
	// GitRefNamePatternInvalid is regular expression with unallowed characters in git reference name
 | 
						|
	// They cannot have ASCII control characters (i.e. bytes whose values are lower than \040, or \177 DEL), space, tilde ~, caret ^, or colon : anywhere.
 | 
						|
	// They cannot have question-mark ?, asterisk *, or open bracket [ anywhere
 | 
						|
	GitRefNamePatternInvalid = regexp.MustCompile(`[\000-\037\177 \\~^:?*[]+`)
 | 
						|
)
 | 
						|
 | 
						|
// CheckGitRefAdditionalRulesValid check name is valid on additional rules
 | 
						|
func CheckGitRefAdditionalRulesValid(name string) bool {
 | 
						|
 | 
						|
	// Additional rules as described at https://www.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html
 | 
						|
	if strings.HasPrefix(name, "/") || strings.HasSuffix(name, "/") ||
 | 
						|
		strings.HasSuffix(name, ".") || strings.Contains(name, "..") ||
 | 
						|
		strings.Contains(name, "//") || strings.Contains(name, "@{") ||
 | 
						|
		name == "@" {
 | 
						|
		return false
 | 
						|
	}
 | 
						|
	parts := strings.Split(name, "/")
 | 
						|
	for _, part := range parts {
 | 
						|
		if strings.HasSuffix(part, ".lock") || strings.HasPrefix(part, ".") {
 | 
						|
			return false
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	return true
 | 
						|
}
 | 
						|
 | 
						|
// AddBindingRules adds additional binding rules
 | 
						|
func AddBindingRules() {
 | 
						|
	addGitRefNameBindingRule()
 | 
						|
	addValidURLBindingRule()
 | 
						|
	addGlobPatternRule()
 | 
						|
}
 | 
						|
 | 
						|
func addGitRefNameBindingRule() {
 | 
						|
	// Git refname validation rule
 | 
						|
	binding.AddRule(&binding.Rule{
 | 
						|
		IsMatch: func(rule string) bool {
 | 
						|
			return strings.HasPrefix(rule, "GitRefName")
 | 
						|
		},
 | 
						|
		IsValid: func(errs binding.Errors, name string, val interface{}) (bool, binding.Errors) {
 | 
						|
			str := fmt.Sprintf("%v", val)
 | 
						|
 | 
						|
			if GitRefNamePatternInvalid.MatchString(str) {
 | 
						|
				errs.Add([]string{name}, ErrGitRefName, "GitRefName")
 | 
						|
				return false, errs
 | 
						|
			}
 | 
						|
 | 
						|
			if !CheckGitRefAdditionalRulesValid(str) {
 | 
						|
				errs.Add([]string{name}, ErrGitRefName, "GitRefName")
 | 
						|
				return false, errs
 | 
						|
			}
 | 
						|
 | 
						|
			return true, errs
 | 
						|
		},
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func addValidURLBindingRule() {
 | 
						|
	// URL validation rule
 | 
						|
	binding.AddRule(&binding.Rule{
 | 
						|
		IsMatch: func(rule string) bool {
 | 
						|
			return strings.HasPrefix(rule, "ValidUrl")
 | 
						|
		},
 | 
						|
		IsValid: func(errs binding.Errors, name string, val interface{}) (bool, binding.Errors) {
 | 
						|
			str := fmt.Sprintf("%v", val)
 | 
						|
			if len(str) != 0 && !IsValidURL(str) {
 | 
						|
				errs.Add([]string{name}, binding.ERR_URL, "Url")
 | 
						|
				return false, errs
 | 
						|
			}
 | 
						|
 | 
						|
			return true, errs
 | 
						|
		},
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func addGlobPatternRule() {
 | 
						|
	binding.AddRule(&binding.Rule{
 | 
						|
		IsMatch: func(rule string) bool {
 | 
						|
			return rule == "GlobPattern"
 | 
						|
		},
 | 
						|
		IsValid: func(errs binding.Errors, name string, val interface{}) (bool, binding.Errors) {
 | 
						|
			str := fmt.Sprintf("%v", val)
 | 
						|
 | 
						|
			if len(str) != 0 {
 | 
						|
				if _, err := glob.Compile(str); err != nil {
 | 
						|
					errs.Add([]string{name}, ErrGlobPattern, err.Error())
 | 
						|
					return false, errs
 | 
						|
				}
 | 
						|
			}
 | 
						|
 | 
						|
			return true, errs
 | 
						|
		},
 | 
						|
	})
 | 
						|
}
 | 
						|
 | 
						|
func portOnly(hostport string) string {
 | 
						|
	colon := strings.IndexByte(hostport, ':')
 | 
						|
	if colon == -1 {
 | 
						|
		return ""
 | 
						|
	}
 | 
						|
	if i := strings.Index(hostport, "]:"); i != -1 {
 | 
						|
		return hostport[i+len("]:"):]
 | 
						|
	}
 | 
						|
	if strings.Contains(hostport, "]") {
 | 
						|
		return ""
 | 
						|
	}
 | 
						|
	return hostport[colon+len(":"):]
 | 
						|
}
 | 
						|
 | 
						|
func validPort(p string) bool {
 | 
						|
	for _, r := range []byte(p) {
 | 
						|
		if r < '0' || r > '9' {
 | 
						|
			return false
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return true
 | 
						|
}
 |