mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-10-31 14:31:02 +00:00
13b560c191
For the mailer and incoming_mailer config, allow passwords to be read from a file. Add `_URI` config values and use the existing `loadSecret` function to do this. Resolves https://codeberg.org/forgejo/forgejo/issues/8113 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8116 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org> Co-authored-by: fruzitent <fruzit@gmail.com> Co-committed-by: fruzitent <fruzit@gmail.com>
98 lines
2.4 KiB
Go
98 lines
2.4 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_loadMailerFrom(t *testing.T) {
|
|
kases := map[string]*Mailer{
|
|
"smtp.mydomain.com": {
|
|
SMTPAddr: "smtp.mydomain.com",
|
|
SMTPPort: "465",
|
|
},
|
|
"smtp.mydomain.com:123": {
|
|
SMTPAddr: "smtp.mydomain.com",
|
|
SMTPPort: "123",
|
|
},
|
|
":123": {
|
|
SMTPAddr: "127.0.0.1",
|
|
SMTPPort: "123",
|
|
},
|
|
}
|
|
for host, kase := range kases {
|
|
t.Run(host, func(t *testing.T) {
|
|
cfg, _ := NewConfigProviderFromData("")
|
|
sec := cfg.Section("mailer")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("HOST", host)
|
|
|
|
// Check mailer setting
|
|
loadMailerFrom(cfg)
|
|
|
|
assert.Equal(t, kase.SMTPAddr, MailService.SMTPAddr)
|
|
assert.Equal(t, kase.SMTPPort, MailService.SMTPPort)
|
|
})
|
|
}
|
|
|
|
t.Run("property aliases", func(t *testing.T) {
|
|
cfg, _ := NewConfigProviderFromData("")
|
|
sec := cfg.Section("mailer")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("USERNAME", "jane.doe@example.com")
|
|
sec.NewKey("PASSWORD", "y0u'll n3v3r gUess th1S!!1")
|
|
|
|
loadMailerFrom(cfg)
|
|
|
|
assert.Equal(t, "jane.doe@example.com", MailService.User)
|
|
assert.Equal(t, "y0u'll n3v3r gUess th1S!!1", MailService.Passwd)
|
|
})
|
|
|
|
t.Run("Secrets", func(t *testing.T) {
|
|
uri := filepath.Join(t.TempDir(), "mailer_passwd")
|
|
|
|
if err := os.WriteFile(uri, []byte("th1S gUess n3v3r y0u'll!!1"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
cfg, _ := NewConfigProviderFromData("")
|
|
sec := cfg.Section("mailer")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("PASSWD_URI", "file:"+uri)
|
|
|
|
MailService.Passwd = ""
|
|
loadMailerFrom(cfg)
|
|
|
|
assert.Equal(t, "th1S gUess n3v3r y0u'll!!1", MailService.Passwd)
|
|
})
|
|
|
|
t.Run("sendmail argument sanitization", func(t *testing.T) {
|
|
cfg, _ := NewConfigProviderFromData("")
|
|
sec := cfg.Section("mailer")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("PROTOCOL", "sendmail")
|
|
sec.NewKey("SENDMAIL_ARGS", "-B 8BITMIME")
|
|
|
|
loadMailerFrom(cfg)
|
|
|
|
assert.Equal(t, []string{"-B", "8BITMIME", "--"}, MailService.SendmailArgs)
|
|
})
|
|
|
|
t.Run("empty sendmail args", func(t *testing.T) {
|
|
cfg, _ := NewConfigProviderFromData("")
|
|
sec := cfg.Section("mailer")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("PROTOCOL", "sendmail")
|
|
sec.NewKey("SENDMAIL_ARGS", "")
|
|
|
|
loadMailerFrom(cfg)
|
|
|
|
assert.Equal(t, []string{"--"}, MailService.SendmailArgs)
|
|
})
|
|
}
|