mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-30 22:11:07 +00:00 
			
		
		
		
	urfave/cli v2 will eventually become unmaintained, switch over to v3 which is the latest supported version. Note: the `docs` command would be a lot of work to restore with v3 ([the package is still in alpha](https://github.com/urfave/cli-docs)) An alternative to avoid a breaking change would be to not upgrade from v2 to v3 for that reason alone. Note: these commits were cherry-picked from https://code.forgejo.org/forgefriends/forgefriends Note: it is best reviewed side by side with no display of whitespace changes (there are a lot of those when converting vars to func). - a few functional changes were necessary and are noted in context in the file changes tab - https://cli.urfave.org/migrate-v2-to-v3/ upgrade instructions were followed in the most minimal way possible - upgrade gof3 to v3.10.8 which includes and upgrade from urfave/cli v2 to urfave/cli v3 - upgrade gitlab.com/gitlab-org/api/client-go v0.129.0 because it is an indirect dependency of gof3 and requires a change because of a deprecated field that otherwise triggers a lint error but nothing else otherwise - verified that the [script](https://codeberg.org/forgejo/docs/src/branch/next/scripts/cli-docs.sh) that generates the [CLI documentation](https://codeberg.org/forgejo/docs/src/branch/next/scripts/cli-docs.sh) still works. There are cosmetic differences and the **help** subcommand is no longer advertised (although it is still supported) but the `--help` option is advertised as expected so it is fine. - end-to-end tests [passed](https://code.forgejo.org/forgejo/end-to-end/pulls/667) (they use the Forgejo CLI to some extent) ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [x] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Breaking features - [PR](https://codeberg.org/forgejo/forgejo/pulls/8035): <!--number 8035 --><!--line 0 --><!--description VGhlIGBmb3JnZWpvIGRvY3NgIGNvbW1hbmQgaXMgZGVwcmVjYXRlZCBhbmQgQ0xJIGVycm9ycyBhcmUgbm93IGRpc3BsYXllZCBvbiBzdGRlcnIgaW5zdGVhZCBvZiBzdGRvdXQuIFRoZXNlIGJyZWFraW5nIGNoYW5nZXMgaGFwcGVuZWQgYmVjYXVzZSB0aGUgcGFja2FnZSB1c2VkIHRvIHBhcnNlIHRoZSBjb21tYW5kIGxpbmUgYXJndW1lbnRzIHdhcyBbdXBncmFkZWQgZnJvbSB2MiB0byB2M10oaHR0cHM6Ly9jbGkudXJmYXZlLm9yZy9taWdyYXRlLXYyLXRvLXYzLykuIEEgW3NlcGFyYXRlIHByb2plY3Qgd2FzIGluaXRpYXRlZF0oaHR0cHM6Ly9naXRodWIuY29tL3VyZmF2ZS9jbGktZG9jcykgdG8gcmUtaW1wbGVtZW50IHRoZSBgZG9jc2AgY29tbWFuZCwgYnV0IGl0IGlzIG5vdCB5ZXQgcHJvZHVjdGlvbiByZWFkeS4=-->The `forgejo docs` command is deprecated and CLI errors are now displayed on stderr instead of stdout. These breaking changes happened because the package used to parse the command line arguments was [upgraded from v2 to v3](https://cli.urfave.org/migrate-v2-to-v3/). A [separate project was initiated](https://github.com/urfave/cli-docs) to re-implement the `docs` command, but it is not yet production ready.<!--description--> <!--end release-notes-assistant--> Co-authored-by: limiting-factor <limiting-factor@posteo.com> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8035 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
		
			
				
	
	
		
			137 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			137 lines
		
	
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2018 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| // Package cmd provides subcommands to the gitea binary - such as "web" or
 | |
| // "admin".
 | |
| package cmd
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 	"io"
 | |
| 	"os"
 | |
| 	"os/signal"
 | |
| 	"strings"
 | |
| 	"syscall"
 | |
| 
 | |
| 	"forgejo.org/models/db"
 | |
| 	"forgejo.org/modules/log"
 | |
| 	"forgejo.org/modules/setting"
 | |
| 	"forgejo.org/modules/util"
 | |
| 
 | |
| 	"github.com/urfave/cli/v3"
 | |
| )
 | |
| 
 | |
| // argsSet checks that all the required arguments are set. args is a list of
 | |
| // arguments that must be set in the passed Context.
 | |
| func argsSet(c *cli.Command, args ...string) error {
 | |
| 	for _, a := range args {
 | |
| 		if !c.IsSet(a) {
 | |
| 			return errors.New(a + " is not set")
 | |
| 		}
 | |
| 
 | |
| 		if s, ok := c.Value(a).(string); ok {
 | |
| 			if util.IsEmptyString(s) {
 | |
| 				return errors.New(a + " is required")
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // confirm waits for user input which confirms an action
 | |
| func confirm() (bool, error) {
 | |
| 	var response string
 | |
| 
 | |
| 	_, err := fmt.Scanln(&response)
 | |
| 	if err != nil {
 | |
| 		return false, err
 | |
| 	}
 | |
| 
 | |
| 	switch strings.ToLower(response) {
 | |
| 	case "y", "yes":
 | |
| 		return true, nil
 | |
| 	case "n", "no":
 | |
| 		return false, nil
 | |
| 	default:
 | |
| 		return false, errors.New(response + " isn't a correct confirmation string")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func initDB(ctx context.Context) error {
 | |
| 	setting.MustInstalled()
 | |
| 	setting.LoadDBSetting()
 | |
| 	setting.InitSQLLoggersForCli(log.INFO)
 | |
| 
 | |
| 	if setting.Database.Type == "" {
 | |
| 		log.Fatal(`Database settings are missing from the configuration file: %q.
 | |
| Ensure you are running in the correct environment or set the correct configuration file with -c.
 | |
| If this is the intended configuration file complete the [database] section.`, setting.CustomConf)
 | |
| 	}
 | |
| 	if err := db.InitEngine(ctx); err != nil {
 | |
| 		return fmt.Errorf("unable to initialize the database using the configuration in %q. Error: %w", setting.CustomConf, err)
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| func installSignals(ctx context.Context) (context.Context, context.CancelFunc) {
 | |
| 	ctx, cancel := context.WithCancel(ctx)
 | |
| 	go func() {
 | |
| 		// install notify
 | |
| 		signalChannel := make(chan os.Signal, 1)
 | |
| 
 | |
| 		signal.Notify(
 | |
| 			signalChannel,
 | |
| 			syscall.SIGINT,
 | |
| 			syscall.SIGTERM,
 | |
| 		)
 | |
| 		select {
 | |
| 		case <-signalChannel:
 | |
| 		case <-ctx.Done():
 | |
| 		}
 | |
| 		cancel()
 | |
| 		signal.Reset()
 | |
| 	}()
 | |
| 
 | |
| 	return ctx, cancel
 | |
| }
 | |
| 
 | |
| func setupConsoleLogger(level log.Level, colorize bool, out io.Writer) {
 | |
| 	if out != os.Stdout && out != os.Stderr {
 | |
| 		panic("setupConsoleLogger can only be used with os.Stdout or os.Stderr")
 | |
| 	}
 | |
| 
 | |
| 	writeMode := log.WriterMode{
 | |
| 		Level:        level,
 | |
| 		Colorize:     colorize,
 | |
| 		WriterOption: log.WriterConsoleOption{Stderr: out == os.Stderr},
 | |
| 	}
 | |
| 	writer := log.NewEventWriterConsole("console-default", writeMode)
 | |
| 	log.GetManager().GetLogger(log.DEFAULT).ReplaceAllWriters(writer)
 | |
| }
 | |
| 
 | |
| func globalBool(c *cli.Command, name string) bool {
 | |
| 	for _, ctx := range c.Lineage() {
 | |
| 		if ctx.Bool(name) {
 | |
| 			return true
 | |
| 		}
 | |
| 	}
 | |
| 	return false
 | |
| }
 | |
| 
 | |
| // PrepareConsoleLoggerLevel by default, use INFO level for console logger, but some sub-commands (for git/ssh protocol) shouldn't output any log to stdout.
 | |
| // Any log appears in git stdout pipe will break the git protocol, eg: client can't push and hangs forever.
 | |
| func PrepareConsoleLoggerLevel(defaultLevel log.Level) func(ctx context.Context, cli *cli.Command) (context.Context, error) {
 | |
| 	return func(ctx context.Context, cli *cli.Command) (context.Context, error) {
 | |
| 		level := defaultLevel
 | |
| 		if globalBool(cli, "quiet") {
 | |
| 			level = log.FATAL
 | |
| 		}
 | |
| 		if globalBool(cli, "debug") || globalBool(cli, "verbose") {
 | |
| 			level = log.TRACE
 | |
| 		}
 | |
| 		log.SetConsoleLogger(log.DEFAULT, "console-default", level)
 | |
| 		return ctx, nil
 | |
| 	}
 | |
| }
 |