mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-30 22:11:07 +00:00 
			
		
		
		
	Fixes https://github.com/go-gitea/gitea/issues/30082. Adds a new linter that searches for non-existant SVG images in templates. Output before the fix was: ``` $ make lint-templates SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl SVG "octicon-markup" not found, used in templates/repo/diff/comment_form.tmpl make: *** [Makefile:438: lint-templates] Error 1 ``` <img width="306" alt="Screenshot 2024-03-25 at 23 31 05" src="https://github.com/go-gitea/gitea/assets/115237/1052d1a9-bfec-4d5a-9cae-f895f78f7c93"> (cherry picked from commit 2ab5f05f40d93224f73e211e84de50a88a6ecf03) Conflicts: .github/workflows/files-changed.yml .github/workflows/pull-compliance.yml do not exist in Forgejo and the Forgejo workflows already contain the changes
		
			
				
	
	
		
			49 lines
		
	
	
	
		
			2.4 KiB
		
	
	
	
		
			Go HTML Template
		
	
	
	
	
	
			
		
		
	
	
			49 lines
		
	
	
	
		
			2.4 KiB
		
	
	
	
		
			Go HTML Template
		
	
	
	
	
	
| {{if and $.root.SignedUserID (not $.Repository.IsArchived)}}
 | |
| 	<form class="ui form {{if $.hidden}}tw-hidden comment-form{{end}}" action="{{$.root.Issue.Link}}/files/reviews/comments" method="post">
 | |
| 	{{$.root.CsrfTokenHtml}}
 | |
| 		<input type="hidden" name="origin" value="{{if $.root.PageIsPullFiles}}diff{{else}}timeline{{end}}">
 | |
| 		<input type="hidden" name="latest_commit_id" value="{{$.root.AfterCommitID}}">
 | |
| 		<input type="hidden" name="side" value="{{if $.Side}}{{$.Side}}{{end}}">
 | |
| 		<input type="hidden" name="line" value="{{if $.Line}}{{$.Line}}{{end}}">
 | |
| 		<input type="hidden" name="path" value="{{if $.File}}{{$.File}}{{end}}">
 | |
| 		<input type="hidden" name="diff_start_cid">
 | |
| 		<input type="hidden" name="diff_end_cid">
 | |
| 		<input type="hidden" name="diff_base_cid">
 | |
| 
 | |
| 		{{template "shared/combomarkdowneditor" (dict
 | |
| 			"MarkdownPreviewUrl" (print $.root.Repository.Link "/markup")
 | |
| 			"MarkdownPreviewContext" $.root.RepoLink
 | |
| 			"TextareaName" "content"
 | |
| 			"TextareaPlaceholder" (ctx.Locale.Tr "repo.diff.comment.placeholder")
 | |
| 			"DropzoneParentContainer" "form"
 | |
| 			"DisableAutosize" "true"
 | |
| 		)}}
 | |
| 
 | |
| 		{{if $.root.IsAttachmentEnabled}}
 | |
| 			<div class="field">
 | |
| 				{{template "repo/upload" $.root}}
 | |
| 			</div>
 | |
| 		{{end}}
 | |
| 
 | |
| 		<div class="field footer tw-mx-2">
 | |
| 			<span class="markup-info">{{svg "octicon-markdown"}} {{ctx.Locale.Tr "repo.diff.comment.markdown_info"}}</span>
 | |
| 			<div class="tw-text-right">
 | |
| 				{{if $.reply}}
 | |
| 					<button class="ui submit primary tiny button btn-reply" type="submit">{{ctx.Locale.Tr "repo.diff.comment.reply"}}</button>
 | |
| 					<input type="hidden" name="reply" value="{{$.reply}}">
 | |
| 					<input type="hidden" name="single_review" value="true">
 | |
| 				{{else}}
 | |
| 					{{if $.root.CurrentReview}}
 | |
| 						<button name="pending_review" type="submit" class="ui submit primary tiny button btn-add-comment">{{ctx.Locale.Tr "repo.diff.comment.add_review_comment"}}</button>
 | |
| 					{{else}}
 | |
| 						<button name="pending_review" type="submit" class="ui submit primary tiny button btn-start-review">{{ctx.Locale.Tr "repo.diff.comment.start_review"}}</button>
 | |
| 						<button name="single_review" value="true" type="submit" class="ui submit tiny basic button btn-add-single">{{ctx.Locale.Tr "repo.diff.comment.add_single_comment"}}</button>
 | |
| 					{{end}}
 | |
| 				{{end}}
 | |
| 				{{if or (not $.HasComments) $.hidden}}
 | |
| 					<button type="button" class="ui submit tiny basic button btn-cancel cancel-code-comment">{{ctx.Locale.Tr "cancel"}}</button>
 | |
| 				{{end}}
 | |
| 			</div>
 | |
| 		</div>
 | |
| 	</form>
 | |
| {{end}}
 |