forgejo/services/mailer
Earl Warren aca7e8a9af fix: cancelled or skipped runs are not failures for notifications (#8366)
From the point of view of a notification, the only status which must be considered a fail is `StatusFailure`. All others are either success `StatusSuccess` or undetermined `StatusCancelled` and `StatusSkipped`.

Those are the only four status in which a run can be when it reaches the `ActionRunNowDone` function because it is filtered on `IsDone` which is only true for those.

## Checklist

The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).

### Tests

- I added test coverage for Go changes...
  - [x] in their respective `*_test.go` for unit tests.

### Documentation

- [x] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [x] I do not want this change to show in the release notes.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8366
Reviewed-by: Antonin Delpeuch <wetneb@noreply.codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2025-07-03 22:53:55 +02:00
..
incoming chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
token chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail.go feat: consider WebAuthn & SSH for instance signing (#7693) 2025-04-29 10:34:07 +00:00
mail_actions.go fix: cancelled or skipped runs are not failures for notifications (#8366) 2025-07-03 22:53:55 +02:00
mail_actions_now_done_test.go fix: cancelled or skipped runs are not failures for notifications (#8366) 2025-07-03 22:53:55 +02:00
mail_admin_new_user.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_admin_new_user_test.go send mail on failed or recovered workflow run (#7509) 2025-04-29 06:58:05 +00:00
mail_auth_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_comment.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_issue.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
mail_release.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_repo.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mail_team_invite.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
mail_test.go chore: QoL improvements to tests (#7917) 2025-05-21 15:45:56 +02:00
mailer.go Update module github.com/jhillyerd/enmime/v2 to v2.2.0 (forgejo) (#8254) 2025-06-26 08:49:20 +02:00
mailer_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
main_test.go fix: only send Forgejo Actions notifications to one user (#8227) 2025-06-21 12:15:38 +02:00
notify.go fix: cancelled or skipped runs are not failures for notifications (#8366) 2025-07-03 22:53:55 +02:00