2 commits

Author	SHA1	Message	Date
RiceChuan	c3d37894aa	chore: use errors.New to replace fmt.Errorf with no parameters (#32800) ... use errors.New to replace fmt.Errorf with no parameters Signed-off-by: RiceChuan <lc582041246@gmail.com> (cherry picked from commit dfd75944992fc6508ec891b4c29715c23e59e4ed)	2024-12-15 09:15:57 +01:00
Jason Song	a35714372d	Fix halfCommitter and WithTx (#22366) ... Related to #22362. I overlooked that there's always `committer.Close()`, like: ```go ctx, committer, err := db.TxContext(db.DefaultContext) if err != nil { return nil } defer committer.Close() // ... if err != nil { return nil } // ... return committer.Commit() ``` So the `Close` of `halfCommitter` should ignore `commit and close`, it's not a rollback. See: [Why `halfCommitter` and `WithTx` should rollback IMMEDIATELY or commit LATER](https://github.com/go-gitea/gitea/pull/22366#issuecomment-1374778612). Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2023-01-09 12:19:19 -05:00