mirrors/forgejo

Fork 0

mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-08-21 18:01:11 +00:00

Commit graph

Author SHA1 Message Date

Author	SHA1	Message	Date
silverwind	12b199c5e5	Enable more `revive` linter rules (#30608 ) Noteable additions: - `redefines-builtin-id` forbid variable names that shadow go builtins - `empty-lines` remove unnecessary empty lines that `gofumpt` does not remove for some reason - `superfluous-else` eliminate more superfluous `else` branches Rules are also sorted alphabetically and I cleaned up various parts of `.golangci.yml`. (cherry picked from commit 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2) Conflicts: .golangci.yml apply the linter recommendations to Forgejo code as well	2024-04-28 15:39:00 +02:00
KN4CK3R	7866a6e0e2	Prevent primary key update on migration (#26192 ) Fixes #25918 The migration fails on MSSQL because xorm tries to update the primary key column. xorm prevents this if the column is marked as auto increment: `c622cdaf89/internal/statements/update.go (L38-L40)` I think it would be better if xorm would check for primary key columns here because updating such columns is bad practice. It looks like if that auto increment check should do the same. fyi @lunny	2023-07-28 09:54:31 +02:00
KN4CK3R	fbd4eaceed	Display image size for multiarch container images (#23821 ) Fixes #23771 Changes the display of different architectures for multiarch images to show the image size: ![grafik](https://user-images.githubusercontent.com/1666336/228781477-cc76c4d1-4728-434f-8a27-fc008790d924.png)	2023-04-02 17:53:37 +08:00

silverwind

12b199c5e5

Enable more revive linter rules (#30608 )

Noteable additions:

- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches

Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.

(cherry picked from commit 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2)

Conflicts:
	.golangci.yml
	apply the linter recommendations to Forgejo code as well

2024-04-28 15:39:00 +02:00

KN4CK3R

7866a6e0e2

Prevent primary key update on migration (#26192 )

Fixes #25918

The migration fails on MSSQL because xorm tries to update the primary
key column. xorm prevents this if the column is marked as auto
increment:

c622cdaf89/internal/statements/update.go (L38-L40)

I think it would be better if xorm would check for primary key columns
here because updating such columns is bad practice. It looks like if
that auto increment check should do the same.

fyi @lunny

2023-07-28 09:54:31 +02:00

KN4CK3R

fbd4eaceed

Display image size for multiarch container images (#23821 )

Fixes #23771

Changes the display of different architectures for multiarch images to
show the image size:

![grafik](https://user-images.githubusercontent.com/1666336/228781477-cc76c4d1-4728-434f-8a27-fc008790d924.png)

2023-04-02 17:53:37 +08:00

3 commits