Earl Warren 
								
							 
						 
						
							
							
								
							
							
	
	
	c46080bc9d 
 
						 
						
							
							
								
								
								Remove "tabindex" from some form buttons ( #27892 )  
							
							... 
							
							
							
							
							Remove the "tabindex" from some form buttons on the "diff box" / "issue view content" page, let the browser use the default tab order.
---------
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
							
						 
						
							2023-11-03 14:40:48 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	572f0963ed 
 
						 
						
							
							
								
								
								Only show diff file tree when more than one file changed ( #27775 )  
							
							... 
							
							
							
							
							When 0 or 1 files changed in a diff, we don't need to show a file tree.
This behaviour matches GitHub. Single-file diff after this change, note
absence of button:
<img width="1234" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/3618438b-e655-42a3-989f-f299267b2b8b ">
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-10-25 05:09:18 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	73b63d9311 
 
						 
						
							
							
								
								
								Replace ajax with fetch, improve image diff ( #27267 )  
							
							... 
							
							
							
							
							1. Dropzone attachment removal, pretty simple replacement
2. Image diff: The previous code fetched every image twice, once via
`img[src]` and once via `$.ajax`. Now it's only fetched once and a
second time only when necessary. The image diff code was partially
rewritten.
---------
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-10-11 12:34:21 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									JakobDev 
								
							 
						 
						
							
							
								
							
							
	
	
	ebe803e514 
 
						 
						
							
							
								
								
								Penultimate round of db.DefaultContext refactor ( #27414 )  
							
							... 
							
							
							
							
							Part of #27065 
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> 
							
						 
						
							2023-10-11 04:24:07 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	1f00bc44b2 
 
						 
						
							
							
								
								
								Fix review UI ( #27322 )  
							
							... 
							
							
							
							
							Close  #26730 
1. The `diff-detail-box` was abused, it shouldn't be used for
"DiffFileList/DiffFileTree".
2. Fix the sticky position for various screens.


 
						
							2023-09-28 10:00:26 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	93bd4351bf 
 
						 
						
							
							
								
								
								Fix more "locale" usages ( #27259 )  
							
							
							
							
						 
						
							2023-09-25 20:42:40 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									delvh 
								
							 
						 
						
							
							
								
							
							
	
	
	7960ba7e2b 
 
						 
						
							
							
								
								
								Always use ctx.Locale.Tr inside templates ( #27231 )  
							
							
							
							
						 
						
							2023-09-25 08:56:50 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Denys Konovalov 
								
							 
						 
						
							
							
								
							
							
	
	
	2325fe777d 
 
						 
						
							
							
								
								
								cleanup locale function usage ( #27227 )  
							
							
							
							
						 
						
							2023-09-24 20:31:58 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	8099238618 
 
						 
						
							
							
								
								
								Change green buttons to primary color ( #27099 )  
							
							... 
							
							
							
							
							I think it's better if the primary actions have primary color instead of
green which fits better into the overall single-color UI design. This PR
currently replaces every green button with primary:
<img width="141" alt="Screenshot 2023-09-16 at 14 07 59"
src="https://github.com/go-gitea/gitea/assets/115237/843c1e50-4fb2-4ec6-84ba-0efb9472dcbe ">
<img width="161" alt="Screenshot 2023-09-16 at 14 07 51"
src="https://github.com/go-gitea/gitea/assets/115237/9442195a-a3b2-4a42-b262-8377d6f5c0d1 ">
Modal actions now use uncolored/primary instead of previous green/red
colors. I also removed the box-shadow on all basic buttons:
<img width="259" alt="Screenshot 2023-09-16 at 14 16 39"
src="https://github.com/go-gitea/gitea/assets/115237/5beea529-127a-44b0-8d4c-afa7b034a490 ">
<img width="261" alt="Screenshot 2023-09-16 at 14 17 42"
src="https://github.com/go-gitea/gitea/assets/115237/4757f7b2-4d46-49bc-a797-38bb28437b88 ">
The change currently includes the "Merge PR" button, for which we might
want to make an exception to match the icon color there:
<img width="442" alt="Screenshot 2023-09-16 at 14 33 53"
src="https://github.com/go-gitea/gitea/assets/115237/993ac1a5-c94d-4895-b76c-0d872181a70b "> 
							
						 
						
							2023-09-18 22:05:31 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	d5703d4a1b 
 
						 
						
							
							
								
								
								Remove "TODO" tasks from CSS file ( #26835 )  
							
							... 
							
							
							
							
							1. Use `gt-invisible` instead of `invisible`.
2. Use `gt-word-break` instead of `dont-break-out` (there is a slight
different "hyphens", but I think it won't affect too much since it is
only used for the "full name").
3. Remove `.small.button:has(svg)` , now our buttons could layout SVG
correctly, and actually I didn't see this CSS class is used in code. 
							
						 
						
							2023-08-31 10:49:53 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	19a1e1b20e 
 
						 
						
							
							
								
								
								Remove polluted .ui.right ( #26825 )  
							
							... 
							
							
							
							
							Each change is tested manually line by line. There are too many changes
so I can't share dozens of screenshots.
In short:
1. `ui right` could be still used in `ui top attached header`, because
there is a special case.
2. A lot of `ui right` are just no-op, so they can be removed safely.
3. Some of the `ui right` should be replaced by `gt-float-right` (to
avoid breaking, leave them to the future).
4. A few of the `ui right` could be rewritten by flex. 
							
						 
						
							2023-08-31 02:29:59 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									CaiCandong 
								
							 
						 
						
							
							
								
							
							
	
	
	c576b50441 
 
						 
						
							
							
								
								
								Fix being unable to use a repo that prohibits accepting PRs as a PR source. ( #26785 )  
							
							... 
							
							
							
							
							## Description 
Sometimes, we need to use an upstream mirror repository to update the
current development repository, but mirror repositories are prohibited
from PR. It should not appear in `merge to,` but it can appear in `pull
from.`
Fix  #24585  #26193  #26781 
Related #24183 
Many thanks to @apnote  for assisting me in reproducing this bug!
## ScreenShot
---
### Before
<img
src="https://github.com/go-gitea/gitea/assets/50507092/3d76c376-1f54-45b9-80c9-6ba8319d6a9a "
width="400px">
<img
src="https://github.com/go-gitea/gitea/assets/50507092/fbfd9f7f-421f-4a2e-9a3e-f2958bbf3312 "
width="400px">
### After
<img
src="https://github.com/go-gitea/gitea/assets/50507092/e6984524-4f61-4310-b795-4d8598bd8963 "
width="400px">
<img
src="https://github.com/go-gitea/gitea/assets/50507092/04065b44-78d7-4721-bf31-0f1674150727 "
width="400px"> 
							
						 
						
							2023-08-29 12:07:15 +03:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	ee9e83b230 
 
						 
						
							
							
								
								
								Remove incorrect CSS helper classes ( #26712 )  
							
							
							
							
						 
						
							2023-08-25 06:47:59 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	390ec619f3 
 
						 
						
							
							
								
								
								Fix review bar misalignment ( #26711 )  
							
							
							
							
						 
						
							2023-08-24 23:46:30 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	09faf43ef8 
 
						 
						
							
							
								
								
								Improve Image Diff UI ( #26696 )  
							
							... 
							
							
							
							
							1. Use `is-loading` instead of `ui loader`
2. Introduce class name `image-diff-tabs`, instead of searching `gt-hidden`, which is fragile
3. Align the UI elements, see the screenshots. 
							
						 
						
							2023-08-24 12:13:23 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	56b6b2b88e 
 
						 
						
							
							
								
								
								Fix tooltip of commit select button ( #26472 )  
							
							... 
							
							
							
							
							Previously, the tooltip for this button was only shown after opening and
closing it once because it was only set after the server response, now
it shows before opening it. 
							
						 
						
							2023-08-14 02:16:40 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	a370efc13f 
 
						 
						
							
							
								
								
								Use template context function for avatar rendering ( #26385 )  
							
							... 
							
							
							
							
							Introduce `AvatarUtils`, no need to pass `$.Context` to every
sub-template, and simplify the template helper functions. 
							
						 
						
							2023-08-10 11:19:39 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									delvh 
								
							 
						 
						
							
							
								
							
							
	
	
	8736b134bd 
 
						 
						
							
							
								
								
								Display human-readable text instead of cryptic filemodes ( #26352 )  
							
							... 
							
							
							
							
							Now, you don't need to be a git expert anymore to know what these
numbers mean.
## Before

## After

or when the mode actually changed:
 
							
						 
						
							2023-08-06 21:52:34 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	aa723dea9b 
 
						 
						
							
							
								
								
								Don't autosize textarea in diff view ( #26233 )  
							
							... 
							
							
							
							
							Resizing the comment editor can be a very expensive operation because it
triggers page reflows, which on large PRs can take upwards of seconds to
complete. Disable this mechanism on the diff page only where we know
that the page can get large.
Fixes https://github.com/go-gitea/gitea/issues/26201  for the textarea
editor.
I don't think this can be fixed for EasyMDE because as far as I can
tell, it exposes no option to disable this resizing.
---------
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-07-31 00:11:15 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									sebastian-sauer 
								
							 
						 
						
							
							
								
							
							
	
	
	55532061c8 
 
						 
						
							
							
								
								
								Add commits dropdown in PR files view and allow commit by commit review ( #25528 )  
							
							... 
							
							
							
							
							This PR adds a new dropdown to select a commit or a commit range
(shift-click like github) of a Pull Request.
After selection of a commit only the changes of this commit will be shown.
When selecting a range of commits the diff of this range is shown.
This allows to review a PR commit by commit or by viewing only commit ranges.
The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.
## Screenshots
### The commit dropdown

### Selecting a commit range

### Show changes of a single commit only

### Show changes of a commit range

Fixes https://github.com/go-gitea/gitea/issues/20989 
Fixes https://github.com/go-gitea/gitea/issues/19263 
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de> 
							
						 
						
							2023-07-28 21:18:12 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									puni9869 
								
							 
						 
						
							
							
								
							
							
	
	
	1d8d90fd37 
 
						 
						
							
							
								
								
								Fixing the align of commit stats in commit_page template. ( #26161 )  
							
							... 
							
							
							
							
							Fixing the align center to row and space around for commit_page
template. 
							
						 
						
							2023-07-28 13:12:44 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									sebastian-sauer 
								
							 
						 
						
							
							
								
							
							
	
	
	d473de0c2d 
 
						 
						
							
							
								
								
								Make add line comment buttons focusable ( #25894 )  
							
							... 
							
							
							
							
							Use a real button and add an aria-label.
Additionally, show the button whenever it is focused.
See https://codeberg.org/forgejo/forgejo/issues/998  for explanation.
Our handling of this button is now equal to that of GitHub.
Nothing has changed visually. 
							
						 
						
							2023-07-15 11:45:34 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	61e0d1a767 
 
						 
						
							
							
								
								
								Enable H014 and H023 djlint rules ( #25786 )  
							
							... 
							
							
							
							
							Enable these rules:
- H014 | More than 2 blank lines.
- H023 | Do not use entity references.
There are more potential rules to enable but they are blocked by bugs in
the linter:
- https://github.com/Riverside-Healthcare/djLint/issues/711 
- https://github.com/Riverside-Healthcare/djLint/issues/712  
							
						 
						
							2023-07-09 20:33:25 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									puni9869 
								
							 
						 
						
							
							
								
							
							
	
	
	2ff0c12a95 
 
						 
						
							
							
								
								
								Repository Archived text title center align ( #25767 )  
							
							... 
							
							
							
							
							Archive text title center align
<details>
  <summary>Screen shots</summary>
  
 Before

After 


BTW On github

</details>
---------
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-07-08 10:57:17 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									sebastian-sauer 
								
							 
						 
						
							
							
								
							
							
	
	
	f03d95f0a9 
 
						 
						
							
							
								
								
								Allow/fix review (approve/reject) of empty PRs ( #25690 )  
							
							... 
							
							
							
							
							gitea allows to create empty PRs.
Currently when you need approvals for a merge, you have to manually add
/files to the url to get to the files tab to approve / reject the PR.
This PR allows to open the files tab via the normal tab / link and then
fixes the layout of the files tab.
**Screenshots:**
Before:

After:

---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-07-06 15:33:04 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									sebastian-sauer 
								
							 
						 
						
							
							
								
							
							
	
	
	ed8a8af99f 
 
						 
						
							
							
								
								
								Use AfterCommitId to get commit for Viewed functionality ( #25529 )  
							
							... 
							
							
							
							
							the PullHeadCommitID is not always available when the PR is merged.
Not sure if this is the best solution but in my simple tests it looks
like this fixes the problem - happy to get any feedback.
hopefully fixes https://github.com/go-gitea/gitea/issues/24813  
							
						 
						
							2023-07-01 00:08:18 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	64f2d70262 
 
						 
						
							
							
								
								
								Replace fomantic divider module with our own ( #25539 )  
							
							... 
							
							
							
							
							Should look exactly like before for normal dividers. "Horizontal" ones
look better because they no longer use image backgrounds.
<img width="917" alt="Screenshot 2023-06-27 at 19 07 56"
src="https://github.com/go-gitea/gitea/assets/115237/d97d8dec-6859-44a8-85ba-e4549b4dd9df ">
<img width="914" alt="Screenshot 2023-06-27 at 19 05 58"
src="https://github.com/go-gitea/gitea/assets/115237/8bf98544-2d82-4ebf-ac68-d6dc237bd6b2 ">
<img width="1246" alt="Screenshot 2023-06-27 at 19 00 42"
src="https://github.com/go-gitea/gitea/assets/115237/36a6bb21-6029-4f53-8bee-535f55c66fed ">
<img width="344" alt="Screenshot 2023-06-27 at 18 58 15"
src="https://github.com/go-gitea/gitea/assets/115237/a9e70aee-8e6b-4ea1-9e93-19c9f96aec6e ">
<img width="823" alt="Screenshot 2023-06-27 at 18 56 22"
src="https://github.com/go-gitea/gitea/assets/115237/e7a497cd-f262-4683-8872-23c3c8cce32f ">
<img width="330" alt="Screenshot 2023-06-27 at 19 21 11"
src="https://github.com/go-gitea/gitea/assets/115237/42f24149-a655-4c7e-bd26-8ab52db6446b "> 
							
						 
						
							2023-06-29 20:24:22 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									sebastian-sauer 
								
							 
						 
						
							
							
								
							
							
	
	
	7609f2f27e 
 
						 
						
							
							
								
								
								Link to existing PR when trying to open a new PR on the same branches ( #25494 )  
							
							... 
							
							
							
							
							when trying to create a PR for an existing PRs branch combination link
to the PR directly and not just to the repo.
Before:

After:
 
							
						 
						
							2023-06-25 10:03:36 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									sebastian-sauer 
								
							 
						 
						
							
							
								
							
							
	
	
	77e449f0be 
 
						 
						
							
							
								
								
								Highlight viewed files differently in the PR filetree ( #24956 )  
							
							... 
							
							
							
							
							
fixes  #24566 
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
							
						 
						
							2023-06-25 08:46:30 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	7fb539677b 
 
						 
						
							
							
								
								
								Diff page enhancements ( #25398 )  
							
							... 
							
							
							
							
							Two small tweaks:
1. Vertically center arrow here when editing a PR:
<img width="405" alt="Screenshot 2023-06-20 at 19 48 49"
src="https://github.com/go-gitea/gitea/assets/115237/1d63764d-9fd9-467e-8a8e-9258c06475eb ">
2. Use 2-row layout on diff viewed status and show it again on mobile:
<img width="142" alt="Screenshot 2023-06-20 at 19 51 21"
src="https://github.com/go-gitea/gitea/assets/115237/3046e782-163c-4f87-910c-a22066de8f1b ">
Mobile view:
<img width="370" alt="Screenshot 2023-06-20 at 19 44 40"
src="https://github.com/go-gitea/gitea/assets/115237/9cf56347-7323-4d05-99a5-17ad215ee44d "> 
							
						 
						
							2023-06-22 11:05:22 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									sebastian-sauer 
								
							 
						 
						
							
							
								
							
							
	
	
	25455bc670 
 
						 
						
							
							
								
								
								Show outdated comments in files changed tab ( #24936 )  
							
							... 
							
							
							
							
							If enabled show a clickable label in the comment. A click on the label
opens the Conversation tab with the comment focussed - there you're able
to view the old diff (or original diff the comment was created on).
**Screenshots**


When resolved and outdated:

Option to enable/disable this (stored in user settings - default is
disabled):


fixes  #24913 
---------
Co-authored-by: silverwind <me@silverwind.io> 
							
						 
						
							2023-06-21 16:08:12 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	831db53c21 
 
						 
						
							
							
								
								
								Fix dropdown icon layout on diff page ( #25397 )  
							
							... 
							
							
							
							
							Address
https://github.com/go-gitea/gitea/pull/25163#issuecomment-1599207916 
Remove the unused  "icon-button".
And fix the layout:
Without the dropdown icon:
```
	{{svg "gitea-whitespace"}}
```

With the dropdown icon:
```
	{{svg "gitea-whitespace" 16 "gt-mr-3"}}
	{{svg "octicon-triangle-down" 14 "dropdown icon"}}
```
 
							
						 
						
							2023-06-20 23:22:48 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	e24f651c86 
 
						 
						
							
							
								
								
								Add template linting via djlint ( #25212 )  
							
							... 
							
							
							
							
							So I found this [linter](https://github.com/Riverside-Healthcare/djlint )
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.
Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.
- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well). 
							
						 
						
							2023-06-14 18:17:58 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	46c17c8029 
 
						 
						
							
							
								
								
								Use flex to align SVG and text ( #25163 )  
							
							... 
							
							
							
							
							The code can be as simple as:
```html
<div class="flex-text-block">{{svg "octicon-alert"}} {{svg "octicon-x"}} text (block)</div>
<div><div class="flex-text-inline">{{svg "octicon-alert"}} {{svg "octicon-x"}} text</div> (inline)</div>
<div><button class="ui red button">{{svg "octicon-alert" 24}} {{svg "octicon-x" 24}} text</button></div>
```

---------
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-06-14 16:40:15 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									HesterG 
								
							 
						 
						
							
							
								
							
							
	
	
	a43ea22479 
 
						 
						
							
							
								
								
								Change form actions to fetch for submit review box ( #25219 )  
							
							... 
							
							
							
							
							Co-author: @wxiaoguang 
Close  #25096  
The way to fix it in this PR is to change form submit to fetch using
formData, and add flags to avoid post repeatedly.
Should be able to apply to more forms that have the same issue after
this PR.
In the demo below, 'approve' is clicked several times, and then
'comment' is clicked several time after 'request changes' clicked.
After:
https://github.com/go-gitea/gitea/assets/17645053/beabeb1d-fe66-4b76-b048-4f022b4e83a0 
Update: screenshots from /devtest
>

> 
>

> 
>

---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
							
						 
						
							2023-06-14 16:01:37 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	623b3b590e 
 
						 
						
							
							
								
								
								Button and color enhancements ( #24989 )  
							
							... 
							
							
							
							
							- Various corrections to button styles, especially secondary
- Remove focus highlight, it's annoying when it stays on button after
press
- Clearly define ghost and link buttons with demos in devtest
- Remove black, grey and tertiary buttons, they should not be used
- Make `arc-green` slightly darker
<img width="1226" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/8d89786a-01ab-40f8-ae5a-e17f40e35084 ">
<img width="1249" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/83651e6d-3c27-46ff-b8bd-ff344d70e949 ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-06-09 08:37:47 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Kyle D 
								
							 
						 
						
							
							
								
							
							
	
	
	72eedfb915 
 
						 
						
							
							
								
								
								Show file tree by default ( #25052 )  
							
							... 
							
							
							
							
							Feel free to close this if there isn't interest.
The tree view looks amazing, and all of our users are really enjoying it
(major kudos to developers!), but only IF I tell them it exists!
Essentially, the file tree view as it is effectively undiscoverable.  
This PR changes the default state for the tree view to open, which
should significantly help with discoverability.
An alternative could be to reserve more horizontal space, as a typical
accordion panel would look (eg. VS Code), eg.
 
							
						 
						
							2023-06-02 23:39:01 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	c5ede35124 
 
						 
						
							
							
								
								
								Add button on diff header to copy file name, misc diff header tweaks ( #24986 )  
							
							... 
							
							
							
							
							1. Add this button:
<img width="232" alt="Screenshot 2023-05-29 at 15 21 47"
src="https://github.com/go-gitea/gitea/assets/115237/5eaf6bd1-83db-4ffc-9503-eda0c59807d2 ">
<img width="297" alt="Screenshot 2023-05-29 at 15 20 22"
src="https://github.com/go-gitea/gitea/assets/115237/708a344f-f6d7-4229-bfda-76e1571b42c8 ">
2. Correct `button-link` styles to not have a background hover effect.
3. Tweak `.ui.container` padding to be the same for fluid and non-fluid.
4. Misc enhancements to diff header:
Before:
<img width="984" alt="Screenshot 2023-05-29 at 15 38 53"
src="https://github.com/go-gitea/gitea/assets/115237/c7926f6a-bd0a-4b05-97ad-c91fc25c62d5 ">
After:
<img width="987" alt="Screenshot 2023-05-29 at 15 43 10"
src="https://github.com/go-gitea/gitea/assets/115237/0149f545-45f8-42cf-b443-e1c76bd5cdeb "> 
							
						 
						
							2023-06-01 10:47:28 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	ee99cf6313 
 
						 
						
							
							
								
								
								Refactor diffFileInfo / DiffTreeStore  ( #24998 )  
							
							... 
							
							
							
							
							Follow  #21012 , #22399 
Replace #24983 , fix  #24938 
Help #24956 
Now, the `window.config.pageData.diffFileInfo` itself is a reactive
store, so it's quite easy to sync values/states by it, no need to do
"doLoadMoreFiles" or "callback".
Screenshot: these two buttons both work. After complete loading, the UI
is also right.
<details>



</details> 
							
						 
						
							2023-05-30 18:53:15 +08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Yevhen Pavlov 
								
							 
						 
						
							
							
								
							
							
	
	
	a36c620583 
 
						 
						
							
							
								
								
								Display file mode for new file and file mode changes ( #24966 )  
							
							... 
							
							
							
							
							This MR introduces the addition of file mode display support for both
new file creation and file mode changes, following a similar approach as
GitLab.
GitLab:

Gitea:

Replaces: https://github.com/go-gitea/gitea/pull/23159 
Closes: https://github.com/go-gitea/gitea/issues/23021 
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-05-29 19:56:08 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	595e8abd68 
 
						 
						
							
							
								
								
								Improve and fix bugs surrounding reactions ( #24760 )  
							
							... 
							
							
							
							
							- Slightly decrease size of reaction buttons
- Remove tooltip inside menu, it's obvious by the picture alone
- Fix top menu triangle
- Use `display: grid` to align icons in menu
- Use regular tooltip for reaction users
- Fix bug that deleted the reaction bar on clicking already reacted
reaction in dropdown
<img width="490" alt="Screenshot 2023-05-17 at 00 03 42"
src="https://github.com/go-gitea/gitea/assets/115237/61588b37-facb-4829-b75b-e1cb5dda8ca4 ">
<img width="67" alt="Screenshot 2023-05-17 at 00 11 14"
src="https://github.com/go-gitea/gitea/assets/115237/29605589-3b5f-40c6-8ad4-09923094bb8e ">
<img width="211" alt="Screenshot 2023-05-17 at 00 29 30"
src="https://github.com/go-gitea/gitea/assets/115237/7d2725da-6a3d-4e42-a351-53647f79f762 ">
<img width="210" alt="Screenshot 2023-05-17 at 00 29 54"
src="https://github.com/go-gitea/gitea/assets/115237/b50f8364-033c-4445-ba25-61a814bb2d92 ">
<img width="892" alt="Screenshot 2023-05-17 at 00 12 20"
src="https://github.com/go-gitea/gitea/assets/115237/30a46424-406a-46e5-b4de-47172eb8679d ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-05-28 01:34:18 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									silverwind 
								
							 
						 
						
							
							
								
							
							
	
	
	19993d8814 
 
						 
						
							
							
								
								
								Change --font-weight-bold to --font-weight-semibold and 600 value, introduce new font weight variables ( #24827 )  
							
							... 
							
							
							
							
							There was some recent discussion about this in Discord `ui-design`
channel and the conclusion was that
https://github.com/go-gitea/gitea/issues/24305  should have fixed their
OS font installation to have semibold weights.
I have now tested this 601 weight on a Windows 10 machine on Firefox
myself, and I immediately noticed that bold was excessivly bold and
rendering as 700 because browsers are biased towards bolder fonts. So
revert this back to the previous value. 
							
						 
						
							2023-05-21 23:37:32 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									delvh 
								
							 
						 
						
							
							
								
							
							
	
	
	e95b42e187 
 
						 
						
							
							
								
								
								Improve accessibility when (re-)viewing files ( #24817 )  
							
							... 
							
							
							
							
							Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener
The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).
---------
Co-authored-by: silverwind <me@silverwind.io> 
							
						 
						
							2023-05-21 20:47:41 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									yp05327 
								
							 
						 
						
							
							
								
							
							
	
	
	b5c26fa825 
 
						 
						
							
							
								
								
								Add markdown preview to Submit Review Textarea ( #24672 )  
							
							... 
							
							
							
							
							Before:

After:

---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
							
						 
						
							2023-05-12 10:53:41 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Hester Gong 
								
							 
						 
						
							
							
								
							
							
	
	
	8bbbf7e6b8 
 
						 
						
							
							
								
								
								Remove fluid on compare diff page ( #24627 )  
							
							... 
							
							
							
							
							As discuessed in
https://github.com/go-gitea/gitea/pull/24598/files#r1189290462 
After:
Diff Page
<img width="1426" alt="Screen Shot 2023-05-10 at 10 44 48"
src="https://github.com/go-gitea/gitea/assets/17645053/bc1a5f78-ec17-4ac2-8390-081a5fc059d1 ">
New PR Page
<img width="1428" alt="Screen Shot 2023-05-10 at 10 45 17"
src="https://github.com/go-gitea/gitea/assets/17645053/ce94a28e-39d5-4534-9e78-c0edd4c7a339 ">
<img width="1432" alt="Screen Shot 2023-05-10 at 10 45 27"
src="https://github.com/go-gitea/gitea/assets/17645053/047809e1-abb2-4c16-ae62-63b71094c1c7 "> 
							
						 
						
							2023-05-10 08:46:17 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	b6fc2cdf82 
 
						 
						
							
							
								
								
								Make diff view full width again ( #24598 )  
							
							... 
							
							
							
							
							Regression of #24459  , [the related
line](https://github.com/go-gitea/gitea/pull/24459/files#diff-f255004de8d715ff40852710390429bf2a06e7e33a4e3f8ad568af636557ac71L8 )
The PR file diff view needs to be full-screen width. 
							
						 
						
							2023-05-09 05:21:03 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	56ae853ca0 
 
						 
						
							
							
								
								
								Simplify template helper functions ( #24570 )  
							
							... 
							
							
							
							
							To avoid bloating the template helper functions, some functions could be
provided by type methods.
And the new code `data-line-type="{{.GetHTMLDiffLineType}}"` reads
better than `data-line-type="{{DiffLineTypeToStr .GetType}}"`
After the fix, screenshots (the same as before):
<details>


</details> 
							
						 
						
							2023-05-07 09:49:46 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	3e7101dd64 
 
						 
						
							
							
								
								
								Improve "new-menu" ( #24465 )  
							
							... 
							
							
							
							
							I am not sure what "new-menu" means, but I think we need to fix these
problems:
1. it shouldn't have "stackable", which makes the items stacked when
width is small. the `new-menu` already has `overflow: auto`
2. `justify-content: center` doesn't work with `overflow: auto` (for
small width), so use `margin: auto`
*
https://bhch.github.io/posts/2021/04/centring-flex-items-and-allowing-overflow-scroll/ 
3. `runner-new-menu` is dead code (copying & pasting ?) 
							
						 
						
							2023-05-01 12:08:37 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									wxiaoguang 
								
							 
						 
						
							
							
								
							
							
	
	
	5a5ab8ef5a 
 
						 
						
							
							
								
								
								Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu ( #24393 )  
							
							... 
							
							
							
							
							Since 2015/2016, there is a global pollution: ".ui.left" / ".ui.right".
Fomantic UI doesn't work this way, it just conflicts with many Fomantic
definitions.
This PR starts the cleaning work of such techinical debts.
And, the "label list" page has been quite messy for long time, for
example, why "li" appears in "div" ......
And fix  #24296 
<details>





</details> 
							
						 
						
							2023-04-29 07:35:59 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									JakobDev 
								
							 
						 
						
							
							
								
							
							
	
	
	c41bc4f127 
 
						 
						
							
							
								
								
								Display when a repo was archived ( #22664 )  
							
							... 
							
							
							
							
							This adds the date a repo is archived to Gitea and shows it in the UI
and API. A feature, that GitHub has been [introduced
recently](https://github.blog/changelog/2022-11-23-repository-archive-date-now-shown-in-ui/ ).
I currently don't know how to correctly deal with the Date in the
template, as different languages have different ways of writing a date.

---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> 
							
						 
						
							2023-04-26 10:46:26 -04:00