mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-29 21:41:02 +00:00 
			
		
		
		
	Fix math and mermaid rendering bugs (#24049)
1. Fix multiple error display for math and mermaid:  2. Fix height calculation of certain mermaid diagrams by reading the iframe inner height from it's document instead of parsing it from SVG: Before: <img width="866" alt="Screenshot 2023-04-11 at 11 56 27" src="https://user-images.githubusercontent.com/115237/231126480-b194e02b-ea8c-4ddf-8c79-50c525815d92.png"> After: <img width="855" alt="Screenshot 2023-04-11 at 11 56 35" src="https://user-images.githubusercontent.com/115237/231126494-5fe86a48-8d21-455a-8b95-79b6ee27a16f.png"> 3. Refactor error handling to a common function 4. Rename to `renderAsciicast` for consistency 5. Improve mermaid loading sequence Note: I did try `securityLevel: 'sandbox'` to make mermaid output a iframe directly, but that showed a bug in mermaid where the iframe style height was set incorrectly. Opened https://github.com/mermaid-js/mermaid/issues/4289 for this. --------- Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
		
					parent
					
						
							
								7681d582cd
							
						
					
				
			
			
				commit
				
					
						dcde4701a5
					
				
			
		
					 8 changed files with 46 additions and 43 deletions
				
			
		|  | @ -9,7 +9,7 @@ | |||
|   /* non-color variables */ | ||||
|   --border-radius: 0.28571429rem; | ||||
|   --opacity-disabled: 0.55; | ||||
|   --height-loading: 12rem; | ||||
|   --height-loading: 16rem; | ||||
|   /* base colors */ | ||||
|   --color-primary: #4183c4; | ||||
|   --color-primary-contrast: #ffffff; | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue