mirrors/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-08-22 02:11:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

test: fix failure in relative-time tests in US/Canada DST-aware timezones (#8858)

Browse source 
When running relative-time tests on my local system, the tests fail.

I've verified this failure does occur when the local system time is configured to use these timezones:
- America/Edmonton
- America/Boise
- America/Goose Bay

But the tests pass if the local system time is in these timezones:
- America/Phoenix (has no DST)
- Europe/Berlin (different DST rules)

"7 months ago" (the existing test case output) is accurate considering the offsets used in the test, but internally dayjs calculates it to be 7.99 months when the system TZ is in the "success" TZs, and 8.0001 months in the "failure" TZs.

I believe the source of the difference is that...
- dayjs takes timestamps with offsets, applies the offset, and then treats them as local times...
- Summer Time ended on Oct 27 (the "now" date under test) in Europe, but did not end until November 3rd in the US/Canada...
- In Europe there would have been one hour less between those local timestamps than there would be in US/Canada.

My proposed fix is to perform the diff calculations after converting the timestamps to UTC values.  This provides consistent successful output regardless of the local system TZ.

As the tests are sensitive to system timezone, I've modified the CI build to run the frontend tests twice with two different TZ environment variables.  This is a pretty coarse way to exercise the problem and I'm open to improvements.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8858
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
This commit is contained in:
Mathieu Fenniak 2025-08-12 02:47:58 +02:00 • committed by Gusted
commit da9bedc967
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
web_src/js/webcomponents/relative-time.js
View file

@ -1,6 +1,9 @@
import dayjs from 'dayjs';
import utc from 'dayjs/plugin/utc.js';
const {pageData} = window.config;
dayjs.extend(utc);
export const HALF_MINUTE = 30 * 1000;
export const ONE_MINUTE = 60 * 1000;
export const ONE_HOUR = 60 * ONE_MINUTE;
@ -103,8 +106,8 @@ export function DoUpdateRelativeTime(object, now) {
if (!now) now = Date.now();
const nowJS = dayjs(now);
const thenJS = dayjs(absoluteTime);
const nowJS = dayjs.utc(now);
const thenJS = dayjs.utc(absoluteTime);
object.setAttribute('data-tooltip-content', ABSOLUTE_DATETIME_FORMAT.format(thenJS.toDate()));