mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 06:21:11 +00:00 
			
		
		
		
	limit ctx access on service level
This commit is contained in:
		
					parent
					
						
							
								ecd2016a0e
							
						
					
				
			
			
				commit
				
					
						c67cc791c4
					
				
			
		
					 10 changed files with 184 additions and 49 deletions
				
			
		
							
								
								
									
										147
									
								
								services/federation/repository_inbox_like.go
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										147
									
								
								services/federation/repository_inbox_like.go
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,147 @@ | |||
| // Copyright 2024 The Forgejo Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
| 
 | ||||
| package federation | ||||
| 
 | ||||
| import ( | ||||
| 	"context" | ||||
| 	"fmt" | ||||
| 	"net/http" | ||||
| 	"time" | ||||
| 
 | ||||
| 	ap "github.com/go-ap/activitypub" | ||||
| 
 | ||||
| 	"forgejo.org/models/forgefed" | ||||
| 	"forgejo.org/models/repo" | ||||
| 	"forgejo.org/models/user" | ||||
| 	"forgejo.org/modules/activitypub" | ||||
| 	fm "forgejo.org/modules/forgefed" | ||||
| 	"forgejo.org/modules/log" | ||||
| 	"forgejo.org/modules/validation" | ||||
| 	context_service "forgejo.org/services/context" | ||||
| ) | ||||
| 
 | ||||
| // ProcessLikeActivity receives a ForgeLike activity and does the following: | ||||
| // Validation of the activity | ||||
| // Creation of a (remote) federationHost if not existing | ||||
| // Creation of a forgefed Person if not existing | ||||
| // Validation of incoming RepositoryID against Local RepositoryID | ||||
| // Star the repo if it wasn't already stared | ||||
| // Do some mitigation against out of order attacks | ||||
| func ProcessLikeActivity(ctx context.Context, activity *ap.Activity, repositoryID int64) (ServiceResult, error) { | ||||
| 	constructorLikeActivity, _ := fm.NewForgeLike(activity.Actor.GetLink().String(), activity.Object.GetLink().String(), activity.StartTime) | ||||
| 	if res, err := validation.IsValid(constructorLikeActivity); !res { | ||||
| 		return ServiceResult{}, NewErrNotAcceptablef("Invalid activity: %v", err) | ||||
| 	} | ||||
| 	log.Trace("Activity validated: %#v", activity) | ||||
| 
 | ||||
| 	// parse actorID (person) | ||||
| 	actorURI := activity.Actor.GetID().String() | ||||
| 	user, _, federationHost, err := FindOrCreateFederatedUser(ctx, actorURI) | ||||
| 	if err != nil { | ||||
| 		log.Error("Federated user not found (%s): %v", actorURI, err) | ||||
| 		return ServiceResult{}, NewErrNotAcceptablef("FindOrCreateFederatedUser failed: %v", err) | ||||
| 	} | ||||
| 
 | ||||
| 	if !constructorLikeActivity.IsNewer(federationHost.LatestActivity) { | ||||
| 		return ServiceResult{}, NewErrNotAcceptablef("LatestActivity: activity already processed: %v", err) | ||||
| 	} | ||||
| 
 | ||||
| 	// parse objectID (repository) | ||||
| 	objectID, err := fm.NewRepositoryID(constructorLikeActivity.Object.GetID().String(), string(forgefed.ForgejoSourceType)) | ||||
| 	if err != nil { | ||||
| 		return ServiceResult{}, NewErrNotAcceptablef("Parsing repo objectID failed: %v", err) | ||||
| 	} | ||||
| 	if objectID.ID != fmt.Sprint(repositoryID) { | ||||
| 		return ServiceResult{}, NewErrNotAcceptablef("Invalid repoId: %v", err) | ||||
| 	} | ||||
| 	log.Trace("Object accepted: %#v", objectID) | ||||
| 
 | ||||
| 	// execute the activity if the repo was not stared already | ||||
| 	alreadyStared := repo.IsStaring(ctx, user.ID, repositoryID) | ||||
| 	if !alreadyStared { | ||||
| 		err = repo.StarRepo(ctx, user.ID, repositoryID, true) | ||||
| 		if err != nil { | ||||
| 			return ServiceResult{}, NewErrNotAcceptablef("Staring failed: %v", err) | ||||
| 		} | ||||
| 	} | ||||
| 	federationHost.LatestActivity = activity.StartTime | ||||
| 	err = forgefed.UpdateFederationHost(ctx, federationHost) | ||||
| 	if err != nil { | ||||
| 		return ServiceResult{}, NewErrNotAcceptablef("Updating federatedHost failed: %v", err) | ||||
| 	} | ||||
| 
 | ||||
| 	return NewServiceResultStatusOnly(http.StatusNoContent), nil | ||||
| } | ||||
| 
 | ||||
| // Create or update a list of FollowingRepo structs | ||||
| func StoreFollowingRepoList(ctx *context_service.Context, localRepoID int64, followingRepoList []string) (int, string, error) { | ||||
| 	followingRepos := make([]*repo.FollowingRepo, 0, len(followingRepoList)) | ||||
| 	for _, uri := range followingRepoList { | ||||
| 		federationHost, err := FindOrCreateFederationHost(ctx.Base, uri) | ||||
| 		if err != nil { | ||||
| 			return http.StatusInternalServerError, "Wrong FederationHost", err | ||||
| 		} | ||||
| 		followingRepoID, err := fm.NewRepositoryID(uri, string(federationHost.NodeInfo.SoftwareName)) | ||||
| 		if err != nil { | ||||
| 			return http.StatusNotAcceptable, "Invalid federated repo", err | ||||
| 		} | ||||
| 		followingRepo, err := repo.NewFollowingRepo(localRepoID, followingRepoID.ID, federationHost.ID, uri) | ||||
| 		if err != nil { | ||||
| 			return http.StatusNotAcceptable, "Invalid federated repo", err | ||||
| 		} | ||||
| 		followingRepos = append(followingRepos, &followingRepo) | ||||
| 	} | ||||
| 
 | ||||
| 	if err := repo.StoreFollowingRepos(ctx, localRepoID, followingRepos); err != nil { | ||||
| 		return 0, "", err | ||||
| 	} | ||||
| 
 | ||||
| 	return 0, "", nil | ||||
| } | ||||
| 
 | ||||
| func DeleteFollowingRepos(ctx context.Context, localRepoID int64) error { | ||||
| 	return repo.StoreFollowingRepos(ctx, localRepoID, []*repo.FollowingRepo{}) | ||||
| } | ||||
| 
 | ||||
| func SendLikeActivities(ctx context.Context, doer user.User, repoID int64) error { | ||||
| 	followingRepos, err := repo.FindFollowingReposByRepoID(ctx, repoID) | ||||
| 	log.Trace("Federated Repos is: %#v", followingRepos) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	likeActivityList := make([]fm.ForgeLike, 0) | ||||
| 	for _, followingRepo := range followingRepos { | ||||
| 		log.Trace("Found following repo: %#v", followingRepo) | ||||
| 		target := followingRepo.URI | ||||
| 		likeActivity, err := fm.NewForgeLike(doer.APActorID(), target, time.Now()) | ||||
| 		if err != nil { | ||||
| 			return err | ||||
| 		} | ||||
| 		likeActivityList = append(likeActivityList, likeActivity) | ||||
| 	} | ||||
| 
 | ||||
| 	apclientFactory, err := activitypub.GetClientFactory(ctx) | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	apclient, err := apclientFactory.WithKeys(ctx, &doer, doer.APActorID()+"#main-key") | ||||
| 	if err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	for i, activity := range likeActivityList { | ||||
| 		activity.StartTime = activity.StartTime.Add(time.Duration(i) * time.Second) | ||||
| 		json, err := activity.MarshalJSON() | ||||
| 		if err != nil { | ||||
| 			return err | ||||
| 		} | ||||
| 
 | ||||
| 		_, err = apclient.Post(json, fmt.Sprintf("%v/inbox", activity.Object)) | ||||
| 		if err != nil { | ||||
| 			log.Error("error %v while sending activity: %#v", err, activity) | ||||
| 		} | ||||
| 	} | ||||
| 
 | ||||
| 	return nil | ||||
| } | ||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue