mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 14:31:02 +00:00 
			
		
		
		
	fix!: use run ID instead of run Index in artifacts download web views
- the run ID used to download artifacts is absolute (ID) instead of being relative to the repository (Index) for compatibility with the url built and returned as `artifact-url` by the the upload-artifact@v4 action. - this is a breaking change because URLs to download artifacts previous saved/bookmarked and not yet expired expired are no longer working, they need to be looked up again by visiting the job web page. - add unit tests for getRunByID(). - RepoActionView.test.js verifies the download URL is built using the run ID. - lAdd integration tests to verify the RunID is set as expected in the template used by RepoActionView.vue. Refs https://code.forgejo.org/forgejo/runner/issues/187
This commit is contained in:
		
					parent
					
						
							
								f7b0eb16c8
							
						
					
				
			
			
				commit
				
					
						b047a60a09
					
				
			
		
					 9 changed files with 233 additions and 19 deletions
				
			
		|  | @ -15,6 +15,7 @@ const sfc = { | |||
|   }, | ||||
|   props: { | ||||
|     runIndex: String, | ||||
|     runID: String, | ||||
|     jobIndex: String, | ||||
|     actionsURL: String, | ||||
|     workflowName: String, | ||||
|  | @ -386,6 +387,7 @@ export function initRepositoryActionView() { | |||
| 
 | ||||
|   const view = createApp(sfc, { | ||||
|     runIndex: el.getAttribute('data-run-index'), | ||||
|     runID: el.getAttribute('data-run-id'), | ||||
|     jobIndex: el.getAttribute('data-job-index'), | ||||
|     actionsURL: el.getAttribute('data-actions-url'), | ||||
|     workflowName: el.getAttribute('data-workflow-name'), | ||||
|  | @ -473,7 +475,7 @@ export function initRepositoryActionView() { | |||
|           </div> | ||||
|           <ul class="job-artifacts-list"> | ||||
|             <li class="job-artifacts-item" v-for="artifact in artifacts" :key="artifact.name"> | ||||
|               <a class="job-artifacts-link" target="_blank" :href="run.link+'/artifacts/'+artifact.name"> | ||||
|               <a class="job-artifacts-link" target="_blank" :href="actionsURL+'/runs/'+runID+'/artifacts/'+artifact.name"> | ||||
|                 <SvgIcon name="octicon-file" class="ui text black job-artifacts-icon"/>{{ artifact.name }} | ||||
|               </a> | ||||
|               <a v-if="run.canDeleteArtifact" @click="deleteArtifact(artifact.name)" class="job-artifacts-delete"> | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue