mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 06:21:11 +00:00 
			
		
		
		
	[GITEA] Make atomic ssh keys replacement robust
- After stumbling upon https://github.com/golang/go/issues/22397 and reading the implementations I realized that Forgejo code doesn't have `Sync()` and it doesn't properly error handle the `Close` function. - (likely) Resolves https://codeberg.org/forgejo/forgejo/issues/1446 (cherry picked from commit0efcb334c2) (cherry picked from commit04ef02c0dd)
This commit is contained in:
		
					parent
					
						
							
								ff60267b91
							
						
					
				
			
			
				commit
				
					
						85f2065c9b
					
				
			
		
					 2 changed files with 12 additions and 2 deletions
				
			
		|  | @ -92,7 +92,12 @@ func RewriteAllPrincipalKeys(ctx context.Context) error { | |||
| 		return err | ||||
| 	} | ||||
| 
 | ||||
| 	t.Close() | ||||
| 	if err := t.Sync(); err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	if err := t.Close(); err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	return util.Rename(tmpPath, fPath) | ||||
| } | ||||
| 
 | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue