mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 14:31:02 +00:00 
			
		
		
		
	[v1.21] [GITEA] rework long-term authentication
- The current architecture is inherently insecure, because you can construct the 'secret' cookie value with values that are available in the database. Thus provides zero protection when a database is dumped/leaked. - This patch implements a new architecture that's inspired from: [Paragonie Initiative](https://paragonie.com/blog/2015/04/secure-authentication-php-with-long-term-persistence#secure-remember-me-cookies). - Integration testing is added to ensure the new mechanism works. - Removes a setting, because it's not used anymore. (cherry picked from commiteff097448b) [GITEA] rework long-term authentication (squash) add migration Reminder: the migration is run via integration tests as explained in the commit "[DB] run all Forgejo migrations in integration tests" (cherry picked from commit4accf7443c) (cherry picked from commit 99d06e344ebc3b50bafb2ac4473dd95f057d1ddc) (cherry picked from commitd8bc98a8f0) (cherry picked from commit6404845df9)
This commit is contained in:
		
					parent
					
						
							
								0c409950f1
							
						
					
				
			
			
				commit
				
					
						72bdd4f3b9
					
				
			
		
					 17 changed files with 365 additions and 154 deletions
				
			
		
							
								
								
									
										96
									
								
								models/auth/auth_token.go
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										96
									
								
								models/auth/auth_token.go
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,96 @@ | |||
| // Copyright 2023 The Forgejo Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
| 
 | ||||
| package auth | ||||
| 
 | ||||
| import ( | ||||
| 	"context" | ||||
| 	"crypto/sha256" | ||||
| 	"encoding/hex" | ||||
| 	"fmt" | ||||
| 	"time" | ||||
| 
 | ||||
| 	"code.gitea.io/gitea/models/db" | ||||
| 	"code.gitea.io/gitea/modules/timeutil" | ||||
| 	"code.gitea.io/gitea/modules/util" | ||||
| ) | ||||
| 
 | ||||
| // AuthorizationToken represents a authorization token to a user. | ||||
| type AuthorizationToken struct { | ||||
| 	ID              int64  `xorm:"pk autoincr"` | ||||
| 	UID             int64  `xorm:"INDEX"` | ||||
| 	LookupKey       string `xorm:"INDEX UNIQUE"` | ||||
| 	HashedValidator string | ||||
| 	Expiry          timeutil.TimeStamp | ||||
| } | ||||
| 
 | ||||
| // TableName provides the real table name. | ||||
| func (AuthorizationToken) TableName() string { | ||||
| 	return "forgejo_auth_token" | ||||
| } | ||||
| 
 | ||||
| func init() { | ||||
| 	db.RegisterModel(new(AuthorizationToken)) | ||||
| } | ||||
| 
 | ||||
| // IsExpired returns if the authorization token is expired. | ||||
| func (authToken *AuthorizationToken) IsExpired() bool { | ||||
| 	return authToken.Expiry.AsLocalTime().Before(time.Now()) | ||||
| } | ||||
| 
 | ||||
| // GenerateAuthToken generates a new authentication token for the given user. | ||||
| // It returns the lookup key and validator values that should be passed to the | ||||
| // user via a long-term cookie. | ||||
| func GenerateAuthToken(ctx context.Context, userID int64, expiry timeutil.TimeStamp) (lookupKey, validator string, err error) { | ||||
| 	// Request 64 random bytes. The first 32 bytes will be used for the lookupKey | ||||
| 	// and the other 32 bytes will be used for the validator. | ||||
| 	rBytes, err := util.CryptoRandomBytes(64) | ||||
| 	if err != nil { | ||||
| 		return "", "", err | ||||
| 	} | ||||
| 	hexEncoded := hex.EncodeToString(rBytes) | ||||
| 	validator, lookupKey = hexEncoded[64:], hexEncoded[:64] | ||||
| 
 | ||||
| 	_, err = db.GetEngine(ctx).Insert(&AuthorizationToken{ | ||||
| 		UID:             userID, | ||||
| 		Expiry:          expiry, | ||||
| 		LookupKey:       lookupKey, | ||||
| 		HashedValidator: HashValidator(rBytes[32:]), | ||||
| 	}) | ||||
| 	return lookupKey, validator, err | ||||
| } | ||||
| 
 | ||||
| // FindAuthToken will find a authorization token via the lookup key. | ||||
| func FindAuthToken(ctx context.Context, lookupKey string) (*AuthorizationToken, error) { | ||||
| 	var authToken AuthorizationToken | ||||
| 	has, err := db.GetEngine(ctx).Where("lookup_key = ?", lookupKey).Get(&authToken) | ||||
| 	if err != nil { | ||||
| 		return nil, err | ||||
| 	} else if !has { | ||||
| 		return nil, fmt.Errorf("lookup key %q: %w", lookupKey, util.ErrNotExist) | ||||
| 	} | ||||
| 	return &authToken, nil | ||||
| } | ||||
| 
 | ||||
| // DeleteAuthToken will delete the authorization token. | ||||
| func DeleteAuthToken(ctx context.Context, authToken *AuthorizationToken) error { | ||||
| 	_, err := db.DeleteByBean(ctx, authToken) | ||||
| 	return err | ||||
| } | ||||
| 
 | ||||
| // DeleteAuthTokenByUser will delete all authorization tokens for the user. | ||||
| func DeleteAuthTokenByUser(ctx context.Context, userID int64) error { | ||||
| 	if userID == 0 { | ||||
| 		return nil | ||||
| 	} | ||||
| 
 | ||||
| 	_, err := db.DeleteByBean(ctx, &AuthorizationToken{UID: userID}) | ||||
| 	return err | ||||
| } | ||||
| 
 | ||||
| // HashValidator will return a hexified hashed version of the validator. | ||||
| func HashValidator(validator []byte) string { | ||||
| 	h := sha256.New() | ||||
| 	h.Write(validator) | ||||
| 	return hex.EncodeToString(h.Sum(nil)) | ||||
| } | ||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue