mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-10-31 14:31:02 +00:00 
			
		
		
		
	Improve ObjectFormat interface (#28496)
The 4 functions are duplicated, especially as interface methods. I think we just need to keep `MustID` the only one and remove other 3. ``` MustID(b []byte) ObjectID MustIDFromString(s string) ObjectID NewID(b []byte) (ObjectID, error) NewIDFromString(s string) (ObjectID, error) ``` Introduced the new interfrace method `ComputeHash` which will replace the interface `HasherInterface`. Now we don't need to keep two interfaces. Reintroduced `git.NewIDFromString` and `git.MustIDFromString`. The new function will detect the hash length to decide which objectformat of it. If it's 40, then it's SHA1. If it's 64, then it's SHA256. This will be right if the commitID is a full one. So the parameter should be always a full commit id. @AdamMajer Please review.
This commit is contained in:
		
					parent
					
						
							
								128eac9e0b
							
						
					
				
			
			
				commit
				
					
						4eb2a29910
					
				
			
		
					 39 changed files with 109 additions and 168 deletions
				
			
		|  | @ -75,7 +75,7 @@ func (repo *Repository) GetRefsFiltered(pattern string) ([]*Reference, error) { | |||
| 		if pattern == "" || strings.HasPrefix(refName, pattern) { | ||||
| 			r := &Reference{ | ||||
| 				Name:   refName, | ||||
| 				Object: repo.objectFormat.MustIDFromString(sha), | ||||
| 				Object: MustIDFromString(sha), | ||||
| 				Type:   typ, | ||||
| 				repo:   repo, | ||||
| 			} | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue