mirror of
				https://codeberg.org/forgejo/forgejo.git
				synced 2025-11-04 00:11:04 +00:00 
			
		
		
		
	[v1.21] [GITEA] rework long-term authentication
- The current architecture is inherently insecure, because you can construct the 'secret' cookie value with values that are available in the database. Thus provides zero protection when a database is dumped/leaked. - This patch implements a new architecture that's inspired from: [Paragonie Initiative](https://paragonie.com/blog/2015/04/secure-authentication-php-with-long-term-persistence#secure-remember-me-cookies). - Integration testing is added to ensure the new mechanism works. - Removes a setting, because it's not used anymore. (cherry picked from commiteff097448b) [GITEA] rework long-term authentication (squash) add migration Reminder: the migration is run via integration tests as explained in the commit "[DB] run all Forgejo migrations in integration tests" (cherry picked from commit4accf7443c) (cherry picked from commit 99d06e344ebc3b50bafb2ac4473dd95f057d1ddc) (cherry picked from commitd8bc98a8f0) (cherry picked from commit6404845df9) (cherry picked from commit72bdd4f3b9)
This commit is contained in:
		
					parent
					
						
							
								edf1cb72b4
							
						
					
				
			
			
				commit
				
					
						4b01bb0ce8
					
				
			
		
					 17 changed files with 365 additions and 154 deletions
				
			
		| 
						 | 
				
			
			@ -17,6 +17,7 @@ import (
 | 
			
		|||
	"net/url"
 | 
			
		||||
	"os"
 | 
			
		||||
	"path/filepath"
 | 
			
		||||
	"strconv"
 | 
			
		||||
	"strings"
 | 
			
		||||
	"sync/atomic"
 | 
			
		||||
	"testing"
 | 
			
		||||
| 
						 | 
				
			
			@ -299,6 +300,12 @@ func loginUser(t testing.TB, userName string) *TestSession {
 | 
			
		|||
 | 
			
		||||
func loginUserWithPassword(t testing.TB, userName, password string) *TestSession {
 | 
			
		||||
	t.Helper()
 | 
			
		||||
 | 
			
		||||
	return loginUserWithPasswordRemember(t, userName, password, false)
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func loginUserWithPasswordRemember(t testing.TB, userName, password string, rememberMe bool) *TestSession {
 | 
			
		||||
	t.Helper()
 | 
			
		||||
	req := NewRequest(t, "GET", "/user/login")
 | 
			
		||||
	resp := MakeRequest(t, req, http.StatusOK)
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -307,6 +314,7 @@ func loginUserWithPassword(t testing.TB, userName, password string) *TestSession
 | 
			
		|||
		"_csrf":     doc.GetCSRF(),
 | 
			
		||||
		"user_name": userName,
 | 
			
		||||
		"password":  password,
 | 
			
		||||
		"remember":  strconv.FormatBool(rememberMe),
 | 
			
		||||
	})
 | 
			
		||||
	resp = MakeRequest(t, req, http.StatusSeeOther)
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue