mirrors/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-09-12 22:07:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix(api): deactivate issue api for disabled or external issue-tracker (#8829)

Browse source 
- When the issue unit is disabled for a repository, don't allow issue related APIs.
- Added integration tests.
- Resolves #8408

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8829
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: zokki <zokki.softwareschmiede@gmail.com>
Co-committed-by: zokki <zokki.softwareschmiede@gmail.com>
This commit is contained in:
zokki 2025-09-03 16:13:40 +02:00 • committed by Gusted
commit 4247c37300
7 changed files with 252 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tests/integration/api_releases_test.go
View file

@ -6,8 +6,6 @@ package integration
import (
"bytes"
"fmt"
"io"
"mime/multipart"
"net/http"
"net/url"
"strings"
@ -319,18 +317,11 @@ func TestAPIUploadAssetRelease(t *testing.T) {
defer tests.PrintCurrentTest(t)()
body := &bytes.Buffer{}
writer := multipart.NewWriter(body)
part, err := writer.CreateFormFile("attachment", filename)
require.NoError(t, err)
_, err = io.Copy(part, bytes.NewReader(buff.Bytes()))
require.NoError(t, err)
err = writer.Close()
require.NoError(t, err)
contentType := tests.WriteImageBody(t, buff, filename, body)
req := NewRequestWithBody(t, http.MethodPost, assetURL, bytes.NewReader(body.Bytes())).
AddTokenAuth(token).
SetHeader("Content-Type", writer.FormDataContentType())
SetHeader("Content-Type", contentType)
resp := MakeRequest(t, req, http.StatusCreated)
var attachment *api.Attachment
@ -341,7 +332,7 @@ func TestAPIUploadAssetRelease(t *testing.T) {
req = NewRequestWithBody(t, http.MethodPost, assetURL+"?name=test-asset", bytes.NewReader(body.Bytes())).
AddTokenAuth(token).
SetHeader("Content-Type", writer.FormDataContentType())
SetHeader("Content-Type", contentType)
resp = MakeRequest(t, req, http.StatusCreated)
var attachment2 *api.Attachment
@ -467,18 +458,11 @@ func TestAPIDuplicateAssetRelease(t *testing.T) {
filename := "image.png"
buff := generateImg()
body := &bytes.Buffer{}
writer := multipart.NewWriter(body)
part, err := writer.CreateFormFile("attachment", filename)
require.NoError(t, err)
_, err = io.Copy(part, &buff)
require.NoError(t, err)
err = writer.Close()
require.NoError(t, err)
contentType := tests.WriteImageBody(t, buff, filename, body)
req := NewRequestWithBody(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/releases/%d/assets?name=test-asset&external_url=https%%3A%%2F%%2Fforgejo.org%%2F", owner.Name, repo.Name, r.ID), body).
AddTokenAuth(token)
req.Header.Add("Content-Type", writer.FormDataContentType())
req.Header.Add("Content-Type", contentType)
MakeRequest(t, req, http.StatusBadRequest)
}