fix: assorted ActivityPub code only refactors (#8708)

Fix parts of issue #8221 and part of PR #4767

Is linked to https://codeberg.org/forgejo/forgejo/pulls/8274

The commit 555f6e57ad fixes timeout forgejo/forgejo#8274 (Kommentar)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8708
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
This commit is contained in:
Michael Jerger 2025-07-28 15:17:29 +02:00 committed by Earl Warren
commit 388e4eb44b
20 changed files with 744 additions and 69 deletions

View file

@ -10,12 +10,46 @@ import (
"forgejo.org/modules/forgefed"
"forgejo.org/modules/log"
"forgejo.org/services/context"
"forgejo.org/services/federation"
ap "github.com/go-ap/activitypub"
"github.com/go-ap/jsonld"
)
// Respond with an ActivityStreams object
func responseServiceResult(ctx *context.APIContext, result federation.ServiceResult) {
ctx.Resp.Header().Add("Content-Type", activitypub.ActivityStreamsContentType)
switch {
case result.StatusOnly():
ctx.Resp.WriteHeader(result.HTTPStatus)
return
case result.WithBytes():
ctx.Resp.WriteHeader(result.HTTPStatus)
if _, err := ctx.Resp.Write(result.Bytes); err != nil {
log.Error("Error writing a response: %v", err)
ctx.Error(http.StatusInternalServerError, "Error writing a response", err)
return
}
case result.WithActivity():
binary, err := jsonld.WithContext(
jsonld.IRI(ap.ActivityBaseURI),
jsonld.IRI(ap.SecurityContextURI),
jsonld.IRI(forgefed.ForgeFedNamespaceURI),
).Marshal(result.Activity)
if err != nil {
ctx.ServerError("Marshal", err)
return
}
ctx.Resp.WriteHeader(result.HTTPStatus)
if _, err = ctx.Resp.Write(binary); err != nil {
log.Error("write to resp err: %v", err)
}
}
}
// Respond with an ActivityStreams object
// Deprecated
func response(ctx *context.APIContext, v any) {
binary, err := jsonld.WithContext(
jsonld.IRI(ap.ActivityBaseURI),