mirrors/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-09-13 22:37:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Hide edit button on tag releases

Browse source 
When the release is "just" a tag, there is no release object to edit.

Closes: #3589
This commit is contained in:
Lucas Schwiderski 2025-04-28 14:14:26 +02:00
commit 20f6639f11
No known key found for this signature in database
GPG key ID: AA12679AAA6DF4D8
2 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
templates/repo/release/list.tmpl
View file

@ -29,7 +29,7 @@
{{end}} {{end}}
</h4> </h4>
<div> <div>
{{if $.CanCreateRelease}} {{if and $.CanCreateRelease (not $release.IsTag)}}
<a class="muted" data-tooltip-content="{{ctx.Locale.Tr "repo.release.edit"}}" href="{{$.RepoLink}}/releases/edit/{{$release.TagName | PathEscapeSegments}}" rel="nofollow"> <a class="muted" data-tooltip-content="{{ctx.Locale.Tr "repo.release.edit"}}" href="{{$.RepoLink}}/releases/edit/{{$release.TagName | PathEscapeSegments}}" rel="nofollow">
{{svg "octicon-pencil"}} {{svg "octicon-pencil"}}
</a> </a>

9
tests/integration/repo_tag_test.go
View file

@ -32,12 +32,14 @@ func TestTagViewWithoutRelease(t *testing.T) {
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
session := loginUser(t, owner.Name)
err := release.CreateNewTag(git.DefaultContext, owner, repo, "master", "no-release", "release-less tag") err := release.CreateNewTag(git.DefaultContext, owner, repo, "master", "no-release", "release-less tag")
require.NoError(t, err) require.NoError(t, err)
// Test that the page loads // Test that the page loads
req := NewRequestf(t, "GET", "/%s/releases/tag/no-release", repo.FullName()) req := NewRequestf(t, "GET", "/%s/releases/tag/no-release", repo.FullName())
resp := MakeRequest(t, req, http.StatusOK) resp := session.MakeRequest(t, req, http.StatusOK)
// Test that the tags sub-menu is active and has a counter // Test that the tags sub-menu is active and has a counter
htmlDoc := NewHTMLParser(t, resp.Body) htmlDoc := NewHTMLParser(t, resp.Body)
@ -55,6 +57,9 @@ func TestTagViewWithoutRelease(t *testing.T) {
// Test that there is no "Stable" link // Test that there is no "Stable" link
htmlDoc.AssertElement(t, "h4.release-list-title > span.ui.green.label", false) htmlDoc.AssertElement(t, "h4.release-list-title > span.ui.green.label", false)
// Ensure that there is no "Edit" button
htmlDoc.AssertElement(t, ".detail a.muted > svg.octicon-pencil", false)
// Test that the correct user is linked // Test that the correct user is linked
ownerLinkHref, _ := htmlDoc.Find("a.author").Attr("href") ownerLinkHref, _ := htmlDoc.Find("a.author").Attr("href")
assert.Equal(t, "/user2", ownerLinkHref) assert.Equal(t, "/user2", ownerLinkHref)
@ -67,7 +72,7 @@ func TestTagViewWithoutRelease(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
req := NewRequestf(t, "GET", "/%s/releases/tag/ghost-tag", repo.FullName()) req := NewRequestf(t, "GET", "/%s/releases/tag/ghost-tag", repo.FullName())
resp := MakeRequest(t, req, http.StatusOK) resp := session.MakeRequest(t, req, http.StatusOK)
htmlDoc := NewHTMLParser(t, resp.Body) htmlDoc := NewHTMLParser(t, resp.Body)