From 29aae56bc15e467f2456bb3922dc1229a2486730 Mon Sep 17 00:00:00 2001
From: AThePeanut4 <49614525+AThePeanut4@users.noreply.github.com>
Date: Sun, 7 Jul 2024 16:29:12 +0200
Subject: [PATCH] fix(git): mark local plugins as needing updates only if local
 is behind upstream

---
 lua/lazy/manage/checker.lua  |  4 +++-
 lua/lazy/manage/task/git.lua | 30 +++++++++++++++++++++---------
 2 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/lua/lazy/manage/checker.lua b/lua/lazy/manage/checker.lua
index 8e03d9e..6efc5a7 100644
--- a/lua/lazy/manage/checker.lua
+++ b/lua/lazy/manage/checker.lua
@@ -35,7 +35,9 @@ end
 function M.fast_check(opts)
   opts = opts or {}
   for _, plugin in pairs(Config.plugins) do
-    if not plugin.pin and not plugin.dev and plugin._.installed then
+    -- don't check local plugins here, since we mark them as needing updates
+    -- only if local is behind upstream (if the git log task gives no output)
+    if plugin._.installed and not (plugin.pin or plugin._.is_local) then
       plugin._.updates = nil
       local info = Git.info(plugin.dir)
       local ok, target = pcall(Git.get_target, plugin)
diff --git a/lua/lazy/manage/task/git.lua b/lua/lazy/manage/task/git.lua
index 8e0ef48..17e1ade 100644
--- a/lua/lazy/manage/task/git.lua
+++ b/lua/lazy/manage/task/git.lua
@@ -32,11 +32,13 @@ M.log = {
       "--no-show-signature",
     }
 
+    local info, target
+
     if opts.updated then
       table.insert(args, self.plugin._.updated.from .. ".." .. (self.plugin._.updated.to or "HEAD"))
     elseif opts.check then
-      local info = assert(Git.info(self.plugin.dir))
-      local target = assert(self.plugin._.is_local and Git.get_local_target(self.plugin) or Git.get_target(self.plugin))
+      info = assert(Git.info(self.plugin.dir))
+      target = assert(self.plugin._.is_local and Git.get_local_target(self.plugin) or Git.get_target(self.plugin))
       if not target.commit then
         for k, v in pairs(target) do
           error(k .. " '" .. v .. "' not found")
@@ -44,15 +46,17 @@ M.log = {
         error("no target commit found")
       end
       assert(target.commit, self.plugin.name .. " " .. target.branch)
-      if Git.eq(info, target) then
-        if Config.options.checker.check_pinned then
-          local last_commit = Git.get_commit(self.plugin.dir, target.branch, true)
-          if not Git.eq(info, { commit = last_commit }) then
-            self.plugin._.outdated = true
+      if not self.plugin._.is_local then
+        if Git.eq(info, target) then
+          if Config.options.checker.check_pinned then
+            local last_commit = Git.get_commit(self.plugin.dir, target.branch, true)
+            if not Git.eq(info, { commit = last_commit }) then
+              self.plugin._.outdated = true
+            end
           end
+        else
+          self.plugin._.updates = { from = info, to = target }
         end
-      else
-        self.plugin._.updates = { from = info, to = target }
       end
       table.insert(args, info.commit .. ".." .. target.commit)
     else
@@ -63,6 +67,14 @@ M.log = {
       args = args,
       cwd = self.plugin.dir,
     })
+
+    -- for local plugins, mark as needing updates only if local is
+    -- behind upstream, i.e. if git log gave no output
+    if opts.check and self.plugin._.is_local then
+      if not vim.tbl_isempty(self:get_log()) then
+        self.plugin._.updates = { from = info, to = target }
+      end
+    end
   end,
 }