moving label toLowercase code up to top of function

This commit is contained in:
Benjamin Lannon 2022-03-05 10:54:46 -05:00
commit 45dd92ff81

View file

@ -82,15 +82,15 @@ function diffLabels(oldLabels, newLabels) {
// each entry has two values // each entry has two values
// { type: 'create' | 'update' | 'delete', label } // { type: 'create' | 'update' | 'delete', label }
let oldLabelsNames = oldLabels.map((label) => label.name); let oldLabelsNames = oldLabels.map((label) => label.name.toLowerCase());
let newLabelsNames = newLabels.map((label) => label.name); let newLabelsNames = newLabels.map((label) => label.name.toLowerCase());
let labelModList = []; let labelModList = [];
oldLabelsNames.forEach((oLabel) => { oldLabelsNames.forEach((oLabel) => {
// when using `includes` with strings, the match is case-sensitive // when using `includes` with strings, the match is case-sensitive
// so we first lowercase both strings when comparing // so we first lowercase both strings when comparing
if (newLabelsNames.toLowerCase().includes(oLabel.toLowerCase())) { if (newLabelsNames.includes(oLabel)) {
const oldLabel = oldLabels.filter((l) => l.name === oLabel)[0]; const oldLabel = oldLabels.filter((l) => l.name === oLabel)[0];
const newLabel = newLabels.filter((l) => l.name === oLabel)[0]; const newLabel = newLabels.filter((l) => l.name === oLabel)[0];